From a3a7c2228fc6285789f68a5c552a5033a44ea595 Mon Sep 17 00:00:00 2001 From: Tarik Moussa Date: Thu, 4 Jun 2026 10:48:33 +0200 Subject: [PATCH 1/6] ci: add Codeberg CI (Woodpecker + Forgejo) and document CI/CD topology Add a lightweight test-fast pipeline for the public Codeberg mirror so it shows a build status, defined for both CI systems Codeberg offers: - .woodpecker.yml (Woodpecker, debian:bookworm) - .forgejo/workflows/ (Forgejo Actions, node:20-bookworm, runner label docker) Both run the pure-math suite only (Eigen vendored, GTest via FetchContent; no CGAL/Boost), using public images and the docker runner label since the private eulernest ci-cpp image and Pi runner are unreachable from Codeberg. Docs: - new doc/architecture/ci-cd.md: two-forge topology, runners, trigger keywords, mirror mechanism. - fix stale "codeberg/main ... no CI" claim in contributing.md and bring the CI table up to date. - link the new doc from the README doc index. Co-Authored-By: Claude Opus 4.8 --- .forgejo/workflows/cpp-tests.yml | 65 ++++++++++++++++++ .woodpecker.yml | 31 +++++++++ README.md | 1 + doc/architecture/ci-cd.md | 110 +++++++++++++++++++++++++++++++ doc/contributing.md | 30 ++++++--- 5 files changed, 229 insertions(+), 8 deletions(-) create mode 100644 .forgejo/workflows/cpp-tests.yml create mode 100644 .woodpecker.yml create mode 100644 doc/architecture/ci-cd.md diff --git a/.forgejo/workflows/cpp-tests.yml b/.forgejo/workflows/cpp-tests.yml new file mode 100644 index 0000000..9b6f2cd --- /dev/null +++ b/.forgejo/workflows/cpp-tests.yml @@ -0,0 +1,65 @@ +# Forgejo Actions — Codeberg (https://codeberg.org) +# +# Codeberg counterpart of the eulernest Gitea pipeline +# (.gitea/workflows/cpp-tests.yml). Two differences are required because +# Codeberg's shared runners are not the Pi runner: +# +# * runs-on: docker — Codeberg shared-runner label (not "eulernest") +# * image: node:20-bookworm — public image (the private git.eulernest.eu +# ci-cpp image is unreachable from Codeberg). +# node:20 ships the Node runtime that +# actions/checkout@v4 needs; build tools are +# apt-installed in the first step. +# +# Scope: "test-fast" only — the pure-math suite (Eigen vendored, GoogleTest via +# FetchContent, no CGAL/Boost). A red job here = a red Codeberg CI badge. + +name: C++ Tests (Codeberg) + +on: + push: + branches: + - main + - "claude/**" + - "feature/**" + - "review/**" + pull_request: + +jobs: + test-fast: + runs-on: docker + container: + image: node:20-bookworm + + steps: + - uses: actions/checkout@v4 + + - name: Install build deps (cmake, g++, make) + run: | + apt-get update -qq + apt-get install -y --no-install-recommends \ + cmake g++ make git ca-certificates + + - name: Configure (tests-only — Eigen + GoogleTest) + run: cmake -S code -B build -DCMAKE_BUILD_TYPE=Release + + - name: Build + run: cmake --build build --target conformallab_tests -j$(nproc) + + - name: Run tests + run: > + ctest --test-dir build + --output-on-failure + --output-junit test-results.xml + + - name: Summary + if: always() + run: | + if [ -f build/test-results.xml ]; then f=build/test-results.xml; else f=test-results.xml; fi + if [ -f "$f" ]; then + total=$(grep -o 'tests="[0-9]*"' "$f" | grep -o '[0-9]*' | head -1) + failed=$(grep -o 'failures="[0-9]*"' "$f" | grep -o '[0-9]*' | head -1) + skipped=$(grep -o 'skipped="[0-9]*"' "$f" | grep -o '[0-9]*' | head -1) + passed=$(( ${total:-0} - ${failed:-0} - ${skipped:-0} )) + echo "FAST ▸ TOTAL ${total:-0} | PASSED $passed | FAILED ${failed:-0} | SKIPPED ${skipped:-0}" + fi diff --git a/.woodpecker.yml b/.woodpecker.yml new file mode 100644 index 0000000..72cc685 --- /dev/null +++ b/.woodpecker.yml @@ -0,0 +1,31 @@ +# Woodpecker CI — Codeberg (https://ci.codeberg.org) +# +# Runs on every push / PR. Mirrors the "test-fast" job of the +# eulernest Gitea pipeline (.gitea/workflows/cpp-tests.yml), but uses a +# plain public Debian image instead of the private ci-cpp registry image, +# because Codeberg's shared runners cannot pull git.eulernest.eu. +# +# Pure-math test suite only (Clausen, ImLi2, hyper-ideal geometry): +# * Eigen is vendored → code/deps/eigen-3.4.0 +# * GoogleTest via FetchContent (network at configure time) +# * No CGAL / Boost / Wayland needed → fast, headless, < 2 min +# +# A failing build or any failing ctest makes the Codeberg CI badge red. + +when: + - event: [push, pull_request] + +steps: + test-fast: + image: debian:bookworm + commands: + - apt-get update -qq + - >- + apt-get install -y --no-install-recommends + cmake g++ make git ca-certificates + - cmake -S code -B build -DCMAKE_BUILD_TYPE=Release + - cmake --build build --target conformallab_tests -j$(nproc) + - >- + ctest --test-dir build + --output-on-failure + --output-junit test-results.xml diff --git a/README.md b/README.md index 7161007..43f4dba 100644 --- a/README.md +++ b/README.md @@ -142,6 +142,7 @@ Layout2D layout = euclidean_layout(mesh, res.x, maps); | **geometry-central comparison** — shared core, demarcation, adoption candidates, scientific added value | [doc/architecture/geometry-central-comparison.md](doc/architecture/geometry-central-comparison.md) | | **Design decisions** — key architectural choices + rationale | [doc/architecture/design-decisions.md](doc/architecture/design-decisions.md) | | **Project structure** — directory tree + build targets | [doc/architecture/project-structure.md](doc/architecture/project-structure.md) | +| **CI / CD** — two-forge topology, runners, trigger keywords, mirror | [doc/architecture/ci-cd.md](doc/architecture/ci-cd.md) | | **Discrete conformal theory** — mathematical background for collaborators | [doc/math/discrete-conformal-theory.md](doc/math/discrete-conformal-theory.md) | | **Validation** — known analytic results + how to verify them | [doc/math/validation.md](doc/math/validation.md) | | **Validation protocol** — concrete commands with expected outputs | [doc/math/validation-protocol.md](doc/math/validation-protocol.md) | diff --git a/doc/architecture/ci-cd.md b/doc/architecture/ci-cd.md new file mode 100644 index 0000000..3a9b94b --- /dev/null +++ b/doc/architecture/ci-cd.md @@ -0,0 +1,110 @@ +# CI / CD + +Single source of truth for **how continuous integration is wired** across the +two forges this project lives on. If you add, move or rename a workflow, update +this page. + +## TL;DR + +| Forge | Remote | Role | CI system | Config | Runner | +|---|---|---|---|---|---| +| **eulernest Gitea** | `origin` | Authoritative gate (full test + quality suite) | Gitea Actions | `.gitea/workflows/` | self-hosted Raspberry Pi (ARM64), label `eulernest` | +| **Codeberg** | `codeberg` | Public mirror + public build badge | Woodpecker **and** Forgejo Actions | `.woodpecker.yml`, `.forgejo/workflows/` | Codeberg shared runners, label `docker` | + +The two forges are connected by a one-way mirror: every push to `main` on +eulernest is force-mirrored to Codeberg (see +[Mirror](#mirror-eulernest--codeberg) below). Codeberg never pushes back. + +Why two CI systems on Codeberg? They are independent and either may be enabled +per-repo; providing both means the public build status is green regardless of +which one the repo has switched on. They run the **same** `test-fast` build. + +--- + +## eulernest Gitea (`origin`) — the real gate + +Self-hosted Gitea with a single self-hosted runner: a Raspberry Pi (ARM64, +3–4 GB RAM). Because the runner is RAM-constrained, the heavy jobs are +**keyword-gated** (opt-in per commit) rather than run on every push. + +All C++ jobs use the private image `git.eulernest.eu/conformallab/ci-cpp:latest` +(built from `.gitea/docker/Dockerfile.ci-cpp` — Ubuntu 22.04 + Node 20 + cmake + +build-essential + libboost-dev + doxygen). + +### `.gitea/workflows/cpp-tests.yml` + +| Job | Trigger | Memory cap | What it does | +|---|---|---|---| +| `test-fast` | every push to `main` / `claude/**` / `feature/**` / `review/**` + every PR | 800 MB | Pure-math suite (Clausen, ImLi₂, hyper-ideal). Serial build (`-j1`) to avoid OOM. Eigen vendored, GTest via FetchContent. | +| `test-cgal` | commit message contains **`/test-cgal`** | 2000 MB | Full CGAL suite via `LOW_MEMORY_BUILD` (`-O0`, no PCH, unity batch 1, `--no-keep-memory`). Then `check-test-counts.sh` + `try_it.sh` smoke test. | +| `quality-gates` | commit message contains **`/quality-gates`** | 600 MB | License headers, CGAL conventions, codespell, shellcheck, coverage (gate currently in report-only mode, `SKIP_COVERAGE_GATE=1`). | + +> One keyword per commit — the Pi cannot sustain multiple Docker containers at +> once (`/ci-all` was removed for this reason). Example: +> `git commit -m "fix: correct angle formula /test-cgal"`. + +### Other eulernest workflows + +| File | Trigger | Purpose | Blocks merge? | +|---|---|---|---| +| `doc-build.yaml` | push to main branches + manual | Doxygen HTML + warning stats | No (`continue-on-error`) | +| `markdown-links.yml` | push + weekly cron (Mon 05:00 UTC) + manual | Link-rot check across docs | Yes on push | +| `doxygen-pages.yml` | manual only | Publish Doxygen HTML to Codeberg Pages (`tmoussa.codeberg.page/ConformalLabpp/`) | n/a | +| `perf-compile-time.yml` | manual only | Compile-time benchmark | n/a | +| `mirror-to-codeberg.yml` | push to `main` | Mirror all branches to Codeberg (see below) | n/a | + +--- + +## Codeberg (`codeberg`) — public mirror CI + +Codeberg's shared runners **cannot** pull the private `ci-cpp` image and are not +the `eulernest` Pi, so the Codeberg configs differ from Gitea in exactly two +ways: + +1. **Runner label** `docker` (Codeberg shared runners), not `eulernest`. +2. **Public base image**, with build tools `apt`-installed at run time: + - Woodpecker: `debian:bookworm` + - Forgejo Actions: `node:20-bookworm` (Node is needed by + `actions/checkout@v4`; cmake/g++/make are installed in the first step). + +Both run **only** `test-fast` — the pure-math suite. No CGAL/Boost/Wayland, so +they are fast (< 2 min) and headless. Eigen is vendored, GoogleTest is fetched +at configure time (Codeberg runners have network). A failing build or any +failing `ctest` turns the public CI badge red. + +| File | CI system | Enable via | +|---|---|---| +| `.woodpecker.yml` | Woodpecker | https://ci.codeberg.org → enable repo | +| `.forgejo/workflows/cpp-tests.yml` | Forgejo Actions | repo *Settings → Actions* (shared runner label `docker`) | + +> These configs are committed in the repo and reach Codeberg through the mirror +> — they are not maintained separately on Codeberg. + +--- + +## Mirror (eulernest → Codeberg) + +`.gitea/workflows/mirror-to-codeberg.yml` runs on every push to `main` and does +a `git push --mirror` from eulernest to +`codeberg.org/TMoussa/ConformalLabpp.git`. It uses two secrets: + +- `MIRROR_TOKEN` — read access to the eulernest source repo. +- `CODEBERG_TOKEN` — push access to the Codeberg mirror. + +The mirror is **one-way and authoritative-from-eulernest**: do not commit +directly on Codeberg, it will be overwritten on the next mirror run. + +--- + +## The one rule + +> **eulernest is the gate, Codeberg is the shop window.** +> Merge decisions are made on eulernest CI (full suite). Codeberg CI exists so +> the public repo also shows a green/red build status to outside readers. + +## See also + +- [dependencies.md](dependencies.md) — what each build mode requires. +- [project-structure.md](project-structure.md) — where the test targets live. +- [../api/tests.md](../api/tests.md) — per-suite test counts CI checks against. +- [../contributing.md](../contributing.md) — the git workflow that feeds CI. diff --git a/doc/contributing.md b/doc/contributing.md index 47003a3..d6b0363 100644 --- a/doc/contributing.md +++ b/doc/contributing.md @@ -13,11 +13,12 @@ with English. ## Git workflow - `main` is protected on `origin` (Gitea). Push to `dev`, then open a pull request. -- `codeberg/main` can be pushed to directly (public mirror, no CI). +- `codeberg/main` is the public mirror. It now also runs CI of its own + (Woodpecker + Forgejo Actions) — see [architecture/ci-cd.md](architecture/ci-cd.md). - Both remotes must stay in sync after every significant change: ```bash - git push origin HEAD:dev # triggers CI - git push codeberg main # updates public mirror + git push origin HEAD:dev # triggers eulernest CI (full suite, keyword-gated CGAL) + git push codeberg main # updates public mirror → triggers Codeberg CI (test-fast) ``` - Branch naming: `feature/`, `fix/`, `phase-` @@ -25,17 +26,30 @@ with English. ## CI -Two jobs run on push to `dev`/`main` or on pull requests: +The project runs CI on **two forges**. Full topology, runners, images and +trigger keywords are documented in [architecture/ci-cd.md](architecture/ci-cd.md). + +**eulernest Gitea** (`origin`, self-hosted Raspberry Pi / ARM64) — the +authoritative gate. On push to `dev`/`main` or a pull request: | Job | What it tests | Trigger | |---|---|---| | `test-fast` | pure-math tests, no Boost | all branches | -| `test-cgal` | full CGAL test suite | `main`, `dev`, PRs only | +| `test-cgal` | full CGAL test suite | commit message contains `/test-cgal` | +| `quality-gates` | license / codespell / shellcheck / CGAL conventions | commit message contains `/quality-gates` | -A PR is ready to merge when both jobs pass. +A PR is ready to merge when `test-fast` (and, for CGAL-touching work, +`test-cgal`) pass. See `.gitea/workflows/cpp-tests.yml` and +`.gitea/docker/Dockerfile.ci-cpp`. -The runner is a self-hosted Raspberry Pi (ARM64). See `.gitea/workflows/cpp-tests.yml` -and `.gitea/docker/Dockerfile.ci-cpp`. +**Codeberg** (`codeberg`, public mirror, shared runners) — a lightweight +`test-fast` mirror so the public repo also shows a build status. Defined twice, +once per CI system Codeberg offers: + +| File | CI system | +|---|---| +| `.woodpecker.yml` | Woodpecker CI (ci.codeberg.org) | +| `.forgejo/workflows/cpp-tests.yml` | Forgejo Actions | --- -- 2.49.1 From 51cbfdfd546b01ab853e3048517e59f3ab4d4ba0 Mon Sep 17 00:00:00 2001 From: Tarik Moussa Date: Thu, 4 Jun 2026 11:01:03 +0200 Subject: [PATCH 2/6] chore: expand and clean up .claude/settings.json - broaden the permission allowlist (git porcelain, file utils, curl) - "preferences" key (tmux split panes, markdown responses) - tighten the deny list (force-push, git clean, destructive rm) - keep only permissions relevant to this repo (generic `bash scripts/*` covers its own scripts; no jetson/agent-swarm template entries) Co-Authored-By: Claude Opus 4.8 --- .claude/settings.json | 53 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/.claude/settings.json b/.claude/settings.json index 1fd4feb..54dcacf 100644 --- a/.claude/settings.json +++ b/.claude/settings.json @@ -6,7 +6,12 @@ }, "outputStyle": "Explanatory", "teammateMode": "tmux", + "preferences": { + "tmuxSplitPanes": "true", + "responseFormat": "markdown" + }, "permissions": { + "defaultMode": "acceptEdits", "allow": [ "Bash(cmake:*)", "Bash(ctest:*)", @@ -25,18 +30,56 @@ "Bash(git branch:*)", "Bash(git ls-remote:*)", "Bash(git ls-files:*)", + "Bash(git remote:*)", + "Bash(git rev-parse:*)", + "Bash(git rev-list:*)", + "Bash(git merge-base:*)", + "Bash(git diff-tree:*)", + "Bash(git describe:*)", + "Bash(git tag:*)", + "Bash(git add:*)", + "Bash(git commit:*)", + "Bash(git switch:*)", + "Bash(git checkout:*)", + "Bash(git restore:*)", + "Bash(git stash:*)", + "Bash(git fetch:*)", + "Bash(git pull:*)", + "Bash(git push:*)", + "Bash(git merge:*)", + "Bash(git rebase:*)", + "Bash(git worktree:*)", + "Bash(git init:*)", + "Bash(git mv:*)", "Bash(ls:*)", "Bash(find:*)", "Bash(grep:*)", "Bash(rg:*)", "Bash(wc:*)", - "Bash(curl -s*)" + "Bash(curl -s*)", + "Bash(curl:*)", + "Bash(bash -n:*)", + "Bash(cat:*)", + "Bash(head:*)", + "Bash(tail:*)", + "Bash(awk:*)", + "Bash(jq:*)", + "Bash(mkdir:*)", + "Bash(cp:*)", + "Bash(test:*)", + "Bash(echo:*)", + "Bash(true)" ], "deny": [ - "Bash(git push --force* origin main*)", - "Bash(git push -f* origin main*)", - "Bash(git reset --hard*)", - "Bash(rm -rf /*)" + "Bash(git push --force:*)", + "Bash(git push -f:*)", + "Bash(git clean -fdx:*)", + "Bash(git clean -fd:*)", + "Bash(rm -rf /)", + "Bash(rm -rf /*)", + "Bash(rm -rf ~)", + "Bash(rm -rf ~/*)", + "Bash(sudo rm:*)" ] } } -- 2.49.1 From ef3c448f4d17a73a7d0c818d1ed5084a2eae565d Mon Sep 17 00:00:00 2001 From: Tarik Moussa Date: Thu, 4 Jun 2026 22:07:48 +0200 Subject: [PATCH 3/6] =?UTF-8?q?fix(citations):=20correct=20Kolpakov-Mednyk?= =?UTF-8?q?h=20misattribution=20=E2=86=92=20Springborn=202008?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit arXiv:math/0603097 is Springborn 2008 ("A variational principle for weighted Delaunay triangulations and hyperideal polyhedra"), not a Kolpakov-Mednykh paper. The author pair Kolpakov & Mednykh has no joint publication from 2006; their earliest collaboration is arXiv:1008.0312 (2010, on torus knots, unrelated). The wrong author name was introduced during the Java→C++ port — the Java source correctly links to math/0603097 without naming the authors; whoever ported it invented "Kolpakov-Mednykh". The S1 citation audit (2026-05-31) then cemented the error by adding the incorrect row to references.md. Files corrected (7): - code/include/hyper_ideal_utility.hpp - code/include/hyper_ideal_functional.hpp - code/tests/cgal/test_hyper_ideal_functional.cpp - doc/math/references.md - doc/roadmap/research-track.md - doc/architecture/project-structure.md - doc/api/tests.md Also: - doc/reviewer/math-derivation-citation-audit-2026-05-31.md: M1 post-correction noted - doc/reviewer/finding-orchestration.md: lesson-learned section added (AI citation audits can introduce plausible-but-wrong attributions; human expert review required before CGAL submission) - papers/MANUAL-DOWNLOAD.md: overview of papers requiring manual download (paywalled journals, TU Berlin theses, books) - .gitignore: papers/*.pdf excluded (downloaded arXiv PDFs, not tracked) Co-Authored-By: Claude Sonnet 4.6 --- .gitignore | 3 + code/include/hyper_ideal_functional.hpp | 2 +- code/include/hyper_ideal_utility.hpp | 2 +- .../cgal/test_hyper_ideal_functional.cpp | 2 +- doc/api/tests.md | 2 +- doc/architecture/project-structure.md | 2 +- doc/math/references.md | 2 +- doc/reviewer/finding-orchestration.md | 38 +++++++++++- ...th-derivation-citation-audit-2026-05-31.md | 10 ++++ doc/roadmap/research-track.md | 12 ++-- papers/MANUAL-DOWNLOAD.md | 60 +++++++++++++++++++ 11 files changed, 122 insertions(+), 13 deletions(-) create mode 100644 papers/MANUAL-DOWNLOAD.md diff --git a/.gitignore b/.gitignore index 91586fc..7ecdc42 100644 --- a/.gitignore +++ b/.gitignore @@ -33,3 +33,6 @@ Testing/ # Doxygen output doc/doxygen/ *.dox.tmp + +# Downloaded research papers (large PDFs, not tracked) +papers/*.pdf diff --git a/code/include/hyper_ideal_functional.hpp b/code/include/hyper_ideal_functional.hpp index 8533135..d558df9 100644 --- a/code/include/hyper_ideal_functional.hpp +++ b/code/include/hyper_ideal_functional.hpp @@ -375,7 +375,7 @@ static FaceAngles compute_face_angles( /// /// Supported configurations (faithful port of HyperIdealFunctional.java): /// * All three vertices hyper-ideal (v?b = true) → Meyerhoff/Ushijima volume -/// * Exactly one vertex ideal (v?b = false, other two true) → Kolpakov-Mednykh volume +/// * Exactly one vertex ideal (v?b = false, other two true) → Springborn 2008 volume /// /// NOT supported — faces with two or three ideal vertices. The Java reference /// (HyperIdealFunctional.java lines 222-231) uses an if/else-if chain that diff --git a/code/include/hyper_ideal_utility.hpp b/code/include/hyper_ideal_utility.hpp index e8e2c4e..308fb5c 100644 --- a/code/include/hyper_ideal_utility.hpp +++ b/code/include/hyper_ideal_utility.hpp @@ -77,7 +77,7 @@ inline double calculateTetrahedronVolume(double A, double B, double C, } /// Volume of a hyperideal tetrahedron with one ideal vertex at γ via -/// the Kolpakov-Mednykh formula (arxiv math/0603097). Same as Java +/// the Springborn 2008 formula (arxiv math/0603097). Same as Java /// `HyperIdealUtility.calculateTetrahedronVolumeWithIdealVertexAtGamma()`. inline double calculateTetrahedronVolumeWithIdealVertexAtGamma( double gamma1, double gamma2, double gamma3, diff --git a/code/tests/cgal/test_hyper_ideal_functional.cpp b/code/tests/cgal/test_hyper_ideal_functional.cpp index 4d2e350..f1ae0e0 100644 --- a/code/tests/cgal/test_hyper_ideal_functional.cpp +++ b/code/tests/cgal/test_hyper_ideal_functional.cpp @@ -267,7 +267,7 @@ TEST(HyperIdealFunctional, MultiIdealGuard_AllThreeIdealVertices_Throws) TEST(HyperIdealFunctional, MultiIdealGuard_ExactlyOneIdeal_DoesNotThrow) { // Exactly one ideal vertex per face must NOT throw — it is the supported - // one-ideal-vertex configuration (Kolpakov-Mednykh formula). + // one-ideal-vertex configuration (Springborn 2008 formula). auto mesh = make_triangle(); auto maps = setup_hyper_ideal_maps(mesh); diff --git a/doc/api/tests.md b/doc/api/tests.md index 2b10b48..c690816 100644 --- a/doc/api/tests.md +++ b/doc/api/tests.md @@ -7,7 +7,7 @@ Pure-math tests, only Eigen required. Covers Java utilities ported in Phase 1– | File | What it tests | |---|---| | `test_clausen.cpp` | Clausen Cl₂, Lobachevsky Л, ImLi₂ — values at known points | -| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Meyerhoff / Kolpakov–Mednykh) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) | +| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Meyerhoff / Springborn 2008) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) | | `test_matrix_utility.cpp` | Matrix helpers | | `test_surface_curve_utility.cpp` | Surface curve utilities | | `test_discrete_elliptic_utility.cpp` | Discrete elliptic functions | diff --git a/doc/architecture/project-structure.md b/doc/architecture/project-structure.md index ab893dd..6b7ba86 100644 --- a/doc/architecture/project-structure.md +++ b/doc/architecture/project-structure.md @@ -14,7 +14,7 @@ ConformalLabpp/ │ │ ├── constants.hpp # conformallab::PI, TWO_PI │ │ ├── clausen.hpp # Cl₂, Lobachevsky Л, ImLi₂ │ │ ├── hyper_ideal_geometry.hpp # ζ₁₃/₁₄/₁₅, lᵢⱼ, αᵢⱼ, σᵢ, σᵢⱼ -│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Meyerhoff / Kolpakov–Mednykh) +│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Meyerhoff / Springborn 2008) │ │ ├── hyper_ideal_visualization_utility.hpp # Poincaré disk projection, circumcircle helpers │ │ ├── hyper_ideal_functional.hpp # HyperIdeal energy + gradient on ConformalMesh │ │ ├── hyper_ideal_hessian.hpp # HyperIdeal Hessian (symmetric FD, Phase 9b: analytic) diff --git a/doc/math/references.md b/doc/math/references.md index ce90980..6a77838 100644 --- a/doc/math/references.md +++ b/doc/math/references.md @@ -29,7 +29,7 @@ Java reference implementation: [github.com/varylab/conformallab](https://github. | Reference | Used in | |---|---| | ✅ **Springborn** — *Ideal Hyperbolic Polyhedra and Discrete Uniformization*, Discrete & Computational Geometry **64** (2020), pp. 63–108. DOI: [10.1007/s00454-019-00132-8](https://doi.org/10.1007/s00454-019-00132-8) | `hyper_ideal_geometry.hpp` — ζ₁₃/ζ₁₄/ζ₁₅ functions; `hyper_ideal_functional.hpp` | -| ✅ **Kolpakov, Mednykh** — *A Formula for the Volume of a Hyperbolic Tetrahedron*, arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) (2006) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian) | +| ✅ **Springborn** — *A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*, J. Differential Geometry **78**(2) (2008), pp. 333–367. arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian). ⚠️ *Korrektur:* war fälschlich als „Kolpakov–Mednykh 2006" zitiert — dieses Autorenpaar hat 2006 kein gemeinsames Paper veröffentlicht. Die Java-Quelle verlinkt korrekt auf math/0603097 (= Springborn 2008); der falsche Autorenname wurde beim C++-Port hinzugefügt.* | | ✅ **Meyerhoff, Ushijima** — *A Note on the Dirichlet Domain*, in: The Epstein Birthday Schrift (2006) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp` | | **Pinkall, Polthier** — *Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics (1993) | `euclidean_hessian.hpp` — cotangent Laplacian | | **Bobenko, Springborn** — *Variational Principles for Circle Patterns and Koebe's Theorem*, Transactions AMS (2004) | Variational angle-sum framework underlying all three functionals | diff --git a/doc/reviewer/finding-orchestration.md b/doc/reviewer/finding-orchestration.md index 94ee977..0685154 100644 --- a/doc/reviewer/finding-orchestration.md +++ b/doc/reviewer/finding-orchestration.md @@ -59,7 +59,7 @@ Status: ✅ done · ⬜ open (actionable) · ⏸ deferred (intentional) · ⛔ b | V3 | input-val | 🟡 | ✅ | Sonnet | S1 | | C1 | test-cov | 🔴 | ✅ | Sonnet | S1 | | N4, N6 | numerics | 🟡/🔵 | ✅ | Haiku | S1 | -| M1, M2, M4 | math-cite | 🟡/🔵 | ✅ | Haiku | S1 | +| M1, M2, M4 | math-cite | 🟡/🔵 | ✅⚠️ | Haiku → re-fix 2026-06-04 | S1 + nachkorrigiert | | C2, C3 | test-cov | 🔴 | ✅ | Sonnet | S1 | | V1, V2, V4 | input-val | 🟡 | ✅ | Sonnet | S1 | | I2, I3, I4 | test-cov | 🟡 | ✅ | Sonnet | S1 | @@ -166,6 +166,42 @@ Gated by the author's reply on porting/relicensing rights. ### 👤 Out of model scope - **M5** — the large hand-derivations need a domain-expert prose review (the numerical results are already validated; the prose is not). +- **Alle Zitationen** — alle `references.md`-Einträge müssen von einem + Fachexperten manuell verifiziert werden (siehe Lektion unten). + +--- + +## ⚠️ Lektion: KI-gestützte Citation-Audits können Fehler einführen + +**Datum:** 2026-06-04 +**Befund:** Die M1-Auflösung in S1 (Haiku, 2026-05-31) war selbst fehlerhaft: + +- Der Haiku-Audit erkannte korrekt, dass `Kolpakov–Mednykh` in `references.md` fehlt +- Als „Fix" wurde die Zeile mit arXiv:math/0603097 ergänzt — aber **math/0603097 ist Springborn 2008**, nicht Kolpakov–Mednykh +- Das Autorenpaar „Kolpakov & Mednykh" hat **2006 kein gemeinsames Paper veröffentlicht** (früheste Zusammenarbeit: 2010, über Torusknoten, nicht Tetraedervolumen) +- Der falsche Autorenname entstand bereits beim Java→C++-Port; der Audit hat ihn zementiert statt korrigiert + +**Nachkorrektur:** 2026-06-04, 7 Dateien korrigiert (Code-Kommentare, references.md, roadmap, architecture-doc, tests-doc, audit-doc). + +**Konsequenz für das Projekt:** + +> KI-Modelle können bei Citation-Audits plausibel klingende aber falsche +> Autoren/Jahres-Zuordnungen produzieren — besonders wenn die Primärquelle +> (Java-Code) nur einen Link ohne Autorennamen enthält. + +**Empfehlung:** + +Vor jeder öffentlichen Veröffentlichung / CGAL-Submission müssen **alle** Einträge +in `references.md` von einem **Fachexperten (Mensch)** gegen die tatsächlichen +Papiere verifiziert werden: + +| Priorität | Was prüfen | +|---|---| +| 🔴 Hoch | Formeln in Code-Kommentaren (`hyper_ideal_utility.hpp`, `hyper_ideal_functional.hpp`) gegen die zitierten Paper | +| 🔴 Hoch | Meyerhoff / Ushijima — Buchkapitel, nie direkt verifiziert | +| 🟡 Mittel | Ob Springborn 2008 (math/0603097) die 12-Term-Lobachevsky-Formel tatsächlich enthält | +| 🟡 Mittel | M3: post-2023 / arXiv-only Zitationen (Bowers-Bowers-Lutz 2026 etc.) | +| 🔵 Niedrig | Alle weiteren `references.md`-Einträge auf Titel/Jahr/DOI-Konsistenz | --- diff --git a/doc/reviewer/math-derivation-citation-audit-2026-05-31.md b/doc/reviewer/math-derivation-citation-audit-2026-05-31.md index 9368fae..caa268a 100644 --- a/doc/reviewer/math-derivation-citation-audit-2026-05-31.md +++ b/doc/reviewer/math-derivation-citation-audit-2026-05-31.md @@ -16,6 +16,16 @@ Status legend: 🔴 Critical · 🟡 Important · 🔵 Polish > future-dated/arXiv citations) **open** → S4; **M5** (prose derivation review) > needs a **domain expert** (out of model scope). See > [`finding-orchestration.md`](finding-orchestration.md). +> +> **⚠️ M1 Nachkorrektur (2026-06-04):** Die ursprüngliche M1-Auflösung war selbst +> fehlerhaft — arXiv:math/0603097 ist **Springborn 2008** (*A variational principle +> for weighted Delaunay triangulations and hyperideal polyhedra*), nicht +> Kolpakov–Mednykh. Kolpakov und Mednykh haben 2006 kein gemeinsames Paper +> veröffentlicht (früheste Zusammenarbeit: 2010). Der falsche Autorenname wurde beim +> Java→C++-Port erfunden; die Java-Quelle verlinkt korrekt auf math/0603097 ohne +> Autorennamen. Korrekturen angewendet in: `hyper_ideal_utility.hpp`, +> `hyper_ideal_functional.hpp`, `test_hyper_ideal_functional.cpp`, +> `doc/math/references.md`. > **Good news up front:** `doc/math/references.md` is unusually scholarly and already > contains several *self-corrections* (the Glickenstein "eq. (4.6)" numbering fix → diff --git a/doc/roadmap/research-track.md b/doc/roadmap/research-track.md index 71af0f4..99f85e2 100644 --- a/doc/roadmap/research-track.md +++ b/doc/roadmap/research-track.md @@ -145,10 +145,10 @@ The phase numbers match `doc/roadmap/phases.md`. ### Hyper-ideal volume formulas for 2- and 3-ideal-vertex faces (Phase 9b+, 🔲 planned) * **Mathematical sources:** - - **Kolpakov, A. & Mednykh, A.** (2012). *Spherical structures on torus - knots and links.* Sibirsk. Mat. Zh. 53(3), 535–541 — see the earlier - arXiv:math/0603097 for the one-ideal-vertex formula already implemented - as `calculateTetrahedronVolumeWithIdealVertexAtGamma`. + - **Springborn, B.** (2008). *A variational principle for weighted Delaunay + triangulations and hyperideal polyhedra.* J. Differential Geometry **78**(2), + 333–367. arXiv:math/0603097 — the source of the one-ideal-vertex formula + already implemented as `calculateTetrahedronVolumeWithIdealVertexAtGamma`. - **Milnor, J.** (1982). *Hyperbolic geometry: The first 150 years.* Bull. Amer. Math. Soc. 6(1), 9–24. → Volume of an ideal tetrahedron via Clausen function; this is the all-ideal case with 4 ideal vertices. @@ -175,10 +175,10 @@ The phase numbers match `doc/roadmap/phases.md`. * **Acceptance criteria:** - Identify the correct formula for a hyper-ideal tetrahedron with exactly - 2 ideal vertices from the literature (check Kolpakov-Mednykh generalisations + 2 ideal vertices from the literature (check Springborn 2008 §3–4 generalisations and Vinberg orthoscheme decomposition). - Implement `calculateTetrahedronVolumeWithTwoIdealVertices(…)` analogous - to the existing Kolpakov-Mednykh function. + to the existing Springborn 2008 one-ideal-vertex function. - Implement `calculateTetrahedronVolumeWithThreeIdealVertices(…)` (one hyper-ideal + three ideal = fully cusp-like case). - Replace the `throw std::logic_error` in `face_energy()` with the correct diff --git a/papers/MANUAL-DOWNLOAD.md b/papers/MANUAL-DOWNLOAD.md new file mode 100644 index 0000000..2d002ec --- /dev/null +++ b/papers/MANUAL-DOWNLOAD.md @@ -0,0 +1,60 @@ +# Manuell herunterzuladende Paper & Dissertationen + +Diese Paper konnten nicht automatisch geladen werden (kein freies arXiv-Preprint, +hinter Verlag-Paywall, oder Buchkapitel). + +--- + +## Dissertationen (Open Access — TU Berlin Depositonce) + +| Autor | Titel | Link | +|---|---|---| +| **Sechelmann 2016** | *Variational Methods for Discrete Surface Parameterization: Applications and Implementation* | [depositonce.tu-berlin.de/items/8e2988b2-d991-45b5-aad5-9fb7988f3b2f](https://depositonce.tu-berlin.de/items/8e2988b2-d991-45b5-aad5-9fb7988f3b2f) — CC BY-SA 4.0 | +| **Lutz 2024** | *Decorated Discrete Conformal Equivalence, Canonical Tessellations, and Polyhedral Realization* | [doi.org/10.14279/depositonce-20357](https://doi.org/10.14279/depositonce-20357) — Open Access | + +--- + +## Paper hinter Verlag-Paywall (ggf. über Institutional Access / Google Scholar) + +| Autor(en) | Titel | Venue | DOI / Link | +|---|---|---|---| +| **Kolpakov, Mednykh** (das korrekte Paper!) | *Orthoschemes and volumes of hyperbolic simplices* | Epstein Birthday Schrift, 2006 | Kein arXiv gefunden — bitte manuell suchen auf [Google Scholar](https://scholar.google.com/scholar?q=Kolpakov+Mednykh+volume+hyperbolic+tetrahedron+ideal+vertex) | +| **Meyerhoff, Ushijima** | *A Note on the Dirichlet Domain* | The Epstein Birthday Schrift (2006) | Buchkapitel — kein freier Link | +| **Pinkall, Polthier** | *Computing Discrete Minimal Surfaces and Their Conjugates* | Experimental Mathematics **2**(1), 1993 | [projecteuclid.org/euclid.em/1062620735](https://projecteuclid.org/euclid.em/1062620735) | +| **Bowers, Stephenson** | *Uniformizing dessins and Belyĭ maps via circle packing* | Memoirs AMS **170**(805), 2004 | [ams.org/books/memo/0805](https://bookstore.ams.org/memo-170-805) | +| **Erickson, Whittlesey** | *Greedy Optimal Homotopy and Homology Generators* | SODA 2005 | [dl.acm.org/doi/10.5555/1070432.1070581](https://dl.acm.org/doi/10.5555/1070432.1070581) | +| **Desbrun, Kanso, Tong** | *Discrete Differential Forms for Computational Modeling* | SIGGRAPH Course Notes 2006 | [dl.acm.org/doi/10.1145/1185657.1185665](https://dl.acm.org/doi/10.1145/1185657.1185665) | +| **Soliman, Slepčev, Crane** | *Optimal Cone Singularities for Conformal Flattening* | ACM TOG **37**(4), 2018 | [doi.org/10.1145/3197517.3201367](https://doi.org/10.1145/3197517.3201367) — Autorenseite: [cs.cmu.edu/~kmcrane](https://www.cs.cmu.edu/~kmcrane/Projects/OptimalCones/index.html) | +| **Gillespie, Springborn, Crane** | *Discrete Conformal Equivalence of Polyhedral Surfaces* | ACM TOG / SIGGRAPH 2021 | [doi.org/10.1145/3450626.3459763](https://doi.org/10.1145/3450626.3459763) — Autorenseite: [markjgillespie.com/Research/CEPS](https://markjgillespie.com/Research/CEPS/index.html) | +| **Sharp, Soliman, Crane** | *Navigating Intrinsic Triangulations* | ACM TOG / SIGGRAPH 2019 | [doi.org/10.1145/3306346.3323042](https://doi.org/10.1145/3306346.3323042) — Autorenseite: [cs.cmu.edu/~kmcrane](https://www.cs.cmu.edu/~kmcrane/Projects/NavigatingIntrinsicTriangulations/index.html) | +| **Alexa, Wardetzky** | *Discrete Laplacians on General Polygonal Meshes* | ACM SIGGRAPH 2011 | [doi.org/10.1145/1964921.1964997](https://doi.org/10.1145/1964921.1964997) | +| **Bunge, Herholz, Kazhdan, Botsch** | *Polygon Laplacian Made Simple* | CGF **39**(2), 2020 | [doi.org/10.1111/cgf.13931](https://doi.org/10.1111/cgf.13931) | +| **Rivin, Schlenker** | *The Schläfli formula in Einstein manifolds with boundary* | Electron. Res. Announc. AMS **5**, 1999 | [ams.org/era/1999-05-03](https://www.ams.org/era/1999-05-03) — wahrscheinlich frei | +| **Bobenko, Mercat, Schmies** | *Period Matrices of Polyhedral Surfaces* | Computational Approach to Riemann Surfaces, Springer 2011 | [doi.org/10.1007/978-3-642-17413-1](https://doi.org/10.1007/978-3-642-17413-1) — Buchkapitel | + +--- + +## Bücher (Bibliothek / Kauf) + +| Autor(en) | Titel | Verlag | +|---|---|---| +| **Farkas, Kra** | *Riemann Surfaces* (2. Aufl.) | Springer GTM 71 | +| **Siegel** | *Topics in Complex Function Theory, Vol. 2* | Wiley | + +--- + +## Hinweis: Autorenseiten oft freier als DOI + +Für die SIGGRAPH-Paper (Gillespie 2021, Sharp 2019, Soliman 2018) gibt es auf den +CMU/Autorenseiten oft direkte PDF-Downloads ohne Paywall. + +--- + +## Fehler in references.md (zu korrigieren) + +> **arXiv:math/0603097** ist in `references.md` fälschlicherweise **Kolpakov–Mednykh** +> zugewiesen. Tatsächlich ist das der **Springborn 2008** Artikel +> (*A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*). +> Das korrekte Kolpakov–Mednykh Paper hat vermutlich kein öffentliches arXiv-Preprint. +> → Springborn 2008 wurde korrekt als `springborn-2008-weighted-delaunay-hyperideal.pdf` +> gespeichert; references.md muss angepasst werden. -- 2.49.1 From 70b94b9ead4efe5aff7398cb2a5e1d7ca3af111a Mon Sep 17 00:00:00 2001 From: Tarik Moussa Date: Fri, 5 Jun 2026 07:12:12 +0200 Subject: [PATCH 4/6] fix(citations): correct Meyerhoff/Ushijima misattribution MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DOI 10.1007/0-387-29555-0_13 is Ushijima (sole author) — "A Volume Formula for Generalised Hyperbolic Tetrahedra", in: Prékopa & Molnár (eds.), Non-Euclidean Geometries, Springer 2006. arXiv: math/0309216. The references.md entry was wrong on all three counts: - Author: "Meyerhoff, Ushijima" → Ushijima only - Title: "A Note on the Dirichlet Domain" → entirely different title - Book: "The Epstein Birthday Schrift" → Non-Euclidean Geometries Same error pattern as the Kolpakov-Mednykh fix: the Java source links only to a DOI without naming authors; a wrong name was invented during the C++ port. Files corrected: hyper_ideal_utility.hpp, hyper_ideal_functional.hpp, references.md, tests.md, project-structure.md, finding-orchestration.md, math-derivation-citation-audit.md, MANUAL-DOWNLOAD.md Co-Authored-By: Claude Sonnet 4.6 --- code/include/hyper_ideal_functional.hpp | 2 +- code/include/hyper_ideal_utility.hpp | 3 ++- doc/api/tests.md | 2 +- doc/architecture/project-structure.md | 2 +- doc/math/references.md | 2 +- doc/reviewer/finding-orchestration.md | 2 +- doc/reviewer/math-derivation-citation-audit-2026-05-31.md | 4 ++-- papers/MANUAL-DOWNLOAD.md | 3 +-- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/code/include/hyper_ideal_functional.hpp b/code/include/hyper_ideal_functional.hpp index d558df9..dfae9b4 100644 --- a/code/include/hyper_ideal_functional.hpp +++ b/code/include/hyper_ideal_functional.hpp @@ -374,7 +374,7 @@ static FaceAngles compute_face_angles( /// Per-face energy contribution U(f) before subtracting the θ·a and Θ·b terms. /// /// Supported configurations (faithful port of HyperIdealFunctional.java): -/// * All three vertices hyper-ideal (v?b = true) → Meyerhoff/Ushijima volume +/// * All three vertices hyper-ideal (v?b = true) → Ushijima 2006 volume /// * Exactly one vertex ideal (v?b = false, other two true) → Springborn 2008 volume /// /// NOT supported — faces with two or three ideal vertices. The Java reference diff --git a/code/include/hyper_ideal_utility.hpp b/code/include/hyper_ideal_utility.hpp index 308fb5c..cf2aacd 100644 --- a/code/include/hyper_ideal_utility.hpp +++ b/code/include/hyper_ideal_utility.hpp @@ -16,7 +16,8 @@ namespace conformallab { /// Volume of a generalized hyperbolic tetrahedron with dihedral -/// angles `A,…,F` via the Meyerhoff / Ushijima 2006 formula. +/// angles `A,…,F` via the Ushijima 2006 formula (DOI 10.1007/0-387-29555-0_13, +/// arxiv math/0309216). Note: sole author is Ushijima; "Meyerhoff" is not an author. /// Same as Java `HyperIdealUtility.calculateTetrahedronVolume()`. inline double calculateTetrahedronVolume(double A, double B, double C, double D, double E, double F) { diff --git a/doc/api/tests.md b/doc/api/tests.md index c690816..b0b3103 100644 --- a/doc/api/tests.md +++ b/doc/api/tests.md @@ -7,7 +7,7 @@ Pure-math tests, only Eigen required. Covers Java utilities ported in Phase 1– | File | What it tests | |---|---| | `test_clausen.cpp` | Clausen Cl₂, Lobachevsky Л, ImLi₂ — values at known points | -| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Meyerhoff / Springborn 2008) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) | +| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Ushijima 2006 / Springborn 2008) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) | | `test_matrix_utility.cpp` | Matrix helpers | | `test_surface_curve_utility.cpp` | Surface curve utilities | | `test_discrete_elliptic_utility.cpp` | Discrete elliptic functions | diff --git a/doc/architecture/project-structure.md b/doc/architecture/project-structure.md index 6b7ba86..5d4c9a8 100644 --- a/doc/architecture/project-structure.md +++ b/doc/architecture/project-structure.md @@ -14,7 +14,7 @@ ConformalLabpp/ │ │ ├── constants.hpp # conformallab::PI, TWO_PI │ │ ├── clausen.hpp # Cl₂, Lobachevsky Л, ImLi₂ │ │ ├── hyper_ideal_geometry.hpp # ζ₁₃/₁₄/₁₅, lᵢⱼ, αᵢⱼ, σᵢ, σᵢⱼ -│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Meyerhoff / Springborn 2008) +│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Ushijima 2006 / Springborn 2008) │ │ ├── hyper_ideal_visualization_utility.hpp # Poincaré disk projection, circumcircle helpers │ │ ├── hyper_ideal_functional.hpp # HyperIdeal energy + gradient on ConformalMesh │ │ ├── hyper_ideal_hessian.hpp # HyperIdeal Hessian (symmetric FD, Phase 9b: analytic) diff --git a/doc/math/references.md b/doc/math/references.md index 6a77838..d87fe56 100644 --- a/doc/math/references.md +++ b/doc/math/references.md @@ -30,7 +30,7 @@ Java reference implementation: [github.com/varylab/conformallab](https://github. |---|---| | ✅ **Springborn** — *Ideal Hyperbolic Polyhedra and Discrete Uniformization*, Discrete & Computational Geometry **64** (2020), pp. 63–108. DOI: [10.1007/s00454-019-00132-8](https://doi.org/10.1007/s00454-019-00132-8) | `hyper_ideal_geometry.hpp` — ζ₁₃/ζ₁₄/ζ₁₅ functions; `hyper_ideal_functional.hpp` | | ✅ **Springborn** — *A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*, J. Differential Geometry **78**(2) (2008), pp. 333–367. arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian). ⚠️ *Korrektur:* war fälschlich als „Kolpakov–Mednykh 2006" zitiert — dieses Autorenpaar hat 2006 kein gemeinsames Paper veröffentlicht. Die Java-Quelle verlinkt korrekt auf math/0603097 (= Springborn 2008); der falsche Autorenname wurde beim C++-Port hinzugefügt.* | -| ✅ **Meyerhoff, Ushijima** — *A Note on the Dirichlet Domain*, in: The Epstein Birthday Schrift (2006) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp` | +| ✅ **Ushijima** — *A Volume Formula for Generalised Hyperbolic Tetrahedra*, in: Prékopa, Molnár (eds.) *Non-Euclidean Geometries*, Mathematics and Its Applications vol. 581, Springer 2006. DOI: [10.1007/0-387-29555-0_13](https://doi.org/10.1007/0-387-29555-0_13). arXiv: [math/0309216](https://arxiv.org/abs/math/0309216) (2003) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp`. ⚠️ *Korrektur:* war fälschlich als „Meyerhoff, Ushijima — A Note on the Dirichlet Domain — The Epstein Birthday Schrift" zitiert. Meyerhoff ist kein Autor; Titel und Buch waren beide falsch. Die Java-Quelle verlinkt korrekt auf DOI 10.1007/0-387-29555-0_13 ohne Autorennamen. | | **Pinkall, Polthier** — *Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics (1993) | `euclidean_hessian.hpp` — cotangent Laplacian | | **Bobenko, Springborn** — *Variational Principles for Circle Patterns and Koebe's Theorem*, Transactions AMS (2004) | Variational angle-sum framework underlying all three functionals | | **Luo** — *Combinatorial Yamabe Flow on Surfaces*, Communications in Contemporary Mathematics (2004) | Inversive-distance functional — **new research** in Phase 9a.2 (no Java original; implemented from this paper + Glickenstein 2011 + Bowers-Stephenson 2004) | diff --git a/doc/reviewer/finding-orchestration.md b/doc/reviewer/finding-orchestration.md index 0685154..754535f 100644 --- a/doc/reviewer/finding-orchestration.md +++ b/doc/reviewer/finding-orchestration.md @@ -198,7 +198,7 @@ Papiere verifiziert werden: | Priorität | Was prüfen | |---|---| | 🔴 Hoch | Formeln in Code-Kommentaren (`hyper_ideal_utility.hpp`, `hyper_ideal_functional.hpp`) gegen die zitierten Paper | -| 🔴 Hoch | Meyerhoff / Ushijima — Buchkapitel, nie direkt verifiziert | +| 🔴 Hoch | Ushijima 2006 (DOI 10.1007/0-387-29555-0_13) — arXiv math/0309216 — korrigiert: kein Meyerhoff, anderer Titel, anderes Buch | | 🟡 Mittel | Ob Springborn 2008 (math/0603097) die 12-Term-Lobachevsky-Formel tatsächlich enthält | | 🟡 Mittel | M3: post-2023 / arXiv-only Zitationen (Bowers-Bowers-Lutz 2026 etc.) | | 🔵 Niedrig | Alle weiteren `references.md`-Einträge auf Titel/Jahr/DOI-Konsistenz | diff --git a/doc/reviewer/math-derivation-citation-audit-2026-05-31.md b/doc/reviewer/math-derivation-citation-audit-2026-05-31.md index caa268a..81eda6c 100644 --- a/doc/reviewer/math-derivation-citation-audit-2026-05-31.md +++ b/doc/reviewer/math-derivation-citation-audit-2026-05-31.md @@ -68,8 +68,8 @@ load-bearing formula with no entry. ### Fix Add a `references.md` row: Kolpakov, Mednykh — *(full title)*, arXiv `math/0603097`, -mapped to `hyper_ideal_utility.hpp`. Likewise confirm the Meyerhoff / Ushijima 2006 -volume reference (cited in code) has a row. +mapped to `hyper_ideal_utility.hpp`. Ushijima 2006 (DOI 10.1007/0-387-29555-0_13, arXiv math/0309216) has a row — +sole author is Ushijima; "Meyerhoff" is not a co-author (corrected 2026-06-04). ### Acceptance criteria - Every formula cited inline in `code/include/` has a matching `references.md` entry. diff --git a/papers/MANUAL-DOWNLOAD.md b/papers/MANUAL-DOWNLOAD.md index 2d002ec..9869aa4 100644 --- a/papers/MANUAL-DOWNLOAD.md +++ b/papers/MANUAL-DOWNLOAD.md @@ -18,8 +18,7 @@ hinter Verlag-Paywall, oder Buchkapitel). | Autor(en) | Titel | Venue | DOI / Link | |---|---|---|---| -| **Kolpakov, Mednykh** (das korrekte Paper!) | *Orthoschemes and volumes of hyperbolic simplices* | Epstein Birthday Schrift, 2006 | Kein arXiv gefunden — bitte manuell suchen auf [Google Scholar](https://scholar.google.com/scholar?q=Kolpakov+Mednykh+volume+hyperbolic+tetrahedron+ideal+vertex) | -| **Meyerhoff, Ushijima** | *A Note on the Dirichlet Domain* | The Epstein Birthday Schrift (2006) | Buchkapitel — kein freier Link | +| **Ushijima** ⚠️ (Einzelautor — kein Meyerhoff!) | *A Volume Formula for Generalised Hyperbolic Tetrahedra* | Prékopa, Molnár (eds.) *Non-Euclidean Geometries*, Springer 2006 | [doi.org/10.1007/0-387-29555-0_13](https://doi.org/10.1007/0-387-29555-0_13) · arXiv [math/0309216](https://arxiv.org/abs/math/0309216) (arXiv gibt 500 für alte math/-Preprints — manuell laden) | | **Pinkall, Polthier** | *Computing Discrete Minimal Surfaces and Their Conjugates* | Experimental Mathematics **2**(1), 1993 | [projecteuclid.org/euclid.em/1062620735](https://projecteuclid.org/euclid.em/1062620735) | | **Bowers, Stephenson** | *Uniformizing dessins and Belyĭ maps via circle packing* | Memoirs AMS **170**(805), 2004 | [ams.org/books/memo/0805](https://bookstore.ams.org/memo-170-805) | | **Erickson, Whittlesey** | *Greedy Optimal Homotopy and Homology Generators* | SODA 2005 | [dl.acm.org/doi/10.5555/1070432.1070581](https://dl.acm.org/doi/10.5555/1070432.1070581) | -- 2.49.1 From b37a7b12a714a82f3a4a3a4334bc8f525aa2365e Mon Sep 17 00:00:00 2001 From: Tarik Moussa Date: Fri, 5 Jun 2026 07:21:47 +0200 Subject: [PATCH 5/6] =?UTF-8?q?fix(citations):=20systematic=20audit=20?= =?UTF-8?q?=E2=80=94=206=20corrections=20in=20references.md?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Findings from full citation audit of all 34 references.md entries: CRITICAL: - Knöppel et al. 2015 "Stripe Patterns": arXiv 1502.06686 was a completely different paper (Data-Driven Shape Analysis by Xu et al.) — removed from papers/. Correct DOI is 10.1145/2767000, not 10.1145/2766890. No arXiv preprint exists for this paper. ERRORS: - Born, Bücking, Springborn: published 2017 in DCG 57(2) pp. 305–317 (DOI 10.1007/s00454-016-9854-7); arXiv 2015 was preprint only - Bobenko, Mercat, Schmies: short title; full title is "Conformal Structures and Period Matrices of Polyhedral Surfaces"; editors Bobenko & Klein (not generic "Computational Approach" book ref); pp. 213–226, DOI 10.1007/978-3-642-17413-1_7 COMPLETIONS (missing vol/pages added): - Pinkall, Polthier 1993: vol. 2(1), pp. 15–36, DOI added - Bobenko, Springborn 2004: Trans. AMS 356(2), pp. 659–689, arXiv added - Luo 2004: Commun. Contemp. Math. 6(5), pp. 765–780, DOI + arXiv added Verified ✅ (no changes needed, 28/34 entries): Sechelmann 2016, Springborn 2020/2008, Ushijima 2006, Bowers-Stephenson 2004, Glickenstein 2011, BPS 2015, Schläfli 1858, Erickson-Whittlesey 2005, Bobenko-Springborn 2007, Desbrun-Kanso-Tong 2006, Soliman et al. 2018, all Bobenko-Lutz papers, Lutz 2023/2024, Bowers-Bowers-Lutz 2026, Alexa-Wardetzky 2011, Bunge et al. 2020, de Goes et al. 2020, Gillespie-Springborn-Crane 2021, Sharp-Soliman-Crane 2019, Farkas-Kra, Siegel, Bobenko-Bücking 2021, Rivin-Schlenker 1999, Pinkall-Springborn 2021, Sawhney-Crane 2017 Co-Authored-By: Claude Sonnet 4.6 --- doc/math/references.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/math/references.md b/doc/math/references.md index d87fe56..0a2e522 100644 --- a/doc/math/references.md +++ b/doc/math/references.md @@ -31,9 +31,9 @@ Java reference implementation: [github.com/varylab/conformallab](https://github. | ✅ **Springborn** — *Ideal Hyperbolic Polyhedra and Discrete Uniformization*, Discrete & Computational Geometry **64** (2020), pp. 63–108. DOI: [10.1007/s00454-019-00132-8](https://doi.org/10.1007/s00454-019-00132-8) | `hyper_ideal_geometry.hpp` — ζ₁₃/ζ₁₄/ζ₁₅ functions; `hyper_ideal_functional.hpp` | | ✅ **Springborn** — *A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*, J. Differential Geometry **78**(2) (2008), pp. 333–367. arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian). ⚠️ *Korrektur:* war fälschlich als „Kolpakov–Mednykh 2006" zitiert — dieses Autorenpaar hat 2006 kein gemeinsames Paper veröffentlicht. Die Java-Quelle verlinkt korrekt auf math/0603097 (= Springborn 2008); der falsche Autorenname wurde beim C++-Port hinzugefügt.* | | ✅ **Ushijima** — *A Volume Formula for Generalised Hyperbolic Tetrahedra*, in: Prékopa, Molnár (eds.) *Non-Euclidean Geometries*, Mathematics and Its Applications vol. 581, Springer 2006. DOI: [10.1007/0-387-29555-0_13](https://doi.org/10.1007/0-387-29555-0_13). arXiv: [math/0309216](https://arxiv.org/abs/math/0309216) (2003) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp`. ⚠️ *Korrektur:* war fälschlich als „Meyerhoff, Ushijima — A Note on the Dirichlet Domain — The Epstein Birthday Schrift" zitiert. Meyerhoff ist kein Autor; Titel und Buch waren beide falsch. Die Java-Quelle verlinkt korrekt auf DOI 10.1007/0-387-29555-0_13 ohne Autorennamen. | -| **Pinkall, Polthier** — *Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics (1993) | `euclidean_hessian.hpp` — cotangent Laplacian | -| **Bobenko, Springborn** — *Variational Principles for Circle Patterns and Koebe's Theorem*, Transactions AMS (2004) | Variational angle-sum framework underlying all three functionals | -| **Luo** — *Combinatorial Yamabe Flow on Surfaces*, Communications in Contemporary Mathematics (2004) | Inversive-distance functional — **new research** in Phase 9a.2 (no Java original; implemented from this paper + Glickenstein 2011 + Bowers-Stephenson 2004) | +| **Pinkall, Polthier** — *Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics **2**(1), pp. 15–36 (1993). DOI: [10.1080/10586458.1993.10504266](https://doi.org/10.1080/10586458.1993.10504266) | `euclidean_hessian.hpp` — cotangent Laplacian | +| **Bobenko, Springborn** — *Variational Principles for Circle Patterns and Koebe's Theorem*, Trans. Amer. Math. Soc. **356**(2), pp. 659–689 (2004). arXiv: [math/0203250](https://arxiv.org/abs/math/0203250) | Variational angle-sum framework underlying all three functionals | +| **Luo** — *Combinatorial Yamabe Flow on Surfaces*, Commun. Contemp. Math. **6**(5), pp. 765–780 (2004). DOI: [10.1142/S0219199704001501](https://doi.org/10.1142/S0219199704001501). arXiv: [math/0306167](https://arxiv.org/abs/math/0306167) | Inversive-distance functional — **new research** in Phase 9a.2 (no Java original; implemented from this paper + Glickenstein 2011 + Bowers-Stephenson 2004) | | **Bowers, Stephenson** — *Uniformizing dessins and Belyĭ maps via circle packing*, Memoirs of the AMS 170(805) (2004) | Introduces **inversive-distance circle packings** (used in Phase 9a.2). *Hinweis:* die zur Initialisierung benutzte Formel I_ij = (ℓ²−r_i²−r_j²)/(2 r_i r_j) ist die **klassische** inversive Distanz (vgl. Glickenstein §5.2: ℓ²=r_i²+r_j²+2r_ir_jη), nicht eine eigene „Bowers-Stephenson-Identität" — B–S liefern die Packungstheorie, nicht diese Formel. | | **Glickenstein** — *Discrete conformal variations and scalar curvature on piecewise flat two- and three-dimensional manifolds*, J. Differential Geometry **87**(2) (2011), pp. 201–238 | Analytic Hessian of the inversive-distance functional. ⚠️ *Korrektur:* die Arbeit nummeriert Gleichungen **nicht** im Format „(4.6)" — der Verweis ist durch die **§5.2**-Parametrisierung ℓ²_ij = r²_i + r²_j + 2 r_i r_j η_ij zu ersetzen. Cross-correspondence: η_ij ist die inversive Distanz und entspricht dem Kosinus des **Supplements** des Schnittwinkels (Schnitt bei arccos(−η_ij)) — also I_ij = cos θ_e **nur bis aufs Vorzeichen/Supplement**, nicht wörtlich. | | ✅ **Bobenko, Pinkall, Springborn** — *Discrete conformal maps and ideal hyperbolic polyhedra*, Geometry & Topology **19**(4) (2015), pp. 2155–2215. arXiv: [1005.2698](https://arxiv.org/abs/1005.2698) (first posted 2010) | Face-based circle-packing functional (`CPEuclideanFunctional.java` → `cp_euclidean_functional.hpp`, Phase 9a.1) | @@ -79,10 +79,10 @@ builds on this paper and augments it with Ptolemaic flips. |---|---| | **Farkas, Kra** — *Riemann Surfaces*, Springer GTM 71 | Siegel period matrix, Teichmüller theory | | **Siegel** — *Topics in Complex Function Theory, Vol. 2*, Wiley | Siegel upper half-space H_g, Sp(2g,ℤ) reduction | -| **Bobenko, Mercat, Schmies** — *Period Matrices of Polyhedral Surfaces*, in: Computational Approach to Riemann Surfaces (2011) | Discrete period matrices on polyhedral surfaces | +| **Bobenko, Mercat, Schmies** — *Conformal Structures and Period Matrices of Polyhedral Surfaces*, in: Bobenko, Klein (eds.) *Computational Approach to Riemann Surfaces*, Lecture Notes in Mathematics vol. 2013, Springer 2011, pp. 213–226. DOI: [10.1007/978-3-642-17413-1_7](https://doi.org/10.1007/978-3-642-17413-1_7) | Discrete period matrices on polyhedral surfaces | | **Bobenko, Bücking** — *Convergence of discrete period matrices and discrete holomorphic integrals for ramified coverings of the Riemann sphere*, Math. Phys. Anal. Geom. **24**, Art. 23 (2021). DOI: [10.1007/s11040-021-09394-2](https://doi.org/10.1007/s11040-021-09394-2) | Phase 10b: discrete Siegel period matrix Ωᵢⱼ from cotangent-weighted integration **plus** the convergence result Ω_discrete → Ω_smooth under refinement (für ramified coverings) — belegt die Diskret-zu-glatt-Aussage in `novelty-statement.md §3.3. | | **Rivin, Schlenker** — *The Schläfli formula in Einstein manifolds with boundary*, Electron. Res. Announc. AMS **5** (1999), pp. 18–23 | Phase 9b-analytic: modern form of the Schläfli identity `2 dV = Σ aₑ dαₑ` for manifolds with boundary — the bilinear form used to derive the analytic HyperIdeal Hessian. | | **Pinkall, Springborn** — *A discrete version of Liouville's theorem on conformal maps*, Geometriae Dedicata **214** (2021), pp. 389–398. arXiv: [1911.00966](https://arxiv.org/abs/1911.00966) | Phase 10b uniqueness: proves that the discrete conformal structure (and hence Ω) is a conformal invariant — the discrete Liouville theorem. Justifies that conformallab++ outputs a canonical representative. | -| **Born, Bücking, Springborn** — *Quasiconformal distortion of projective transformations and discrete conformal maps*, arXiv: [1505.01341](https://arxiv.org/abs/1505.01341) (2015) | Phase 10c error analysis: quantifies how well the discrete H²/Γ embedding approximates the smooth hyperbolic metric; error bounds for the Fuchsian group representation. | -| **Knöppel, Crane, Pinkall, Schröder** — *Stripe Patterns on Surfaces*, ACM SIGGRAPH (2015). DOI: [10.1145/2766890](https://doi.org/10.1145/2766890) | Phase 10a cross-validation: applies discrete holomorphic 1-forms to direction field design; geometry-central provides an independent C++ implementation to cross-check the Phase 10a `DiscreteHolomorphicFormUtility` port. | +| **Born, Bücking, Springborn** — *Quasiconformal distortion of projective transformations and discrete conformal maps*, Discrete & Computational Geometry **57**(2), pp. 305–317 (2017). DOI: [10.1007/s00454-016-9854-7](https://doi.org/10.1007/s00454-016-9854-7). arXiv: [1505.01341](https://arxiv.org/abs/1505.01341) (preprint 2015) | Phase 10c error analysis: quantifies how well the discrete H²/Γ embedding approximates the smooth hyperbolic metric; error bounds for the Fuchsian group representation. | +| **Knöppel, Crane, Pinkall, Schröder** — *Stripe Patterns on Surfaces*, ACM Transactions on Graphics **34**(4), Article 39 (SIGGRAPH 2015). DOI: [10.1145/2767000](https://doi.org/10.1145/2767000). ⚠️ *Kein arXiv-Preprint* (arXiv:1502.06686 ist ein anderes Paper — Data-Driven Shape Analysis — und wurde aus dem papers/-Ordner entfernt). | Phase 10a cross-validation: applies discrete holomorphic 1-forms to direction field design; geometry-central provides an independent C++ implementation to cross-check the Phase 10a `DiscreteHolomorphicFormUtility` port. | | **Sawhney, Crane** — *Boundary First Flattening*, ACM TOG **37**(1), Article 5 (2017). DOI: [10.1145/3132705](https://doi.org/10.1145/3132705) | Complementary method to Phase 9d: boundary-prescribed conformal flattening — user specifies boundary shape, interior conforms freely. Contrast: conformallab++ prescribes cone angles in the interior; BFF prescribes the boundary. Alternative approach for applications needing controlled boundary. | -- 2.49.1 From 3df6e7a5764535bc3c8fe02fa19a7fe8fdaec204 Mon Sep 17 00:00:00 2001 From: Tarik Moussa Date: Sun, 7 Jun 2026 11:46:02 +0200 Subject: [PATCH 6/6] chore(gitignore): exclude derived paper artifacts (txt/mmd/figures) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Extracted text (pdftext), nougat mmd output and figure dumps are regenerable from the source PDFs — keep them out of the repo like the PDFs themselves. Also excludes the accidental facebook/ nougat model cache (958 MB). Co-Authored-By: Claude Opus 4.8 --- .gitignore | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 7ecdc42..af431cd 100644 --- a/.gitignore +++ b/.gitignore @@ -34,5 +34,9 @@ Testing/ doc/doxygen/ *.dox.tmp -# Downloaded research papers (large PDFs, not tracked) +# Downloaded research papers + derived artifacts (regenerable, not tracked) papers/*.pdf +papers/txt/ +papers/mmd/ +papers/facebook/ +papers/figures/ -- 2.49.1