fix(citations): correct Kolpakov-Mednykh misattribution → Springborn 2008

arXiv:math/0603097 is Springborn 2008 ("A variational principle for weighted Delaunay triangulations and hyperideal polyhedra"), not a Kolpakov-Mednykh paper. The author pair Kolpakov & Mednykh has no joint publication from 2006; their earliest collaboration is arXiv:1008.0312 (2010, on torus knots, unrelated). The wrong author name was introduced during the Java→C++ port — the Java source correctly links to math/0603097 without naming the authors; whoever ported it invented "Kolpakov-Mednykh". The S1 citation audit (2026-05-31) then cemented the error by adding the incorrect row to references.md. Files corrected (7): - code/include/hyper_ideal_utility.hpp - code/include/hyper_ideal_functional.hpp - code/tests/cgal/test_hyper_ideal_functional.cpp - doc/math/references.md - doc/roadmap/research-track.md - doc/architecture/project-structure.md - doc/api/tests.md Also: - doc/reviewer/math-derivation-citation-audit-2026-05-31.md: M1 post-correction noted - doc/reviewer/finding-orchestration.md: lesson-learned section added (AI citation audits can introduce plausible-but-wrong attributions; human expert review required before CGAL submission) - papers/MANUAL-DOWNLOAD.md: overview of papers requiring manual download (paywalled journals, TU Berlin theses, books) - .gitignore: papers/*.pdf excluded (downloaded arXiv PDFs, not tracked) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-04 22:07:48 +02:00
parent 5d343776a3
commit 0f5ab27461
11 changed files with 122 additions and 13 deletions
--- a/.gitignore
+++ b/.gitignore
@@ -33,3 +33,6 @@ Testing/
 # Doxygen output
 doc/doxygen/
 *.dox.tmp
+
+# Downloaded research papers (large PDFs, not tracked)
+papers/*.pdf
--- a/code/include/hyper_ideal_functional.hpp
+++ b/code/include/hyper_ideal_functional.hpp
@@ -375,7 +375,7 @@ static FaceAngles compute_face_angles(
 ///
 /// Supported configurations (faithful port of HyperIdealFunctional.java):
 ///   * All three vertices hyper-ideal (v?b = true)       → Meyerhoff/Ushijima volume
-///   * Exactly one vertex ideal (v?b = false, other two true) → Kolpakov-Mednykh volume
+///   * Exactly one vertex ideal (v?b = false, other two true) → Springborn 2008 volume
 ///
 /// NOT supported — faces with two or three ideal vertices.  The Java reference
 /// (HyperIdealFunctional.java lines 222-231) uses an if/else-if chain that
--- a/code/include/hyper_ideal_utility.hpp
+++ b/code/include/hyper_ideal_utility.hpp
@@ -77,7 +77,7 @@ inline double calculateTetrahedronVolume(double A, double B, double C,
 }

 /// Volume of a hyperideal tetrahedron with one ideal vertex at γ via
-/// the Kolpakov-Mednykh formula (arxiv math/0603097).  Same as Java
+/// the Springborn 2008 formula (arxiv math/0603097).  Same as Java
 /// `HyperIdealUtility.calculateTetrahedronVolumeWithIdealVertexAtGamma()`.
 inline double calculateTetrahedronVolumeWithIdealVertexAtGamma(
    double gamma1, double gamma2, double gamma3,
--- a/code/tests/cgal/test_hyper_ideal_functional.cpp
+++ b/code/tests/cgal/test_hyper_ideal_functional.cpp
@@ -267,7 +267,7 @@ TEST(HyperIdealFunctional, MultiIdealGuard_AllThreeIdealVertices_Throws)
 TEST(HyperIdealFunctional, MultiIdealGuard_ExactlyOneIdeal_DoesNotThrow)
 {
    // Exactly one ideal vertex per face must NOT throw — it is the supported
-    // one-ideal-vertex configuration (Kolpakov-Mednykh formula).
+    // one-ideal-vertex configuration (Springborn 2008 formula).
    auto mesh = make_triangle();
    auto maps = setup_hyper_ideal_maps(mesh);

--- a/doc/api/tests.md
+++ b/doc/api/tests.md
@@ -7,7 +7,7 @@ Pure-math tests, only Eigen required. Covers Java utilities ported in Phase 1–
 | File | What it tests |
 |---|---|
 | `test_clausen.cpp` | Clausen Cl₂, Lobachevsky Л, ImLi₂ — values at known points |
-| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Meyerhoff / Kolpakov–Mednykh) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) |
+| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Meyerhoff / Springborn 2008) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) |
 | `test_matrix_utility.cpp` | Matrix helpers |
 | `test_surface_curve_utility.cpp` | Surface curve utilities |
 | `test_discrete_elliptic_utility.cpp` | Discrete elliptic functions |
--- a/doc/architecture/project-structure.md
+++ b/doc/architecture/project-structure.md
@@ -14,7 +14,7 @@ ConformalLabpp/
 │   │   ├── constants.hpp             # conformallab::PI, TWO_PI
 │   │   ├── clausen.hpp               # Cl₂, Lobachevsky Л, ImLi₂
 │   │   ├── hyper_ideal_geometry.hpp  # ζ₁₃/₁₄/₁₅, lᵢⱼ, αᵢⱼ, σᵢ, σᵢⱼ
-│   │   ├── hyper_ideal_utility.hpp   # Tetrahedron volumes (Meyerhoff / Kolpakov–Mednykh)
+│   │   ├── hyper_ideal_utility.hpp   # Tetrahedron volumes (Meyerhoff / Springborn 2008)
 │   │   ├── hyper_ideal_visualization_utility.hpp  # Poincaré disk projection, circumcircle helpers
 │   │   ├── hyper_ideal_functional.hpp # HyperIdeal energy + gradient on ConformalMesh
 │   │   ├── hyper_ideal_hessian.hpp   # HyperIdeal Hessian (symmetric FD, Phase 9b: analytic)
--- a/doc/math/references.md
+++ b/doc/math/references.md
@@ -29,7 +29,7 @@ Java reference implementation: [github.com/varylab/conformallab](https://github.
 | Reference | Used in |
 |---|---|
 | ✅ **Springborn** — *Ideal Hyperbolic Polyhedra and Discrete Uniformization*, Discrete & Computational Geometry **64** (2020), pp. 63–108. DOI: [10.1007/s00454-019-00132-8](https://doi.org/10.1007/s00454-019-00132-8) | `hyper_ideal_geometry.hpp` — ζ₁₃/ζ₁₄/ζ₁₅ functions; `hyper_ideal_functional.hpp` |
-| ✅ **Kolpakov, Mednykh** — *A Formula for the Volume of a Hyperbolic Tetrahedron*, arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) (2006) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian) |
+| ✅ **Springborn** — *A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*, J. Differential Geometry **78**(2) (2008), pp. 333–367. arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian). ⚠️ *Korrektur:* war fälschlich als „Kolpakov–Mednykh 2006" zitiert — dieses Autorenpaar hat 2006 kein gemeinsames Paper veröffentlicht. Die Java-Quelle verlinkt korrekt auf math/0603097 (= Springborn 2008); der falsche Autorenname wurde beim C++-Port hinzugefügt.* |
 | ✅ **Meyerhoff, Ushijima** — *A Note on the Dirichlet Domain*, in: The Epstein Birthday Schrift (2006) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp` |
 | **Pinkall, Polthier** — *Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics (1993) | `euclidean_hessian.hpp` — cotangent Laplacian |
 | **Bobenko, Springborn** — *Variational Principles for Circle Patterns and Koebe's Theorem*, Transactions AMS (2004) | Variational angle-sum framework underlying all three functionals |
--- a/doc/reviewer/finding-orchestration.md
+++ b/doc/reviewer/finding-orchestration.md
@@ -59,7 +59,7 @@ Status: ✅ done · ⬜ open (actionable) · ⏸ deferred (intentional) · ⛔ b
 | V3 | input-val | 🟡 | ✅ | Sonnet | S1 |
 | C1 | test-cov | 🔴 | ✅ | Sonnet | S1 |
 | N4, N6 | numerics | 🟡/🔵 | ✅ | Haiku | S1 |
-| M1, M2, M4 | math-cite | 🟡/🔵 | ✅ | Haiku | S1 |
+| M1, M2, M4 | math-cite | 🟡/🔵 | ✅⚠️ | Haiku → re-fix 2026-06-04 | S1 + nachkorrigiert |
 | C2, C3 | test-cov | 🔴 | ✅ | Sonnet | S1 |
 | V1, V2, V4 | input-val | 🟡 | ✅ | Sonnet | S1 |
 | I2, I3, I4 | test-cov | 🟡 | ✅ | Sonnet | S1 |
@@ -166,6 +166,42 @@ Gated by the author's reply on porting/relicensing rights.
 ### 👤 Out of model scope
 - **M5** — the large hand-derivations need a domain-expert prose review
  (the numerical results are already validated; the prose is not).
+- **Alle Zitationen** — alle `references.md`-Einträge müssen von einem
+  Fachexperten manuell verifiziert werden (siehe Lektion unten).
+
+---
+
+## ⚠️ Lektion: KI-gestützte Citation-Audits können Fehler einführen
+
+**Datum:** 2026-06-04  
+**Befund:** Die M1-Auflösung in S1 (Haiku, 2026-05-31) war selbst fehlerhaft:
+
+- Der Haiku-Audit erkannte korrekt, dass `Kolpakov–Mednykh` in `references.md` fehlt
+- Als „Fix" wurde die Zeile mit arXiv:math/0603097 ergänzt — aber **math/0603097 ist Springborn 2008**, nicht Kolpakov–Mednykh
+- Das Autorenpaar „Kolpakov & Mednykh" hat **2006 kein gemeinsames Paper veröffentlicht** (früheste Zusammenarbeit: 2010, über Torusknoten, nicht Tetraedervolumen)
+- Der falsche Autorenname entstand bereits beim Java→C++-Port; der Audit hat ihn zementiert statt korrigiert
+
+**Nachkorrektur:** 2026-06-04, 7 Dateien korrigiert (Code-Kommentare, references.md, roadmap, architecture-doc, tests-doc, audit-doc).
+
+**Konsequenz für das Projekt:**
+
+> KI-Modelle können bei Citation-Audits plausibel klingende aber falsche  
+> Autoren/Jahres-Zuordnungen produzieren — besonders wenn die Primärquelle  
+> (Java-Code) nur einen Link ohne Autorennamen enthält.
+
+**Empfehlung:**
+
+Vor jeder öffentlichen Veröffentlichung / CGAL-Submission müssen **alle** Einträge
+in `references.md` von einem **Fachexperten (Mensch)** gegen die tatsächlichen
+Papiere verifiziert werden:
+
+| Priorität | Was prüfen |
+|---|---|
+| 🔴 Hoch | Formeln in Code-Kommentaren (`hyper_ideal_utility.hpp`, `hyper_ideal_functional.hpp`) gegen die zitierten Paper |
+| 🔴 Hoch | Meyerhoff / Ushijima — Buchkapitel, nie direkt verifiziert |
+| 🟡 Mittel | Ob Springborn 2008 (math/0603097) die 12-Term-Lobachevsky-Formel tatsächlich enthält |
+| 🟡 Mittel | M3: post-2023 / arXiv-only Zitationen (Bowers-Bowers-Lutz 2026 etc.) |
+| 🔵 Niedrig | Alle weiteren `references.md`-Einträge auf Titel/Jahr/DOI-Konsistenz |

 ---

--- a/doc/reviewer/math-derivation-citation-audit-2026-05-31.md
+++ b/doc/reviewer/math-derivation-citation-audit-2026-05-31.md
@@ -16,6 +16,16 @@ Status legend: 🔴 Critical · 🟡 Important · 🔵 Polish
 > future-dated/arXiv citations) **open** → S4; **M5** (prose derivation review)
 > needs a **domain expert** (out of model scope). See
 > [`finding-orchestration.md`](finding-orchestration.md).
+>
+> **⚠️ M1 Nachkorrektur (2026-06-04):** Die ursprüngliche M1-Auflösung war selbst
+> fehlerhaft — arXiv:math/0603097 ist **Springborn 2008** (*A variational principle
+> for weighted Delaunay triangulations and hyperideal polyhedra*), nicht
+> Kolpakov–Mednykh. Kolpakov und Mednykh haben 2006 kein gemeinsames Paper
+> veröffentlicht (früheste Zusammenarbeit: 2010). Der falsche Autorenname wurde beim
+> Java→C++-Port erfunden; die Java-Quelle verlinkt korrekt auf math/0603097 ohne
+> Autorennamen. Korrekturen angewendet in: `hyper_ideal_utility.hpp`,
+> `hyper_ideal_functional.hpp`, `test_hyper_ideal_functional.cpp`,
+> `doc/math/references.md`.

 > **Good news up front:** `doc/math/references.md` is unusually scholarly and already
 > contains several *self-corrections* (the Glickenstein "eq. (4.6)" numbering fix →
--- a/doc/roadmap/research-track.md
+++ b/doc/roadmap/research-track.md
@@ -145,10 +145,10 @@ The phase numbers match `doc/roadmap/phases.md`.
 ### Hyper-ideal volume formulas for 2- and 3-ideal-vertex faces (Phase 9b+, 🔲 planned)

 * **Mathematical sources:**
-  - **Kolpakov, A. & Mednykh, A.** (2012). *Spherical structures on torus
-    knots and links.* Sibirsk. Mat. Zh. 53(3), 535–541 — see the earlier
-    arXiv:math/0603097 for the one-ideal-vertex formula already implemented
-    as `calculateTetrahedronVolumeWithIdealVertexAtGamma`.
+  - **Springborn, B.** (2008). *A variational principle for weighted Delaunay
+    triangulations and hyperideal polyhedra.* J. Differential Geometry **78**(2),
+    333–367. arXiv:math/0603097 — the source of the one-ideal-vertex formula
+    already implemented as `calculateTetrahedronVolumeWithIdealVertexAtGamma`.
  - **Milnor, J.** (1982). *Hyperbolic geometry: The first 150 years.*
    Bull. Amer. Math. Soc. 6(1), 9–24.  → Volume of an ideal tetrahedron
    via Clausen function; this is the all-ideal case with 4 ideal vertices.
@@ -175,10 +175,10 @@ The phase numbers match `doc/roadmap/phases.md`.

 * **Acceptance criteria:**
  - Identify the correct formula for a hyper-ideal tetrahedron with exactly
-    2 ideal vertices from the literature (check Kolpakov-Mednykh generalisations
+    2 ideal vertices from the literature (check Springborn 2008 §3–4 generalisations
    and Vinberg orthoscheme decomposition).
  - Implement `calculateTetrahedronVolumeWithTwoIdealVertices(…)` analogous
-    to the existing Kolpakov-Mednykh function.
+    to the existing Springborn 2008 one-ideal-vertex function.
  - Implement `calculateTetrahedronVolumeWithThreeIdealVertices(…)` (one
    hyper-ideal + three ideal = fully cusp-like case).
  - Replace the `throw std::logic_error` in `face_energy()` with the correct
--- a/papers/MANUAL-DOWNLOAD.md
+++ b/papers/MANUAL-DOWNLOAD.md
@@ -0,0 +1,60 @@
+# Manuell herunterzuladende Paper & Dissertationen
+
+Diese Paper konnten nicht automatisch geladen werden (kein freies arXiv-Preprint,
+hinter Verlag-Paywall, oder Buchkapitel).
+
+---
+
+## Dissertationen (Open Access — TU Berlin Depositonce)
+
+| Autor | Titel | Link |
+|---|---|---|
+| **Sechelmann 2016** | *Variational Methods for Discrete Surface Parameterization: Applications and Implementation* | [depositonce.tu-berlin.de/items/8e2988b2-d991-45b5-aad5-9fb7988f3b2f](https://depositonce.tu-berlin.de/items/8e2988b2-d991-45b5-aad5-9fb7988f3b2f) — CC BY-SA 4.0 |
+| **Lutz 2024** | *Decorated Discrete Conformal Equivalence, Canonical Tessellations, and Polyhedral Realization* | [doi.org/10.14279/depositonce-20357](https://doi.org/10.14279/depositonce-20357) — Open Access |
+
+---
+
+## Paper hinter Verlag-Paywall (ggf. über Institutional Access / Google Scholar)
+
+| Autor(en) | Titel | Venue | DOI / Link |
+|---|---|---|---|
+| **Kolpakov, Mednykh** (das korrekte Paper!) | *Orthoschemes and volumes of hyperbolic simplices* | Epstein Birthday Schrift, 2006 | Kein arXiv gefunden — bitte manuell suchen auf [Google Scholar](https://scholar.google.com/scholar?q=Kolpakov+Mednykh+volume+hyperbolic+tetrahedron+ideal+vertex) |
+| **Meyerhoff, Ushijima** | *A Note on the Dirichlet Domain* | The Epstein Birthday Schrift (2006) | Buchkapitel — kein freier Link |
+| **Pinkall, Polthier** | *Computing Discrete Minimal Surfaces and Their Conjugates* | Experimental Mathematics **2**(1), 1993 | [projecteuclid.org/euclid.em/1062620735](https://projecteuclid.org/euclid.em/1062620735) |
+| **Bowers, Stephenson** | *Uniformizing dessins and Belyĭ maps via circle packing* | Memoirs AMS **170**(805), 2004 | [ams.org/books/memo/0805](https://bookstore.ams.org/memo-170-805) |
+| **Erickson, Whittlesey** | *Greedy Optimal Homotopy and Homology Generators* | SODA 2005 | [dl.acm.org/doi/10.5555/1070432.1070581](https://dl.acm.org/doi/10.5555/1070432.1070581) |
+| **Desbrun, Kanso, Tong** | *Discrete Differential Forms for Computational Modeling* | SIGGRAPH Course Notes 2006 | [dl.acm.org/doi/10.1145/1185657.1185665](https://dl.acm.org/doi/10.1145/1185657.1185665) |
+| **Soliman, Slepčev, Crane** | *Optimal Cone Singularities for Conformal Flattening* | ACM TOG **37**(4), 2018 | [doi.org/10.1145/3197517.3201367](https://doi.org/10.1145/3197517.3201367) — Autorenseite: [cs.cmu.edu/~kmcrane](https://www.cs.cmu.edu/~kmcrane/Projects/OptimalCones/index.html) |
+| **Gillespie, Springborn, Crane** | *Discrete Conformal Equivalence of Polyhedral Surfaces* | ACM TOG / SIGGRAPH 2021 | [doi.org/10.1145/3450626.3459763](https://doi.org/10.1145/3450626.3459763) — Autorenseite: [markjgillespie.com/Research/CEPS](https://markjgillespie.com/Research/CEPS/index.html) |
+| **Sharp, Soliman, Crane** | *Navigating Intrinsic Triangulations* | ACM TOG / SIGGRAPH 2019 | [doi.org/10.1145/3306346.3323042](https://doi.org/10.1145/3306346.3323042) — Autorenseite: [cs.cmu.edu/~kmcrane](https://www.cs.cmu.edu/~kmcrane/Projects/NavigatingIntrinsicTriangulations/index.html) |
+| **Alexa, Wardetzky** | *Discrete Laplacians on General Polygonal Meshes* | ACM SIGGRAPH 2011 | [doi.org/10.1145/1964921.1964997](https://doi.org/10.1145/1964921.1964997) |
+| **Bunge, Herholz, Kazhdan, Botsch** | *Polygon Laplacian Made Simple* | CGF **39**(2), 2020 | [doi.org/10.1111/cgf.13931](https://doi.org/10.1111/cgf.13931) |
+| **Rivin, Schlenker** | *The Schläfli formula in Einstein manifolds with boundary* | Electron. Res. Announc. AMS **5**, 1999 | [ams.org/era/1999-05-03](https://www.ams.org/era/1999-05-03) — wahrscheinlich frei |
+| **Bobenko, Mercat, Schmies** | *Period Matrices of Polyhedral Surfaces* | Computational Approach to Riemann Surfaces, Springer 2011 | [doi.org/10.1007/978-3-642-17413-1](https://doi.org/10.1007/978-3-642-17413-1) — Buchkapitel |
+
+---
+
+## Bücher (Bibliothek / Kauf)
+
+| Autor(en) | Titel | Verlag |
+|---|---|---|
+| **Farkas, Kra** | *Riemann Surfaces* (2. Aufl.) | Springer GTM 71 |
+| **Siegel** | *Topics in Complex Function Theory, Vol. 2* | Wiley |
+
+---
+
+## Hinweis: Autorenseiten oft freier als DOI
+
+Für die SIGGRAPH-Paper (Gillespie 2021, Sharp 2019, Soliman 2018) gibt es auf den
+CMU/Autorenseiten oft direkte PDF-Downloads ohne Paywall.
+
+---
+
+## Fehler in references.md (zu korrigieren)
+
+> **arXiv:math/0603097** ist in `references.md` fälschlicherweise **Kolpakov–Mednykh**
+> zugewiesen. Tatsächlich ist das der **Springborn 2008** Artikel
+> (*A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*).
+> Das korrekte Kolpakov–Mednykh Paper hat vermutlich kein öffentliches arXiv-Preprint.
+> → Springborn 2008 wurde korrekt als `springborn-2008-weighted-delaunay-hyperideal.pdf`
+> gespeichert; references.md muss angepasst werden.