conformallab/ConformalLabpp
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(citations): correct Meyerhoff/Ushijima misattribution

Browse Source 
DOI 10.1007/0-387-29555-0_13 is Ushijima (sole author) —
"A Volume Formula for Generalised Hyperbolic Tetrahedra",
in: Prékopa & Molnár (eds.), Non-Euclidean Geometries,
Springer 2006. arXiv: math/0309216.

The references.md entry was wrong on all three counts:
  - Author:  "Meyerhoff, Ushijima" → Ushijima only
  - Title:   "A Note on the Dirichlet Domain" → entirely different title
  - Book:    "The Epstein Birthday Schrift" → Non-Euclidean Geometries

Same error pattern as the Kolpakov-Mednykh fix: the Java source
links only to a DOI without naming authors; a wrong name was
invented during the C++ port.

Files corrected: hyper_ideal_utility.hpp, hyper_ideal_functional.hpp,
references.md, tests.md, project-structure.md, finding-orchestration.md,
math-derivation-citation-audit.md, MANUAL-DOWNLOAD.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Tarik Moussa
2026-06-05 07:12:12 +02:00
committed by user2595
parent 0f5ab27461
commit 1063f3541f
8 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
code/include/hyper_ideal_functional.hpp
View File

@@ -374,7 +374,7 @@ static FaceAngles compute_face_angles(
/// Per-face energy contribution U(f) before subtracting the θ·a and Θ·b terms.
///
/// Supported configurations (faithful port of HyperIdealFunctional.java):
/// * All three vertices hyper-ideal (v?b = true) → Meyerhoff/Ushijima volume
/// * All three vertices hyper-ideal (v?b = true) → Ushijima 2006 volume
/// * Exactly one vertex ideal (v?b = false, other two true) → Springborn 2008 volume
///
/// NOT supported — faces with two or three ideal vertices. The Java reference

3
code/include/hyper_ideal_utility.hpp
View File

@@ -16,7 +16,8 @@
namespace conformallab {
/// Volume of a generalized hyperbolic tetrahedron with dihedral
/// angles `A,…,F` via the Meyerhoff / Ushijima 2006 formula.
/// angles `A,…,F` via the Ushijima 2006 formula (DOI 10.1007/0-387-29555-0_13,
/// arxiv math/0309216). Note: sole author is Ushijima; "Meyerhoff" is not an author.
/// Same as Java `HyperIdealUtility.calculateTetrahedronVolume()`.
inline double calculateTetrahedronVolume(double A, double B, double C,
double D, double E, double F) {

2
doc/api/tests.md
View File

@@ -7,7 +7,7 @@ Pure-math tests, only Eigen required. Covers Java utilities ported in Phase 1–
| File | What it tests |
|---|---|
| `test_clausen.cpp` | Clausen Cl₂, Lobachevsky Л, ImLi₂ — values at known points |
| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Meyerhoff / Springborn 2008) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) |
| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Ushijima 2006 / Springborn 2008) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) |
| `test_matrix_utility.cpp` | Matrix helpers |
| `test_surface_curve_utility.cpp` | Surface curve utilities |
| `test_discrete_elliptic_utility.cpp` | Discrete elliptic functions |

2
doc/architecture/project-structure.md
View File

@@ -14,7 +14,7 @@ ConformalLabpp/
│ │ ├── constants.hpp # conformallab::PI, TWO_PI
│ │ ├── clausen.hpp # Cl₂, Lobachevsky Л, ImLi₂
│ │ ├── hyper_ideal_geometry.hpp # ζ₁₃/₁₄/₁₅, lᵢⱼ, αᵢⱼ, σᵢ, σᵢⱼ
│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Meyerhoff / Springborn 2008)
│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Ushijima 2006 / Springborn 2008)
│ │ ├── hyper_ideal_visualization_utility.hpp # Poincaré disk projection, circumcircle helpers
│ │ ├── hyper_ideal_functional.hpp # HyperIdeal energy + gradient on ConformalMesh
│ │ ├── hyper_ideal_hessian.hpp # HyperIdeal Hessian (symmetric FD, Phase 9b: analytic)

2
doc/math/references.md
View File

@@ -30,7 +30,7 @@ Java reference implementation: [github.com/varylab/conformallab](https://github.
|---|---|
| ✅ **Springborn** — *Ideal Hyperbolic Polyhedra and Discrete Uniformization*, Discrete & Computational Geometry **64** (2020), pp. 63–108. DOI: [10.1007/s00454-019-00132-8](https://doi.org/10.1007/s00454-019-00132-8) | `hyper_ideal_geometry.hpp` — ζ₁₃/ζ₁₄/ζ₁₅ functions; `hyper_ideal_functional.hpp` |
| ✅ **Springborn** — *A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*, J. Differential Geometry **78**(2) (2008), pp. 333–367. arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian). ⚠️ *Korrektur:* war fälschlich als „Kolpakov–Mednykh 2006" zitiert — dieses Autorenpaar hat 2006 kein gemeinsames Paper veröffentlicht. Die Java-Quelle verlinkt korrekt auf math/0603097 (= Springborn 2008); der falsche Autorenname wurde beim C++-Port hinzugefügt.* |
| ✅ **Meyerhoff, Ushijima** — *A Note on the Dirichlet Domain*, in: The Epstein Birthday Schrift (2006) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp` |
| ✅ **Ushijima** — *A Volume Formula for Generalised Hyperbolic Tetrahedra*, in: Prékopa, Molnár (eds.) *Non-Euclidean Geometries*, Mathematics and Its Applications vol. 581, Springer 2006. DOI: [10.1007/0-387-29555-0_13](https://doi.org/10.1007/0-387-29555-0_13). arXiv: [math/0309216](https://arxiv.org/abs/math/0309216) (2003) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp`. ⚠️ *Korrektur:* war fälschlich als „Meyerhoff, Ushijima — A Note on the Dirichlet Domain — The Epstein Birthday Schrift" zitiert. Meyerhoff ist kein Autor; Titel und Buch waren beide falsch. Die Java-Quelle verlinkt korrekt auf DOI 10.1007/0-387-29555-0_13 ohne Autorennamen. |
| **Pinkall, Polthier** — *Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics (1993) | `euclidean_hessian.hpp` — cotangent Laplacian |
| **Bobenko, Springborn** — *Variational Principles for Circle Patterns and Koebe's Theorem*, Transactions AMS (2004) | Variational angle-sum framework underlying all three functionals |
| **Luo** — *Combinatorial Yamabe Flow on Surfaces*, Communications in Contemporary Mathematics (2004) | Inversive-distance functional — **new research** in Phase 9a.2 (no Java original; implemented from this paper + Glickenstein 2011 + Bowers-Stephenson 2004) |

2
doc/reviewer/finding-orchestration.md
View File

@@ -198,7 +198,7 @@ Papiere verifiziert werden:
| Priorität | Was prüfen |
|---|---|
| 🔴 Hoch | Formeln in Code-Kommentaren (`hyper_ideal_utility.hpp`, `hyper_ideal_functional.hpp`) gegen die zitierten Paper |
| 🔴 Hoch | Meyerhoff / Ushijima — Buchkapitel, nie direkt verifiziert |
| 🔴 Hoch | Ushijima 2006 (DOI 10.1007/0-387-29555-0_13) — arXiv math/0309216 — korrigiert: kein Meyerhoff, anderer Titel, anderes Buch |
| 🟡 Mittel | Ob Springborn 2008 (math/0603097) die 12-Term-Lobachevsky-Formel tatsächlich enthält |
| 🟡 Mittel | M3: post-2023 / arXiv-only Zitationen (Bowers-Bowers-Lutz 2026 etc.) |
| 🔵 Niedrig | Alle weiteren `references.md`-Einträge auf Titel/Jahr/DOI-Konsistenz |

4
doc/reviewer/math-derivation-citation-audit-2026-05-31.md
View File

@@ -68,8 +68,8 @@ load-bearing formula with no entry.
### Fix
Add a `references.md` row: Kolpakov, Mednykh — *(full title)*, arXiv `math/0603097`,
mapped to `hyper_ideal_utility.hpp`. Likewise confirm the Meyerhoff / Ushijima 2006
volume reference (cited in code) has a row.
mapped to `hyper_ideal_utility.hpp`. Ushijima 2006 (DOI 10.1007/0-387-29555-0_13, arXiv math/0309216) has a row —
sole author is Ushijima; "Meyerhoff" is not a co-author (corrected 2026-06-04).
### Acceptance criteria
- Every formula cited inline in `code/include/` has a matching `references.md` entry.

3
papers/MANUAL-DOWNLOAD.md
View File

@@ -18,8 +18,7 @@ hinter Verlag-Paywall, oder Buchkapitel).
| Autor(en) | Titel | Venue | DOI / Link |
|---|---|---|---|
| **Kolpakov, Mednykh** (das korrekte Paper!) | *Orthoschemes and volumes of hyperbolic simplices* | Epstein Birthday Schrift, 2006 | Kein arXiv gefunden — bitte manuell suchen auf [Google Scholar](https://scholar.google.com/scholar?q=Kolpakov+Mednykh+volume+hyperbolic+tetrahedron+ideal+vertex) |
| **Meyerhoff, Ushijima** | *A Note on the Dirichlet Domain* | The Epstein Birthday Schrift (2006) | Buchkapitel — kein freier Link |
| **Ushijima** ⚠️ (Einzelautor — kein Meyerhoff!) | *A Volume Formula for Generalised Hyperbolic Tetrahedra* | Prékopa, Molnár (eds.) *Non-Euclidean Geometries*, Springer 2006 | [doi.org/10.1007/0-387-29555-0_13](https://doi.org/10.1007/0-387-29555-0_13) · arXiv [math/0309216](https://arxiv.org/abs/math/0309216) (arXiv gibt 500 für alte math/-Preprints — manuell laden) |
| **Pinkall, Polthier** | *Computing Discrete Minimal Surfaces and Their Conjugates* | Experimental Mathematics **2**(1), 1993 | [projecteuclid.org/euclid.em/1062620735](https://projecteuclid.org/euclid.em/1062620735) |
| **Bowers, Stephenson** | *Uniformizing dessins and Belyĭ maps via circle packing* | Memoirs AMS **170**(805), 2004 | [ams.org/books/memo/0805](https://bookstore.ams.org/memo-170-805) |
| **Erickson, Whittlesey** | *Greedy Optimal Homotopy and Homology Generators* | SODA 2005 | [dl.acm.org/doi/10.5555/1070432.1070581](https://dl.acm.org/doi/10.5555/1070432.1070581) |