conformallab/ConformalLabpp
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

refactor(api): consistent naming for spherical + hyper-ideal helpers (A1–A3)
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 2m20s
Details
C++ Tests / quality-gates (pull_request) Has been skipped
Details
C++ Tests / test-cgal (pull_request) Has been skipped
Details

Browse Source 
Standardize the low-level free-function API on <verb>_<geom>_<rest>,
matching the already-consistent setup_<geom>_maps. Old names kept as
[[deprecated]] inline aliases for one release; all internal call sites
migrated.

Renames:
  assign_vertex_dof_indices      -> assign_spherical_vertex_dof_indices
  assign_all_spherical_dof_indices -> assign_spherical_all_dof_indices
  assign_all_dof_indices         -> assign_hyper_ideal_all_dof_indices
  compute_lambda0_from_mesh      -> compute_spherical_lambda0_from_mesh
  gradient_check                 -> gradient_check_hyper_ideal

A4/A5 (public CGAL API) intentionally deferred pending the license/
provenance decision (see CGAL submission audit G0/G1).

Verified: 277/277 CGAL tests pass, no deprecation warnings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tarik Moussa
2026-05-31 09:15:22 +02:00
parent e13e7ea8e7
commit 65fc8ac816
16 changed files with 127 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
code/tests/cgal/test_hyper_ideal_hessian.cpp
View File

@@ -79,7 +79,7 @@ TEST(HyperIdealHessian, PureHelperMatchesMeshHelper)
{
auto mesh = make_tetrahedron();
auto m = setup_hyper_ideal_maps(mesh);
const int n = assign_all_dof_indices(mesh, m);
const int n = assign_hyper_ideal_all_dof_indices(mesh, m);
auto x = natural_x(mesh, m);
for (auto f : mesh.faces()) {
@@ -119,7 +119,7 @@ TEST(HyperIdealHessian, BlockFD_MatchesFullFD_ClosedTetrahedron)
{
auto mesh = make_tetrahedron();
auto m = setup_hyper_ideal_maps(mesh);
const int n = assign_all_dof_indices(mesh, m);
const int n = assign_hyper_ideal_all_dof_indices(mesh, m);
auto x = natural_x(mesh, m);
auto H_full = hyper_ideal_hessian_sym (mesh, x, m);
@@ -141,7 +141,7 @@ TEST(HyperIdealHessian, BlockFD_MatchesFullFD_Open3FaceMesh)
{
auto mesh = make_open_3face_mesh();
auto m = setup_hyper_ideal_maps(mesh);
const int n = assign_all_dof_indices(mesh, m);
const int n = assign_hyper_ideal_all_dof_indices(mesh, m);
auto x = natural_x(mesh, m);
auto H_full = hyper_ideal_hessian_sym (mesh, x, m);
@@ -196,7 +196,7 @@ TEST(HyperIdealHessian, BlockFD_IsPSD)
{
auto mesh = make_tetrahedron();
auto m = setup_hyper_ideal_maps(mesh);
const int n = assign_all_dof_indices(mesh, m);
const int n = assign_hyper_ideal_all_dof_indices(mesh, m);
auto x = natural_x(mesh, m);
auto H = hyper_ideal_hessian_block_fd_sym(mesh, x, m);
@@ -226,7 +226,7 @@ TEST(HyperIdealHessian, BlockFD_SparsityMatchesFaceAdjacency)
{
auto mesh = make_open_3face_mesh();
auto m = setup_hyper_ideal_maps(mesh);
const int n = assign_all_dof_indices(mesh, m);
const int n = assign_hyper_ideal_all_dof_indices(mesh, m);
auto x = natural_x(mesh, m);
auto H = hyper_ideal_hessian_block_fd(mesh, x, m);
@@ -307,7 +307,7 @@ TEST(HyperIdealHessian, BlockFD_FasterThanFullFD)
// Theoretical ratio: ~42×. We assert ≥ 3× to leave wide CI tolerance.
auto mesh = make_tet_strip(100);
auto m = setup_hyper_ideal_maps(mesh);
const int n = assign_all_dof_indices(mesh, m);
const int n = assign_hyper_ideal_all_dof_indices(mesh, m);
auto x = natural_x(mesh, m);
using clk = std::chrono::steady_clock;