Merge pull request 'ci+quality: structural gates (CI: 3 new; local: 7 new + .clang-tidy)' (#18) from ci/structural-tests into main

code/CMakeLists.txt

@@ -55,8 +55,26 @@ if(NOT CMAKE_BUILD_TYPE)
 endif()
 
 if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
+  # ─── Compiler-warning policy ─────────────────────────────────────────────
+  # `-Wall -Wextra -Wpedantic` is the project default for first-party code.
+  # Vendored deps under code/deps/ get a separate, looser policy (handled
+  # via per-target SYSTEM include marking when they are pulled in).
+  #
+  # `CONFORMALLAB_WARNINGS_AS_ERRORS=ON` flips on `-Werror` — used in CI's
+  # promotion-track and by `scripts/quality/sanitizers.sh` to make sure no
+  # new warning class slips in unannounced.  Off by default so regular
+  # builds on slightly older toolchains aren't broken by a new GCC's
+  # added warning.
+  option(CONFORMALLAB_WARNINGS_AS_ERRORS
+    "Treat compiler warnings as errors (-Werror)." OFF)
+
   add_compile_options(-Wall -Wextra -Wpedantic)
 
+  if(CONFORMALLAB_WARNINGS_AS_ERRORS)
+    add_compile_options(-Werror)
+    message(STATUS "Warnings-as-errors mode active (-Werror).")
+  endif()
+
   # AddressSanitizer only in Debug (gtest_discover_tests runs the binary at
   # configure time and hangs with ASan enabled).
   if(CMAKE_BUILD_TYPE STREQUAL "Debug" AND NOT BUILD_TESTING)

code/include/clausen.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 
 // Clausen integral, Lobachevsky function, and Im(Li2).
 // Ported from de.varylab.discreteconformal.functional.Clausen (Java).

code/include/conformal_mesh.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // conformal_mesh.hpp
 //
 // Central mesh type for the discrete conformal mapping algorithms.

code/include/constants.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // constants.hpp
 //
 // Single source of truth for mathematical constants used throughout

code/include/cp_euclidean_functional.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // cp_euclidean_functional.hpp
 //
 // Phase 9a.1 — Circle-Packing Euclidean functional (CP-Euclidean).

code/include/cut_graph.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // cut_graph.hpp
 //
 // Phase 6 — Tree-cotree algorithm for computing a cut graph of a triangulated

code/include/discrete_elliptic_utility.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 
 // Ported from de.varylab.discreteconformal.util.DiscreteEllipticUtility (Java).
 // Only the pure-math subset (no HDS required).

code/include/euclidean_functional.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // euclidean_functional.hpp
 //
 // Energy and gradient of the Euclidean discrete conformal functional

code/include/euclidean_geometry.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // euclidean_geometry.hpp
 //
 // Corner-angle formula for Euclidean triangles in the discrete conformal

code/include/euclidean_hessian.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // euclidean_hessian.hpp
 //
 // Analytical Hessian of the Euclidean discrete conformal energy —

code/include/fundamental_domain.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // fundamental_domain.hpp
 //
 // Phase 7 — Fundamental domain polygon for closed surfaces.

code/include/gauss_bonnet.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // gauss_bonnet.hpp
 //
 // Phase 6 — Gauss–Bonnet consistency check for prescribed target angles.

code/include/hyper_ideal_functional.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // hyper_ideal_functional.hpp
 //
 // Energy and gradient of the hyper-ideal discrete conformal map functional

code/include/hyper_ideal_geometry.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // hyper_ideal_geometry.hpp
 //
 // Pure-math building blocks for the hyper-ideal discrete conformal map.

code/include/hyper_ideal_hessian.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // hyper_ideal_hessian.hpp
 //
 // Phase 4a — Hessian of the hyper-ideal discrete conformal functional.

code/include/hyper_ideal_utility.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 
 // Hyperbolic tetrahedron volume formulas.
 // Ported from de.varylab.discreteconformal.functional.HyperIdealUtility (Java).

code/include/hyper_ideal_visualization_utility.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // Port of the static helper
 //   HyperIdealVisualizationPlugin.getEuclideanCircleFromHyperbolic()
 // from de.varylab.discreteconformal.plugin.

code/include/inversive_distance_functional.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // inversive_distance_functional.hpp
 //
 // Phase 9a.2 — Inversive-distance circle-packing functional (Luo 2004).

code/include/layout.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // layout.hpp
 //
 // Phase 5/6/7 — Layout / embedding: DOF vector → vertex coordinates in the

code/include/matrix_utility.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 
 // 4x4 mapping matrix from corresponding point pairs.
 // Ported from de.varylab.discreteconformal.math.MatrixUtility (Java).

code/include/mesh_builder.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // mesh_builder.hpp
 //
 // Factory functions that build simple reference meshes for testing and examples.

code/include/mesh_io.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // mesh_io.hpp
 //
 // Phase 4b — CGAL::IO wrappers for ConformalMesh.

code/include/mesh_utils.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // mesh_utils.hpp
 //
 // Conversions between CGAL::Surface_mesh and Eigen matrices.  Used

code/include/newton_solver.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // newton_solver.hpp
 //
 // Phase 4a — Newton solver for all three discrete conformal functionals.

code/include/p2_utility.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 
 // 2-D projective geometry utilities for the Euclidean signature.
 // Ported from de.jreality.math.P2 and de.varylab.discreteconformal.math.P2Big.

code/include/period_matrix.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // period_matrix.hpp
 //
 // Phase 7 — Period matrix for closed surfaces with Euclidean (flat) metric.

code/include/projective_math.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 
 // Projective and hyperbolic geometry utilities.
 // Ported from de.jreality.math.Pn / Rn and

code/include/serialization.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // serialization.hpp
 //
 // Phase 5 — Save and load conformal map results in JSON and XML formats.

code/include/spherical_functional.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // spherical_functional.hpp
 //
 // Energy and gradient of the spherical discrete conformal functional

code/include/spherical_geometry.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // spherical_geometry.hpp
 //
 // Pure-math building blocks for the spherical discrete conformal map.

code/include/spherical_hessian.hpp

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // spherical_hessian.hpp
 //
 // Analytical Hessian of the spherical discrete conformal energy —

code/include/viewer_utils.h

@@ -1,4 +1,7 @@
 #pragma once
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 
 #include <Eigen/Dense>
 #include <igl/opengl/glfw/Viewer.h>

code/src/apps/v0/conformallab_cli.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // conformallab_cli.cpp
 //
 // ConformalLab++ command-line interface.

code/src/viewer/simple_viewer.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 #include "viewer_utils.h"
 
 namespace viewer_utils {

code/tests/cgal/test_cgal_phase8b_lite.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_cgal_phase8b_lite.cpp
 //
 // Phase 8b-Lite — Smoke tests for the four new CGAL-style entry functions

code/tests/cgal/test_cgal_traits_mvp.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_cgal_traits_mvp.cpp
 //
 // Phase 8 MVP — first tests for the new CGAL-style public API.

code/tests/cgal/test_conformal_mesh.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_conformal_mesh.cpp
 //
 // Phase 3a — CGAL Surface_mesh infrastructure tests.

code/tests/cgal/test_cp_euclidean_functional.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_cp_euclidean_functional.cpp
 //
 // Phase 9a.1 — CPEuclideanFunctional (BPS 2010) tests.

code/tests/cgal/test_euclidean_functional.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_euclidean_functional.cpp
 //
 // Phase 3d — EuclideanCyclicFunctional ported to ConformalMesh.

code/tests/cgal/test_euclidean_hessian.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_euclidean_hessian.cpp
 //
 // Phase 3f — Euclidean cotangent-Laplace Hessian.

code/tests/cgal/test_geometry_utils.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_geometry_utils.cpp
 //
 // Port of the Java ConformalLab geometry utility tests.

code/tests/cgal/test_hyper_ideal_functional.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_hyper_ideal_functional.cpp
 //
 // Phase 3b — HyperIdealFunctional ported to ConformalMesh.

code/tests/cgal/test_hyper_ideal_hessian.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_hyper_ideal_hessian.cpp
 //
 // Phase 9b — Hyper-ideal Hessian: block-FD vs full-FD cross-validation.

code/tests/cgal/test_inversive_distance_functional.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_inversive_distance_functional.cpp
 //
 // Phase 9a.2 — Inversive-distance functional (Luo 2004) tests.

code/tests/cgal/test_layout.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_layout.cpp
 //
 // Phase 5 — Layout / embedding tests.

code/tests/cgal/test_mesh_io.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_mesh_io.cpp
 //
 // Phase 4b — CGAL::IO mesh round-trip tests.

code/tests/cgal/test_newton_phase9a.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_newton_phase9a.cpp
 //
 // Phase 9a Newton solvers — convergence tests for the two new

code/tests/cgal/test_newton_solver.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_newton_solver.cpp
 //
 // Phase 4 — Newton solver tests.

code/tests/cgal/test_phase6.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_phase6.cpp
 //
 // Phase 6 — Tests for:

code/tests/cgal/test_phase7.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_phase7.cpp
 //
 // Phase 7 — Tests for Java-parity layout features:

code/tests/cgal/test_pipeline.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_pipeline.cpp
 //
 // Phase 4c — End-to-end pipeline tests and library-user examples.

code/tests/cgal/test_scalability_smoke.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_scalability_smoke.cpp
 //
 // Scalability smoke tests — convergence on large real-world meshes.

code/tests/cgal/test_spherical_functional.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_spherical_functional.cpp  (Phase 3c + 3e)
 //
 // Phase 3c — SphericalFunctional ported to ConformalMesh.

code/tests/cgal/test_spherical_hessian.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // test_spherical_hessian.cpp
 //
 // Phase 3f — Spherical cotangent-Laplace Hessian.

code/tests/test_clausen.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // Port of de.varylab.discreteconformal.functional.ClausenTest (Java/JUnit).
 // Reference values computed with Mathematica.
 

code/tests/test_discrete_elliptic_utility.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // Port of de.varylab.discreteconformal.util.DiscreteEllipticUtilityTest (Java/JUnit).
 // Tests the normalizeModulus function that moves a complex number tau into the
 // fundamental domain of the modular group SL(2,Z).

code/tests/test_hyper_ideal_utility.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // Port of de.varylab.discreteconformal.functional.HyperIdealUtilityTest (Java/JUnit).
 
 #include "hyper_ideal_utility.hpp"

code/tests/test_hyper_ideal_visualization_utility.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // Port of de.varylab.discreteconformal.plugin.HyperIdealVisualizationPluginTest (Java/JUnit).
 //
 // Tests the conversion from a hyperbolic circle (hyperboloid model)

code/tests/test_matrix_utility.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // Port of de.varylab.discreteconformal.math.MatrixUtilityTest (Java/JUnit).
 
 #include "matrix_utility.hpp"

code/tests/test_p2_utility.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // Port of de.varylab.discreteconformal.math.P2BigTest (Java/JUnit).
 // Tests 2-D projective geometry utilities: perpendicular bisectors,
 // point-from-lines, and direct isometries in the Euclidean plane.

code/tests/test_surface_curve_utility.cpp

@@ -1,3 +1,6 @@
+// Copyright (c) 2024-2026 Tarik Moussa.
+// SPDX-License-Identifier: MIT
+
 // Port of de.varylab.discreteconformal.uniformization.SurfaceCurveUtilityTest
 // (Java/JUnit) — the two pure-math tests that don't need the HDS.