conformallab/ConformalLabpp
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

docs(s3): mark H3/H4/H5/V5/V6 done; update audit banners + orchestration
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 8m21s
Details
C++ Tests / quality-gates (pull_request) Has been skipped
Details
C++ Tests / test-cgal (pull_request) Has been skipped
Details

Browse Source 
- finding-orchestration.md: H3/H4/H5/V5/V6 → ✅; S3 session entry updated
  to DONE with commit refs (833f9e7, 2e6c4d7), PR #45, and 313/313 count.
- test-coverage-error-handling-audit-2026-05-31.md: banner updated to
  reflect H3/H4/H5 resolved in S3; test count 298 → 313.
- input-validation-audit-2026-05-31.md: banner updated to reflect V5/V6
  resolved in S3; test count 298 → 313.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Tarik Moussa
2026-06-01 01:28:59 +02:00
committed by Tarik Moussa
parent 71afd8e70a
commit cda26d7b02
3 changed files with 28 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
doc/reviewer/finding-orchestration.md
View File

@@ -70,10 +70,10 @@ Status: ✅ done · ⬜ open (actionable) · ⏸ deferred (intentional) · ⛔ b
| I1 | test-cov | 🟡 | ✅ | Opus | S2 |
| H1 | test-cov | 🔵 | ✅ | Opus | S2 |
| N7 | numerics | 🔵 | ✅ | Opus | S2 |
| **H3** | test-cov | 🔵 | ⬜ | Sonnet→🔍Opus | **S3** |
| **H4** | test-cov | 🔵 | ⬜ | Sonnet→🔍Opus | **S3** |
| **H5** | test-cov | 🔵 | ⬜ | Sonnet→🔍Opus | **S3** |
| **V5, V6** | input-val | 🔵 | ⬜ | Sonnet→🔍Opus | **S3** |
| **H3** | test-cov | 🔵 | ✅ | Sonnet→🔍Opus | **S3** |
| **H4** | test-cov | 🔵 | ✅ | Sonnet→🔍Opus | **S3** |
| **H5** | test-cov | 🔵 | ✅ | Sonnet→🔍Opus | **S3** |
| **V5, V6** | input-val | 🔵 | ✅ | Sonnet→🔍Opus | **S3** |
| **N2** | numerics | 🟡 | ⬜ | Haiku→🔍Opus | **S4** |
| **thread-safety doc** | thread-safety | 🟡 | ⬜ | Haiku→🔍Opus | **S4** |
| **M3** | math-cite | 🟡 | ⬜ | Haiku→🔍Opus | **S4** |
@@ -126,14 +126,19 @@ CGAL result types (`Conformal_map_result`, `Hyper_ideal_map_result`,
</details>
### ⬜ S3 — Robustness & test-gap closure (Sonnet → 🔍 Opus)
- **H3** — `enforce_gauss_bonnet` reports the magnitude of the applied correction.
- **H4** — test `reduce_to_fundamental_domain` boundary `Im(τ)==0.0`.
- **H5** — integration test for the degenerate-triangle path in the Newton solve.
- **V5** — make the hand-rolled XML reader *reject* reformatted-but-valid XML
instead of silently mis-reading it into zeros.
- **V6** — DOF-vector-vs-mesh size check on load.
- **🔍 Opus review:** verify the new rejections don't break valid round-trips.
### ✅ S3 — Robustness & test-gap closure (DONE, 2026-06-01, Sonnet impl)
Branch `fix/s3-robustness-gaps`, 2 commits (`833f9e7`, `2e6c4d7`), 313/313 CGAL tests green.
- **H3** — `enforce_gauss_bonnet` returns `|deficit|` (both overloads); 3 new tests.
- **H4** — `ReduceToFD_ThrowsForRealAxisBoundary` covers `Im(τ)==0.0` exact boundary.
- **H5** — 2 new integration tests: sliver triangle (no crash/NaN, no LinearSolverFailed)
and exact-degenerate triangle (no crash, meaningful failure status documented).
- **V5** — `load_result_xml` now explicitly rejects non-conforming XML (3 strict-subset
checks: `geometry=` on same line, `>` on same line as DOFVector, root element present);
3 new tests (reject reformatted root, reject reformatted DOFVector, canonical still works).
- **V6** — `check_dof_vector_size(x, expected, context)` helper added to
`serialization.hpp`; 3 new tests (throws on mismatch, passes on match, message content).
- **PR:** https://git.eulernest.eu/conformallab/ConformalLabpp/pulls/45
- **🔍 Opus review:** pending.
### ⬜ S4 — Documentation & citations (Haiku → 🔍 Opus)
- **N2** — `doc/math/tolerances.md`: every numerical threshold, its role, and