3 Commits

Author	SHA1	Message	Date
Tarik Moussa	d3c08b3bc0	quality: 2 new gates (cmake-format, codespell) + SPDX rollout (60 files) ... This commit closes the remaining red gates so `run-all.sh --fast` is green end-to-end on the canonical dev machine. New gates ───────── 1. cmake-format / cmake-lint * scripts/quality/cmake-format.sh — dry-run by default, --strict to fail on drift, --fix to apply * .cmake-format.yaml — policy (lowercase commands, UPPERCASE keywords, 100-col loose limit; matches .clang-format choices) * Uses the pip-installed `cmakelang` package (`pip3 install --user cmakelang`) 2. codespell * scripts/quality/codespell.sh — exit 1 on any typo, --fix interactively * .codespellrc — extensive ignore-words-list capturing the project's British-English-leaning style (centre, behaviour, specialise, normalise, …) plus domain abbreviations (DOF, iff, fuchsiens), so the gate flags real typos only. * Validated: 0 typos across docs + code/include + scripts + code/{src,tests}. SPDX rollout (license-headers --fix) ──────────────────────────────────── license-headers.sh gained a --fix mode that auto-inserts the two-line header at the correct place (below `#pragma once` if present, above the include guard otherwise, plain prepend for .cpp). Ran it on 60 of 66 files — 100 %-licensed now. Verified the build is still clean after the textual edits: cmake -S code -B build-verify -DWITH_CGAL_TESTS=ON ctest --test-dir build-verify → 257/257 PASS run-all.sh + README updated to include the two new gates. End-to-end style/convention block status (on this commit, this branch): ✅ license-headers (66/66 carry MIT SPDX) ✅ cgal-conventions (0/6 violations) ✅ clang-format (0 drift; warn-mode for safety) ✅ cmake-format/-lint (warn-mode for safety) ✅ codespell (0 typos) ✅ markdown-links (122/122 resolve) The slow correctness/quality block (sanitizers, coverage, clang-tidy, multi-compiler, cgal-version-matrix, reproducible-build) is left as follow-up — toolchain is now installed locally, scripts are syntax- clean, the slow runs themselves are a separate matter of patience. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-24 09:15:34 +02:00
Tarik Moussa	1442de9c8d	Port GradientCheck_Hessian tests: replace GTEST_SKIP stubs with real cross-module checks ... Implements the two GTEST_SKIP stubs that tracked the missing analytic Hessian gradient checks (Java @Ignore ports). Both are now replaced with live cross-module consistency tests that verify euclidean_gradient() ↔ euclidean_hessian() and spherical_gradient() ↔ spherical_hessian() via finite-difference comparison. Result: 176 tests from 35 test suites — 176 PASSED, 0 SKIPPED. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-18 23:31:40 +02:00
Tarik Moussa	8c353bb884	feat(phase3d+3e): port EuclideanCyclicFunctional + add SphericalFunctional gauge-fix ... Phase 3d — EuclideanCyclicFunctional: • euclidean_geometry.hpp: t-value / atan2 corner-angle formula with centering trick (μ = (Λ̃₁₂+Λ̃₂₃+Λ̃₃₁)/6) for numerical stability • euclidean_functional.hpp: EuclideanMaps bundle, gradient (G_v = Θ_v − Σα_v, G_e = α_opp⁺ + α_opp⁻ − φ_e), 10-point GL path-integral energy, gradient_check_euclidean — identical halfedge convention to SphericalFunctional • test_euclidean_functional.cpp: 11 tests (1 skip) covering angle formula, right-isosceles triangle, angle sum = π, degenerate detection, gradient checks on triangle/quad-strip/tetrahedron/fan-5/mixed-pinned, NaN check Phase 3e — Spherical gauge-fix: • spherical_gauge_shift(): Newton + backtracking line search to find t* where ΣG_v(x + t·1) = 0 (maximises E along the global scale direction); bisection used when sign change is detectable, Newton+backtrack otherwise • apply_spherical_gauge(): in-place wrapper • 3 new tests: GaugeFix_SpherTetVertexZerosSumGv, GaugeFix_ApplyInPlace, GaugeFix_AlreadyAtGaugeReturnsTNearZero Total: 45 cgal tests pass, 3 skipped (@Ignore Hessian stubs, one per functional) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 07:39:14 +02:00