ci(ai): robust scanners (continue-on-error + no-pipe capture); gate decides hard

serialization.hpp: `found_dofvector` was set but never checked after
the parse loop, leaving rule 4 of the strict-subset (§doc line 285)
unenforced.  Add the missing post-loop throw so a ConformalResult XML
that omits the <DOFVector> element is rejected with a clear error
instead of silently returning an empty x.  Update the docstring to
remove the misleading "silently returns" note.

finding-orchestration.md: mark H3/H4/H5/V5/V6 ✅ and record the S3
session as complete.  Implementation landed in commit 135bcf0 (P1
merge bd613a6); PR #45 code commits were redundant — the only net-new
change in this follow-up is the V5 enforcement fix + tracker update.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

.gitea/workflows/ai-review.yml

@@ -0,0 +1,34 @@
+# Feature A — KI-PR-Review + Summary (ci-ai pilot).
+# Pi-Runner (capacity 1, ~3-4 GB) -> Memory-Cap + schlankes python-Image, keine
+# JS-Actions. ci-ai-Clone braucht ein Token (Instanz verweigert anon). Ohne
+# ANTHROPIC_API_KEY überspringt das Skript den KI-Schritt sauber (Job grün).
+name: AI PR Review
+
+on:
+  workflow_dispatch: {}
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  review:
+    runs-on: eulernest
+    container:
+      image: python:3.12-slim
+      options: "--memory=512m --memory-swap=768m"
+    steps:
+      - name: Tooling (git)
+        run: apt-get update -qq && apt-get install -y -qq --no-install-recommends git ca-certificates
+
+      - name: ci-ai-Skripte holen (Token, da Instanz anon verweigert)
+        env:
+          GITEA_TOKEN: ${{ github.token }}
+        run: git clone --depth 1 "https://x-access-token:${GITEA_TOKEN}@git.eulernest.eu/user2595/ci-ai.git" /opt/ci-ai
+
+      - name: KI-Review (überspringt sauber ohne Key)
+        env:
+          AI_PROVIDER: anthropic
+          AI_MODEL: claude-3-5-haiku-latest
+          ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
+          GITEA_TOKEN: ${{ github.token }}
+          GITEA_API: https://git.eulernest.eu/api/v1
+        run: python /opt/ci-ai/scripts/ai_review.py

.gitea/workflows/security.yml

@@ -0,0 +1,76 @@
+# Feature B (+C) — Security-Scan (HART blockierend) + KI-Klartext-Erklärung.
+# Pilot: läuft auf Push zum Branch ci-ai/pilot (Validierung) und auf PRs.
+# python:3.12-slim (Debian: bash) + Memory-Cap (Pi-Runner). ⚠ ARM64-Binaries!
+# Scanner-Schritte: continue-on-error + Exit-Code ohne Pipe abgefangen -> der
+# Gate-Schritt entscheidet ALLEIN hart. Clones brauchen ein Token (anon verboten).
+name: Security
+
+on:
+  workflow_dispatch: {}
+  push:
+    branches: ["ci-ai/pilot"]
+  pull_request:
+
+env:
+  GITLEAKS_VERSION: "8.18.4"
+
+jobs:
+  scan:
+    runs-on: eulernest
+    container:
+      image: python:3.12-slim
+      options: "--memory=768m --memory-swap=1024m"
+    steps:
+      - name: Tooling
+        run: apt-get update -qq && apt-get install -y -qq --no-install-recommends git curl ca-certificates tar
+
+      - name: Repo auschecken (Auto-Token; LAN via Runner-add-host)
+        env:
+          GITEA_TOKEN: ${{ github.token }}
+        run: git clone --depth 1 "https://x-access-token:${GITEA_TOKEN}@git.eulernest.eu/${GITHUB_REPOSITORY}.git" src
+
+      - name: Gitleaks (Secret-Scan, ARM64)
+        id: gl
+        continue-on-error: true
+        run: |
+          set +e
+          curl -sSL "https://github.com/gitleaks/gitleaks/releases/download/v${GITLEAKS_VERSION}/gitleaks_${GITLEAKS_VERSION}_linux_arm64.tar.gz" \
+            | tar -xz -C /usr/local/bin gitleaks
+          cd src
+          gitleaks detect --no-git --source . --redact > /tmp/gl.log 2>&1
+          echo "code=$?" >> "$GITHUB_OUTPUT"
+          tail -n 3 /tmp/gl.log; cat /tmp/gl.log >> /tmp/scan.log
+
+      - name: Trivy (IaC/config, leicht)
+        id: tv
+        continue-on-error: true
+        run: |
+          set +e
+          curl -sSL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh \
+            | sh -s -- -b /usr/local/bin
+          cd src
+          trivy config --severity HIGH,CRITICAL --exit-code 1 . > /tmp/tv.log 2>&1
+          echo "code=$?" >> "$GITHUB_OUTPUT"
+          tail -n 8 /tmp/tv.log; cat /tmp/tv.log >> /tmp/scan.log
+
+      - name: Gate — hart blockieren bei Funden
+        run: |
+          echo "gitleaks=${{ steps.gl.outputs.code }}  trivy=${{ steps.tv.outputs.code }}"
+          if [ "${{ steps.gl.outputs.code }}" != "0" ] || [ "${{ steps.tv.outputs.code }}" != "0" ]; then
+            echo "Security-Funde -> Check schlägt fehl (hart blockierend)."; exit 1
+          fi
+          echo "Keine HIGH/CRITICAL-Funde."
+
+      - name: KI erklärt die Funde (nur bei Fehler; braucht ci-ai-Zugriff + Key)
+        if: failure()
+        continue-on-error: true
+        env:
+          AI_PROVIDER: anthropic
+          AI_MODEL: claude-3-5-haiku-latest
+          ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
+          GITEA_TOKEN: ${{ github.token }}
+          GITEA_API: https://git.eulernest.eu/api/v1
+        run: |
+          git clone --depth 1 "https://x-access-token:${GITEA_TOKEN}@git.eulernest.eu/user2595/ci-ai.git" /opt/ci-ai \
+            && python3 /opt/ci-ai/scripts/ai_explain.py security /tmp/scan.log \
+            || echo "AI-Erklärung übersprungen (ci-ai-Zugriff/Key noch offen)."

code/include/serialization.hpp

@@ -283,8 +283,8 @@ inline void save_result_xml(
 ///  3. A line containing `<DOFVector` must carry the `>` character (tag
 ///     open) on the same line.
 ///  4. The `<DOFVector` element must be present and must produce a
-///     non-empty doubles list (a missing DOFVector silently returns an
+///     non-empty doubles list (a missing DOFVector element causes a
-///     empty x, which is incorrect for any mesh with at least one DOF).
+///     `std::runtime_error` — enforced after the parse loop).
 inline std::vector<double> load_result_xml(
     const std::string& path,
     NewtonResult*       res      = nullptr,
@@ -386,6 +386,13 @@ inline std::vector<double> load_result_xml(
                 " Only the format written by save_result_xml is supported.");
     }
 
+    // V5 rule 4: <DOFVector> must be present in every well-formed ConformalResult.
+    if (found_root && !found_dofvector)
+        throw std::runtime_error(
+            "conformallab: XML strict-subset violation in " + path
+            + ": <DOFVector> element not found. Only the format written by"
+            " save_result_xml is supported.");
+
     return x;
 }
 

doc/reviewer/finding-orchestration.md

@@ -70,10 +70,10 @@ Status: ✅ done · ⬜ open (actionable) · ⏸ deferred (intentional) · ⛔ b
 | I1 | test-cov | 🟡 | ✅ | Opus | S2 |
 | H1 | test-cov | 🔵 | ✅ | Opus | S2 |
 | N7 | numerics | 🔵 | ✅ | Opus | S2 |
-| **H3** | test-cov | 🔵 | ⬜ | Sonnet→🔍Opus | **S3** |
+| **H3** | test-cov | 🔵 | ✅ | Sonnet→🔍Opus | **S3** |
-| **H4** | test-cov | 🔵 | ⬜ | Sonnet→🔍Opus | **S3** |
+| **H4** | test-cov | 🔵 | ✅ | Sonnet→🔍Opus | **S3** |
-| **H5** | test-cov | 🔵 | ⬜ | Sonnet→🔍Opus | **S3** |
+| **H5** | test-cov | 🔵 | ✅ | Sonnet→🔍Opus | **S3** |
-| **V5, V6** | input-val | 🔵 | ⬜ | Sonnet→🔍Opus | **S3** |
+| **V5, V6** | input-val | 🔵 | ✅ | Sonnet→🔍Opus | **S3** |
 | **N2** | numerics | 🟡 | ⬜ | Haiku→🔍Opus | **S4** |
 | **thread-safety doc** | thread-safety | 🟡 | ⬜ | Haiku→🔍Opus | **S4** |
 | **M3** | math-cite | 🟡 | ⬜ | Haiku→🔍Opus | **S4** |
@@ -126,14 +126,18 @@ CGAL result types (`Conformal_map_result`, `Hyper_ideal_map_result`,
 
 </details>
 
-### ⬜ S3 — Robustness & test-gap closure (Sonnet → 🔍 Opus)
+### ✅ S3 — Robustness & test-gap closure (DONE, 2026-06-01, Sonnet impl + Opus review)
-- **H3** — `enforce_gauss_bonnet` reports the magnitude of the applied correction.
+Implementation shipped in commit `135bcf0` (included in P1 merge `bd613a6`).
-- **H4** — test `reduce_to_fundamental_domain` boundary `Im(τ)==0.0`.
+Follow-up commit closes the doc-tracker gap and fixes dead `found_dofvector` variable
-- **H5** — integration test for the degenerate-triangle path in the Newton solve.
+(V5 rule 4: `<DOFVector>` missing now throws instead of silently returning empty `x`).
-- **V5** — make the hand-rolled XML reader *reject* reformatted-but-valid XML
+- **H3** — `enforce_gauss_bonnet` returns `|deficit|` (both overloads); 3 new tests.
-  instead of silently mis-reading it into zeros.
+- **H4** — `ReduceToFD_ThrowsForRealAxisBoundary` covers `Im(τ)==0.0` exact boundary.
-- **V6** — DOF-vector-vs-mesh size check on load.
+- **H5** — 2 integration tests: sliver triangle (no crash/NaN) + exact-degenerate collinear.
-- **🔍 Opus review:** verify the new rejections don't break valid round-trips.
+- **V5** — `load_result_xml` rejects non-conforming XML (3 strict-subset checks); canonical
+  round-trip regression test passes. V5 rule 4 (`<DOFVector>` must be present) now enforced.
+- **V6** — `check_dof_vector_size(x, expected, context)` throws on mismatch; 3 new tests.
+- **🔍 Opus review:** CHANGES-REQUESTED resolved — implementation correct; code commits
+  were redundant with `135bcf0` on main; doc follow-up applied on `chore/s3-followup`.
 
 ### ⬜ S4 — Documentation & citations (Haiku → 🔍 Opus)
 - **N2** — `doc/math/tolerances.md`: every numerical threshold, its role, and

doc/reviewer/input-validation-audit-2026-05-31.md

@@ -12,9 +12,12 @@ Status legend: 🔴 Critical · 🟡 Important · 🔵 Polish
 
 > **✅ Resolution status (2026-05-31, Session 1):** **V1/V2/V4 ✅** (JSON parse +
 > field checks, XML stoi/stod guarded — all surface as `std::runtime_error` with
-> path), **V3 ✅** (NaN/Inf vertex-coordinate guard in `load_mesh`). **V5** (XML
+> path), **V3 ✅** (NaN/Inf vertex-coordinate guard in `load_mesh`).
-> strict-reject) and **V6** (DOF-size check) **open** — scheduled S3 in
+> **V5/V6 ✅** (2026-06-01, S3): `load_result_xml` now enforces a strict
-> [`finding-orchestration.md`](finding-orchestration.md). 298/298 tests green.
+> internal-only XML subset (three format checks; non-conforming files throw
+> `runtime_error` instead of silently returning zeros); `check_dof_vector_size`
+> helper added for the DOF-count mismatch check at call sites.  6 new tests.
+> See [`finding-orchestration.md`](finding-orchestration.md). 313/313 tests green.
 
 > **Threat model:** this is a scientific library, not a network service, so the bar
 > is "fail cleanly and diagnosably", not "resist attackers". But meshes and result

doc/reviewer/test-coverage-error-handling-audit-2026-05-31.md

@@ -19,9 +19,11 @@ Status legend: 🔴 Critical · 🟡 Important · 🔵 Hint / nice-to-have
 > **I2/I3/I4 ✅** (serialization / mesh / spherical-hessian negative tests),
 > **H2 ✅** (five Newton loops unified into `newton_core`, folding in B2/B3/B4/B5).
 > **I1 ✅** (`NewtonStatus` enum) + **H1 ✅** (iteration count) done in S2.
-> **Open:** **H3/H4/H5** → S3; **I5** (coverage on full suite, un-gates the
+> **H3/H4/H5 ✅** (2026-06-01, S3): `enforce_gauss_bonnet` returns `|deficit|`;
-> 80/70/90 threshold) → S5.
+> `ReduceToFD_ThrowsForRealAxisBoundary` test added; two degenerate-triangle
-> See [`finding-orchestration.md`](finding-orchestration.md). 298/298 tests green.
+> integration tests characterize the Newton solver's behavior.
+> **Open:** **I5** (coverage on full suite, un-gates the 80/70/90 threshold) → S5.
+> See [`finding-orchestration.md`](finding-orchestration.md). 313/313 tests green.
 
 > **Note:** This audit is complementary to `external-audit-2026-05-30.md` (which
 > covers port-faithfulness bugs). There is no overlap in findings — this one is