Compare commits
6 Commits
main
...
fix/citati
| Author | SHA1 | Date | |
|---|---|---|---|
| 3df6e7a576 | |||
| b37a7b12a7 | |||
| 70b94b9ead | |||
|
|
ef3c448f4d | ||
|
|
51cbfdfd54 | ||
|
|
a3a7c2228f |
@@ -6,7 +6,12 @@
|
|||||||
},
|
},
|
||||||
"outputStyle": "Explanatory",
|
"outputStyle": "Explanatory",
|
||||||
"teammateMode": "tmux",
|
"teammateMode": "tmux",
|
||||||
|
"preferences": {
|
||||||
|
"tmuxSplitPanes": "true",
|
||||||
|
"responseFormat": "markdown"
|
||||||
|
},
|
||||||
"permissions": {
|
"permissions": {
|
||||||
|
"defaultMode": "acceptEdits",
|
||||||
"allow": [
|
"allow": [
|
||||||
"Bash(cmake:*)",
|
"Bash(cmake:*)",
|
||||||
"Bash(ctest:*)",
|
"Bash(ctest:*)",
|
||||||
@@ -25,18 +30,56 @@
|
|||||||
"Bash(git branch:*)",
|
"Bash(git branch:*)",
|
||||||
"Bash(git ls-remote:*)",
|
"Bash(git ls-remote:*)",
|
||||||
"Bash(git ls-files:*)",
|
"Bash(git ls-files:*)",
|
||||||
|
"Bash(git remote:*)",
|
||||||
|
"Bash(git rev-parse:*)",
|
||||||
|
"Bash(git rev-list:*)",
|
||||||
|
"Bash(git merge-base:*)",
|
||||||
|
"Bash(git diff-tree:*)",
|
||||||
|
"Bash(git describe:*)",
|
||||||
|
"Bash(git tag:*)",
|
||||||
|
"Bash(git add:*)",
|
||||||
|
"Bash(git commit:*)",
|
||||||
|
"Bash(git switch:*)",
|
||||||
|
"Bash(git checkout:*)",
|
||||||
|
"Bash(git restore:*)",
|
||||||
|
"Bash(git stash:*)",
|
||||||
|
"Bash(git fetch:*)",
|
||||||
|
"Bash(git pull:*)",
|
||||||
|
"Bash(git push:*)",
|
||||||
|
"Bash(git merge:*)",
|
||||||
|
"Bash(git rebase:*)",
|
||||||
|
"Bash(git worktree:*)",
|
||||||
|
"Bash(git init:*)",
|
||||||
|
"Bash(git mv:*)",
|
||||||
"Bash(ls:*)",
|
"Bash(ls:*)",
|
||||||
"Bash(find:*)",
|
"Bash(find:*)",
|
||||||
"Bash(grep:*)",
|
"Bash(grep:*)",
|
||||||
"Bash(rg:*)",
|
"Bash(rg:*)",
|
||||||
"Bash(wc:*)",
|
"Bash(wc:*)",
|
||||||
"Bash(curl -s*)"
|
"Bash(curl -s*)",
|
||||||
|
"Bash(curl:*)",
|
||||||
|
"Bash(bash -n:*)",
|
||||||
|
"Bash(cat:*)",
|
||||||
|
"Bash(head:*)",
|
||||||
|
"Bash(tail:*)",
|
||||||
|
"Bash(awk:*)",
|
||||||
|
"Bash(jq:*)",
|
||||||
|
"Bash(mkdir:*)",
|
||||||
|
"Bash(cp:*)",
|
||||||
|
"Bash(test:*)",
|
||||||
|
"Bash(echo:*)",
|
||||||
|
"Bash(true)"
|
||||||
],
|
],
|
||||||
"deny": [
|
"deny": [
|
||||||
"Bash(git push --force* origin main*)",
|
"Bash(git push --force:*)",
|
||||||
"Bash(git push -f* origin main*)",
|
"Bash(git push -f:*)",
|
||||||
"Bash(git reset --hard*)",
|
"Bash(git clean -fdx:*)",
|
||||||
"Bash(rm -rf /*)"
|
"Bash(git clean -fd:*)",
|
||||||
|
"Bash(rm -rf /)",
|
||||||
|
"Bash(rm -rf /*)",
|
||||||
|
"Bash(rm -rf ~)",
|
||||||
|
"Bash(rm -rf ~/*)",
|
||||||
|
"Bash(sudo rm:*)"
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
65
.forgejo/workflows/cpp-tests.yml
Normal file
65
.forgejo/workflows/cpp-tests.yml
Normal file
@@ -0,0 +1,65 @@
|
|||||||
|
# Forgejo Actions — Codeberg (https://codeberg.org)
|
||||||
|
#
|
||||||
|
# Codeberg counterpart of the eulernest Gitea pipeline
|
||||||
|
# (.gitea/workflows/cpp-tests.yml). Two differences are required because
|
||||||
|
# Codeberg's shared runners are not the Pi runner:
|
||||||
|
#
|
||||||
|
# * runs-on: docker — Codeberg shared-runner label (not "eulernest")
|
||||||
|
# * image: node:20-bookworm — public image (the private git.eulernest.eu
|
||||||
|
# ci-cpp image is unreachable from Codeberg).
|
||||||
|
# node:20 ships the Node runtime that
|
||||||
|
# actions/checkout@v4 needs; build tools are
|
||||||
|
# apt-installed in the first step.
|
||||||
|
#
|
||||||
|
# Scope: "test-fast" only — the pure-math suite (Eigen vendored, GoogleTest via
|
||||||
|
# FetchContent, no CGAL/Boost). A red job here = a red Codeberg CI badge.
|
||||||
|
|
||||||
|
name: C++ Tests (Codeberg)
|
||||||
|
|
||||||
|
on:
|
||||||
|
push:
|
||||||
|
branches:
|
||||||
|
- main
|
||||||
|
- "claude/**"
|
||||||
|
- "feature/**"
|
||||||
|
- "review/**"
|
||||||
|
pull_request:
|
||||||
|
|
||||||
|
jobs:
|
||||||
|
test-fast:
|
||||||
|
runs-on: docker
|
||||||
|
container:
|
||||||
|
image: node:20-bookworm
|
||||||
|
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
|
- name: Install build deps (cmake, g++, make)
|
||||||
|
run: |
|
||||||
|
apt-get update -qq
|
||||||
|
apt-get install -y --no-install-recommends \
|
||||||
|
cmake g++ make git ca-certificates
|
||||||
|
|
||||||
|
- name: Configure (tests-only — Eigen + GoogleTest)
|
||||||
|
run: cmake -S code -B build -DCMAKE_BUILD_TYPE=Release
|
||||||
|
|
||||||
|
- name: Build
|
||||||
|
run: cmake --build build --target conformallab_tests -j$(nproc)
|
||||||
|
|
||||||
|
- name: Run tests
|
||||||
|
run: >
|
||||||
|
ctest --test-dir build
|
||||||
|
--output-on-failure
|
||||||
|
--output-junit test-results.xml
|
||||||
|
|
||||||
|
- name: Summary
|
||||||
|
if: always()
|
||||||
|
run: |
|
||||||
|
if [ -f build/test-results.xml ]; then f=build/test-results.xml; else f=test-results.xml; fi
|
||||||
|
if [ -f "$f" ]; then
|
||||||
|
total=$(grep -o 'tests="[0-9]*"' "$f" | grep -o '[0-9]*' | head -1)
|
||||||
|
failed=$(grep -o 'failures="[0-9]*"' "$f" | grep -o '[0-9]*' | head -1)
|
||||||
|
skipped=$(grep -o 'skipped="[0-9]*"' "$f" | grep -o '[0-9]*' | head -1)
|
||||||
|
passed=$(( ${total:-0} - ${failed:-0} - ${skipped:-0} ))
|
||||||
|
echo "FAST ▸ TOTAL ${total:-0} | PASSED $passed | FAILED ${failed:-0} | SKIPPED ${skipped:-0}"
|
||||||
|
fi
|
||||||
7
.gitignore
vendored
7
.gitignore
vendored
@@ -33,3 +33,10 @@ Testing/
|
|||||||
# Doxygen output
|
# Doxygen output
|
||||||
doc/doxygen/
|
doc/doxygen/
|
||||||
*.dox.tmp
|
*.dox.tmp
|
||||||
|
|
||||||
|
# Downloaded research papers + derived artifacts (regenerable, not tracked)
|
||||||
|
papers/*.pdf
|
||||||
|
papers/txt/
|
||||||
|
papers/mmd/
|
||||||
|
papers/facebook/
|
||||||
|
papers/figures/
|
||||||
|
|||||||
31
.woodpecker.yml
Normal file
31
.woodpecker.yml
Normal file
@@ -0,0 +1,31 @@
|
|||||||
|
# Woodpecker CI — Codeberg (https://ci.codeberg.org)
|
||||||
|
#
|
||||||
|
# Runs on every push / PR. Mirrors the "test-fast" job of the
|
||||||
|
# eulernest Gitea pipeline (.gitea/workflows/cpp-tests.yml), but uses a
|
||||||
|
# plain public Debian image instead of the private ci-cpp registry image,
|
||||||
|
# because Codeberg's shared runners cannot pull git.eulernest.eu.
|
||||||
|
#
|
||||||
|
# Pure-math test suite only (Clausen, ImLi2, hyper-ideal geometry):
|
||||||
|
# * Eigen is vendored → code/deps/eigen-3.4.0
|
||||||
|
# * GoogleTest via FetchContent (network at configure time)
|
||||||
|
# * No CGAL / Boost / Wayland needed → fast, headless, < 2 min
|
||||||
|
#
|
||||||
|
# A failing build or any failing ctest makes the Codeberg CI badge red.
|
||||||
|
|
||||||
|
when:
|
||||||
|
- event: [push, pull_request]
|
||||||
|
|
||||||
|
steps:
|
||||||
|
test-fast:
|
||||||
|
image: debian:bookworm
|
||||||
|
commands:
|
||||||
|
- apt-get update -qq
|
||||||
|
- >-
|
||||||
|
apt-get install -y --no-install-recommends
|
||||||
|
cmake g++ make git ca-certificates
|
||||||
|
- cmake -S code -B build -DCMAKE_BUILD_TYPE=Release
|
||||||
|
- cmake --build build --target conformallab_tests -j$(nproc)
|
||||||
|
- >-
|
||||||
|
ctest --test-dir build
|
||||||
|
--output-on-failure
|
||||||
|
--output-junit test-results.xml
|
||||||
@@ -142,6 +142,7 @@ Layout2D layout = euclidean_layout(mesh, res.x, maps);
|
|||||||
| **geometry-central comparison** — shared core, demarcation, adoption candidates, scientific added value | [doc/architecture/geometry-central-comparison.md](doc/architecture/geometry-central-comparison.md) |
|
| **geometry-central comparison** — shared core, demarcation, adoption candidates, scientific added value | [doc/architecture/geometry-central-comparison.md](doc/architecture/geometry-central-comparison.md) |
|
||||||
| **Design decisions** — key architectural choices + rationale | [doc/architecture/design-decisions.md](doc/architecture/design-decisions.md) |
|
| **Design decisions** — key architectural choices + rationale | [doc/architecture/design-decisions.md](doc/architecture/design-decisions.md) |
|
||||||
| **Project structure** — directory tree + build targets | [doc/architecture/project-structure.md](doc/architecture/project-structure.md) |
|
| **Project structure** — directory tree + build targets | [doc/architecture/project-structure.md](doc/architecture/project-structure.md) |
|
||||||
|
| **CI / CD** — two-forge topology, runners, trigger keywords, mirror | [doc/architecture/ci-cd.md](doc/architecture/ci-cd.md) |
|
||||||
| **Discrete conformal theory** — mathematical background for collaborators | [doc/math/discrete-conformal-theory.md](doc/math/discrete-conformal-theory.md) |
|
| **Discrete conformal theory** — mathematical background for collaborators | [doc/math/discrete-conformal-theory.md](doc/math/discrete-conformal-theory.md) |
|
||||||
| **Validation** — known analytic results + how to verify them | [doc/math/validation.md](doc/math/validation.md) |
|
| **Validation** — known analytic results + how to verify them | [doc/math/validation.md](doc/math/validation.md) |
|
||||||
| **Validation protocol** — concrete commands with expected outputs | [doc/math/validation-protocol.md](doc/math/validation-protocol.md) |
|
| **Validation protocol** — concrete commands with expected outputs | [doc/math/validation-protocol.md](doc/math/validation-protocol.md) |
|
||||||
|
|||||||
@@ -374,8 +374,8 @@ static FaceAngles compute_face_angles(
|
|||||||
/// Per-face energy contribution U(f) before subtracting the θ·a and Θ·b terms.
|
/// Per-face energy contribution U(f) before subtracting the θ·a and Θ·b terms.
|
||||||
///
|
///
|
||||||
/// Supported configurations (faithful port of HyperIdealFunctional.java):
|
/// Supported configurations (faithful port of HyperIdealFunctional.java):
|
||||||
/// * All three vertices hyper-ideal (v?b = true) → Meyerhoff/Ushijima volume
|
/// * All three vertices hyper-ideal (v?b = true) → Ushijima 2006 volume
|
||||||
/// * Exactly one vertex ideal (v?b = false, other two true) → Kolpakov-Mednykh volume
|
/// * Exactly one vertex ideal (v?b = false, other two true) → Springborn 2008 volume
|
||||||
///
|
///
|
||||||
/// NOT supported — faces with two or three ideal vertices. The Java reference
|
/// NOT supported — faces with two or three ideal vertices. The Java reference
|
||||||
/// (HyperIdealFunctional.java lines 222-231) uses an if/else-if chain that
|
/// (HyperIdealFunctional.java lines 222-231) uses an if/else-if chain that
|
||||||
|
|||||||
@@ -16,7 +16,8 @@
|
|||||||
namespace conformallab {
|
namespace conformallab {
|
||||||
|
|
||||||
/// Volume of a generalized hyperbolic tetrahedron with dihedral
|
/// Volume of a generalized hyperbolic tetrahedron with dihedral
|
||||||
/// angles `A,…,F` via the Meyerhoff / Ushijima 2006 formula.
|
/// angles `A,…,F` via the Ushijima 2006 formula (DOI 10.1007/0-387-29555-0_13,
|
||||||
|
/// arxiv math/0309216). Note: sole author is Ushijima; "Meyerhoff" is not an author.
|
||||||
/// Same as Java `HyperIdealUtility.calculateTetrahedronVolume()`.
|
/// Same as Java `HyperIdealUtility.calculateTetrahedronVolume()`.
|
||||||
inline double calculateTetrahedronVolume(double A, double B, double C,
|
inline double calculateTetrahedronVolume(double A, double B, double C,
|
||||||
double D, double E, double F) {
|
double D, double E, double F) {
|
||||||
@@ -77,7 +78,7 @@ inline double calculateTetrahedronVolume(double A, double B, double C,
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Volume of a hyperideal tetrahedron with one ideal vertex at γ via
|
/// Volume of a hyperideal tetrahedron with one ideal vertex at γ via
|
||||||
/// the Kolpakov-Mednykh formula (arxiv math/0603097). Same as Java
|
/// the Springborn 2008 formula (arxiv math/0603097). Same as Java
|
||||||
/// `HyperIdealUtility.calculateTetrahedronVolumeWithIdealVertexAtGamma()`.
|
/// `HyperIdealUtility.calculateTetrahedronVolumeWithIdealVertexAtGamma()`.
|
||||||
inline double calculateTetrahedronVolumeWithIdealVertexAtGamma(
|
inline double calculateTetrahedronVolumeWithIdealVertexAtGamma(
|
||||||
double gamma1, double gamma2, double gamma3,
|
double gamma1, double gamma2, double gamma3,
|
||||||
|
|||||||
@@ -267,7 +267,7 @@ TEST(HyperIdealFunctional, MultiIdealGuard_AllThreeIdealVertices_Throws)
|
|||||||
TEST(HyperIdealFunctional, MultiIdealGuard_ExactlyOneIdeal_DoesNotThrow)
|
TEST(HyperIdealFunctional, MultiIdealGuard_ExactlyOneIdeal_DoesNotThrow)
|
||||||
{
|
{
|
||||||
// Exactly one ideal vertex per face must NOT throw — it is the supported
|
// Exactly one ideal vertex per face must NOT throw — it is the supported
|
||||||
// one-ideal-vertex configuration (Kolpakov-Mednykh formula).
|
// one-ideal-vertex configuration (Springborn 2008 formula).
|
||||||
auto mesh = make_triangle();
|
auto mesh = make_triangle();
|
||||||
auto maps = setup_hyper_ideal_maps(mesh);
|
auto maps = setup_hyper_ideal_maps(mesh);
|
||||||
|
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ Pure-math tests, only Eigen required. Covers Java utilities ported in Phase 1–
|
|||||||
| File | What it tests |
|
| File | What it tests |
|
||||||
|---|---|
|
|---|---|
|
||||||
| `test_clausen.cpp` | Clausen Cl₂, Lobachevsky Л, ImLi₂ — values at known points |
|
| `test_clausen.cpp` | Clausen Cl₂, Lobachevsky Л, ImLi₂ — values at known points |
|
||||||
| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Meyerhoff / Kolpakov–Mednykh) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) |
|
| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Ushijima 2006 / Springborn 2008) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) |
|
||||||
| `test_matrix_utility.cpp` | Matrix helpers |
|
| `test_matrix_utility.cpp` | Matrix helpers |
|
||||||
| `test_surface_curve_utility.cpp` | Surface curve utilities |
|
| `test_surface_curve_utility.cpp` | Surface curve utilities |
|
||||||
| `test_discrete_elliptic_utility.cpp` | Discrete elliptic functions |
|
| `test_discrete_elliptic_utility.cpp` | Discrete elliptic functions |
|
||||||
|
|||||||
110
doc/architecture/ci-cd.md
Normal file
110
doc/architecture/ci-cd.md
Normal file
@@ -0,0 +1,110 @@
|
|||||||
|
# CI / CD
|
||||||
|
|
||||||
|
Single source of truth for **how continuous integration is wired** across the
|
||||||
|
two forges this project lives on. If you add, move or rename a workflow, update
|
||||||
|
this page.
|
||||||
|
|
||||||
|
## TL;DR
|
||||||
|
|
||||||
|
| Forge | Remote | Role | CI system | Config | Runner |
|
||||||
|
|---|---|---|---|---|---|
|
||||||
|
| **eulernest Gitea** | `origin` | Authoritative gate (full test + quality suite) | Gitea Actions | `.gitea/workflows/` | self-hosted Raspberry Pi (ARM64), label `eulernest` |
|
||||||
|
| **Codeberg** | `codeberg` | Public mirror + public build badge | Woodpecker **and** Forgejo Actions | `.woodpecker.yml`, `.forgejo/workflows/` | Codeberg shared runners, label `docker` |
|
||||||
|
|
||||||
|
The two forges are connected by a one-way mirror: every push to `main` on
|
||||||
|
eulernest is force-mirrored to Codeberg (see
|
||||||
|
[Mirror](#mirror-eulernest--codeberg) below). Codeberg never pushes back.
|
||||||
|
|
||||||
|
Why two CI systems on Codeberg? They are independent and either may be enabled
|
||||||
|
per-repo; providing both means the public build status is green regardless of
|
||||||
|
which one the repo has switched on. They run the **same** `test-fast` build.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## eulernest Gitea (`origin`) — the real gate
|
||||||
|
|
||||||
|
Self-hosted Gitea with a single self-hosted runner: a Raspberry Pi (ARM64,
|
||||||
|
3–4 GB RAM). Because the runner is RAM-constrained, the heavy jobs are
|
||||||
|
**keyword-gated** (opt-in per commit) rather than run on every push.
|
||||||
|
|
||||||
|
All C++ jobs use the private image `git.eulernest.eu/conformallab/ci-cpp:latest`
|
||||||
|
(built from `.gitea/docker/Dockerfile.ci-cpp` — Ubuntu 22.04 + Node 20 + cmake +
|
||||||
|
build-essential + libboost-dev + doxygen).
|
||||||
|
|
||||||
|
### `.gitea/workflows/cpp-tests.yml`
|
||||||
|
|
||||||
|
| Job | Trigger | Memory cap | What it does |
|
||||||
|
|---|---|---|---|
|
||||||
|
| `test-fast` | every push to `main` / `claude/**` / `feature/**` / `review/**` + every PR | 800 MB | Pure-math suite (Clausen, ImLi₂, hyper-ideal). Serial build (`-j1`) to avoid OOM. Eigen vendored, GTest via FetchContent. |
|
||||||
|
| `test-cgal` | commit message contains **`/test-cgal`** | 2000 MB | Full CGAL suite via `LOW_MEMORY_BUILD` (`-O0`, no PCH, unity batch 1, `--no-keep-memory`). Then `check-test-counts.sh` + `try_it.sh` smoke test. |
|
||||||
|
| `quality-gates` | commit message contains **`/quality-gates`** | 600 MB | License headers, CGAL conventions, codespell, shellcheck, coverage (gate currently in report-only mode, `SKIP_COVERAGE_GATE=1`). |
|
||||||
|
|
||||||
|
> One keyword per commit — the Pi cannot sustain multiple Docker containers at
|
||||||
|
> once (`/ci-all` was removed for this reason). Example:
|
||||||
|
> `git commit -m "fix: correct angle formula /test-cgal"`.
|
||||||
|
|
||||||
|
### Other eulernest workflows
|
||||||
|
|
||||||
|
| File | Trigger | Purpose | Blocks merge? |
|
||||||
|
|---|---|---|---|
|
||||||
|
| `doc-build.yaml` | push to main branches + manual | Doxygen HTML + warning stats | No (`continue-on-error`) |
|
||||||
|
| `markdown-links.yml` | push + weekly cron (Mon 05:00 UTC) + manual | Link-rot check across docs | Yes on push |
|
||||||
|
| `doxygen-pages.yml` | manual only | Publish Doxygen HTML to Codeberg Pages (`tmoussa.codeberg.page/ConformalLabpp/`) | n/a |
|
||||||
|
| `perf-compile-time.yml` | manual only | Compile-time benchmark | n/a |
|
||||||
|
| `mirror-to-codeberg.yml` | push to `main` | Mirror all branches to Codeberg (see below) | n/a |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Codeberg (`codeberg`) — public mirror CI
|
||||||
|
|
||||||
|
Codeberg's shared runners **cannot** pull the private `ci-cpp` image and are not
|
||||||
|
the `eulernest` Pi, so the Codeberg configs differ from Gitea in exactly two
|
||||||
|
ways:
|
||||||
|
|
||||||
|
1. **Runner label** `docker` (Codeberg shared runners), not `eulernest`.
|
||||||
|
2. **Public base image**, with build tools `apt`-installed at run time:
|
||||||
|
- Woodpecker: `debian:bookworm`
|
||||||
|
- Forgejo Actions: `node:20-bookworm` (Node is needed by
|
||||||
|
`actions/checkout@v4`; cmake/g++/make are installed in the first step).
|
||||||
|
|
||||||
|
Both run **only** `test-fast` — the pure-math suite. No CGAL/Boost/Wayland, so
|
||||||
|
they are fast (< 2 min) and headless. Eigen is vendored, GoogleTest is fetched
|
||||||
|
at configure time (Codeberg runners have network). A failing build or any
|
||||||
|
failing `ctest` turns the public CI badge red.
|
||||||
|
|
||||||
|
| File | CI system | Enable via |
|
||||||
|
|---|---|---|
|
||||||
|
| `.woodpecker.yml` | Woodpecker | https://ci.codeberg.org → enable repo |
|
||||||
|
| `.forgejo/workflows/cpp-tests.yml` | Forgejo Actions | repo *Settings → Actions* (shared runner label `docker`) |
|
||||||
|
|
||||||
|
> These configs are committed in the repo and reach Codeberg through the mirror
|
||||||
|
> — they are not maintained separately on Codeberg.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Mirror (eulernest → Codeberg)
|
||||||
|
|
||||||
|
`.gitea/workflows/mirror-to-codeberg.yml` runs on every push to `main` and does
|
||||||
|
a `git push --mirror` from eulernest to
|
||||||
|
`codeberg.org/TMoussa/ConformalLabpp.git`. It uses two secrets:
|
||||||
|
|
||||||
|
- `MIRROR_TOKEN` — read access to the eulernest source repo.
|
||||||
|
- `CODEBERG_TOKEN` — push access to the Codeberg mirror.
|
||||||
|
|
||||||
|
The mirror is **one-way and authoritative-from-eulernest**: do not commit
|
||||||
|
directly on Codeberg, it will be overwritten on the next mirror run.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## The one rule
|
||||||
|
|
||||||
|
> **eulernest is the gate, Codeberg is the shop window.**
|
||||||
|
> Merge decisions are made on eulernest CI (full suite). Codeberg CI exists so
|
||||||
|
> the public repo also shows a green/red build status to outside readers.
|
||||||
|
|
||||||
|
## See also
|
||||||
|
|
||||||
|
- [dependencies.md](dependencies.md) — what each build mode requires.
|
||||||
|
- [project-structure.md](project-structure.md) — where the test targets live.
|
||||||
|
- [../api/tests.md](../api/tests.md) — per-suite test counts CI checks against.
|
||||||
|
- [../contributing.md](../contributing.md) — the git workflow that feeds CI.
|
||||||
@@ -14,7 +14,7 @@ ConformalLabpp/
|
|||||||
│ │ ├── constants.hpp # conformallab::PI, TWO_PI
|
│ │ ├── constants.hpp # conformallab::PI, TWO_PI
|
||||||
│ │ ├── clausen.hpp # Cl₂, Lobachevsky Л, ImLi₂
|
│ │ ├── clausen.hpp # Cl₂, Lobachevsky Л, ImLi₂
|
||||||
│ │ ├── hyper_ideal_geometry.hpp # ζ₁₃/₁₄/₁₅, lᵢⱼ, αᵢⱼ, σᵢ, σᵢⱼ
|
│ │ ├── hyper_ideal_geometry.hpp # ζ₁₃/₁₄/₁₅, lᵢⱼ, αᵢⱼ, σᵢ, σᵢⱼ
|
||||||
│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Meyerhoff / Kolpakov–Mednykh)
|
│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Ushijima 2006 / Springborn 2008)
|
||||||
│ │ ├── hyper_ideal_visualization_utility.hpp # Poincaré disk projection, circumcircle helpers
|
│ │ ├── hyper_ideal_visualization_utility.hpp # Poincaré disk projection, circumcircle helpers
|
||||||
│ │ ├── hyper_ideal_functional.hpp # HyperIdeal energy + gradient on ConformalMesh
|
│ │ ├── hyper_ideal_functional.hpp # HyperIdeal energy + gradient on ConformalMesh
|
||||||
│ │ ├── hyper_ideal_hessian.hpp # HyperIdeal Hessian (symmetric FD, Phase 9b: analytic)
|
│ │ ├── hyper_ideal_hessian.hpp # HyperIdeal Hessian (symmetric FD, Phase 9b: analytic)
|
||||||
|
|||||||
@@ -13,11 +13,12 @@ with English.
|
|||||||
## Git workflow
|
## Git workflow
|
||||||
|
|
||||||
- `main` is protected on `origin` (Gitea). Push to `dev`, then open a pull request.
|
- `main` is protected on `origin` (Gitea). Push to `dev`, then open a pull request.
|
||||||
- `codeberg/main` can be pushed to directly (public mirror, no CI).
|
- `codeberg/main` is the public mirror. It now also runs CI of its own
|
||||||
|
(Woodpecker + Forgejo Actions) — see [architecture/ci-cd.md](architecture/ci-cd.md).
|
||||||
- Both remotes must stay in sync after every significant change:
|
- Both remotes must stay in sync after every significant change:
|
||||||
```bash
|
```bash
|
||||||
git push origin HEAD:dev # triggers CI
|
git push origin HEAD:dev # triggers eulernest CI (full suite, keyword-gated CGAL)
|
||||||
git push codeberg main # updates public mirror
|
git push codeberg main # updates public mirror → triggers Codeberg CI (test-fast)
|
||||||
```
|
```
|
||||||
- Branch naming: `feature/<topic>`, `fix/<topic>`, `phase<N>-<topic>`
|
- Branch naming: `feature/<topic>`, `fix/<topic>`, `phase<N>-<topic>`
|
||||||
|
|
||||||
@@ -25,17 +26,30 @@ with English.
|
|||||||
|
|
||||||
## CI
|
## CI
|
||||||
|
|
||||||
Two jobs run on push to `dev`/`main` or on pull requests:
|
The project runs CI on **two forges**. Full topology, runners, images and
|
||||||
|
trigger keywords are documented in [architecture/ci-cd.md](architecture/ci-cd.md).
|
||||||
|
|
||||||
|
**eulernest Gitea** (`origin`, self-hosted Raspberry Pi / ARM64) — the
|
||||||
|
authoritative gate. On push to `dev`/`main` or a pull request:
|
||||||
|
|
||||||
| Job | What it tests | Trigger |
|
| Job | What it tests | Trigger |
|
||||||
|---|---|---|
|
|---|---|---|
|
||||||
| `test-fast` | pure-math tests, no Boost | all branches |
|
| `test-fast` | pure-math tests, no Boost | all branches |
|
||||||
| `test-cgal` | full CGAL test suite | `main`, `dev`, PRs only |
|
| `test-cgal` | full CGAL test suite | commit message contains `/test-cgal` |
|
||||||
|
| `quality-gates` | license / codespell / shellcheck / CGAL conventions | commit message contains `/quality-gates` |
|
||||||
|
|
||||||
A PR is ready to merge when both jobs pass.
|
A PR is ready to merge when `test-fast` (and, for CGAL-touching work,
|
||||||
|
`test-cgal`) pass. See `.gitea/workflows/cpp-tests.yml` and
|
||||||
|
`.gitea/docker/Dockerfile.ci-cpp`.
|
||||||
|
|
||||||
The runner is a self-hosted Raspberry Pi (ARM64). See `.gitea/workflows/cpp-tests.yml`
|
**Codeberg** (`codeberg`, public mirror, shared runners) — a lightweight
|
||||||
and `.gitea/docker/Dockerfile.ci-cpp`.
|
`test-fast` mirror so the public repo also shows a build status. Defined twice,
|
||||||
|
once per CI system Codeberg offers:
|
||||||
|
|
||||||
|
| File | CI system |
|
||||||
|
|---|---|
|
||||||
|
| `.woodpecker.yml` | Woodpecker CI (ci.codeberg.org) |
|
||||||
|
| `.forgejo/workflows/cpp-tests.yml` | Forgejo Actions |
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
|||||||
@@ -29,11 +29,11 @@ Java reference implementation: [github.com/varylab/conformallab](https://github.
|
|||||||
| Reference | Used in |
|
| Reference | Used in |
|
||||||
|---|---|
|
|---|---|
|
||||||
| ✅ **Springborn** — *Ideal Hyperbolic Polyhedra and Discrete Uniformization*, Discrete & Computational Geometry **64** (2020), pp. 63–108. DOI: [10.1007/s00454-019-00132-8](https://doi.org/10.1007/s00454-019-00132-8) | `hyper_ideal_geometry.hpp` — ζ₁₃/ζ₁₄/ζ₁₅ functions; `hyper_ideal_functional.hpp` |
|
| ✅ **Springborn** — *Ideal Hyperbolic Polyhedra and Discrete Uniformization*, Discrete & Computational Geometry **64** (2020), pp. 63–108. DOI: [10.1007/s00454-019-00132-8](https://doi.org/10.1007/s00454-019-00132-8) | `hyper_ideal_geometry.hpp` — ζ₁₃/ζ₁₄/ζ₁₅ functions; `hyper_ideal_functional.hpp` |
|
||||||
| ✅ **Kolpakov, Mednykh** — *A Formula for the Volume of a Hyperbolic Tetrahedron*, arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) (2006) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian) |
|
| ✅ **Springborn** — *A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*, J. Differential Geometry **78**(2) (2008), pp. 333–367. arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian). ⚠️ *Korrektur:* war fälschlich als „Kolpakov–Mednykh 2006" zitiert — dieses Autorenpaar hat 2006 kein gemeinsames Paper veröffentlicht. Die Java-Quelle verlinkt korrekt auf math/0603097 (= Springborn 2008); der falsche Autorenname wurde beim C++-Port hinzugefügt.* |
|
||||||
| ✅ **Meyerhoff, Ushijima** — *A Note on the Dirichlet Domain*, in: The Epstein Birthday Schrift (2006) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp` |
|
| ✅ **Ushijima** — *A Volume Formula for Generalised Hyperbolic Tetrahedra*, in: Prékopa, Molnár (eds.) *Non-Euclidean Geometries*, Mathematics and Its Applications vol. 581, Springer 2006. DOI: [10.1007/0-387-29555-0_13](https://doi.org/10.1007/0-387-29555-0_13). arXiv: [math/0309216](https://arxiv.org/abs/math/0309216) (2003) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp`. ⚠️ *Korrektur:* war fälschlich als „Meyerhoff, Ushijima — A Note on the Dirichlet Domain — The Epstein Birthday Schrift" zitiert. Meyerhoff ist kein Autor; Titel und Buch waren beide falsch. Die Java-Quelle verlinkt korrekt auf DOI 10.1007/0-387-29555-0_13 ohne Autorennamen. |
|
||||||
| **Pinkall, Polthier** — *Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics (1993) | `euclidean_hessian.hpp` — cotangent Laplacian |
|
| **Pinkall, Polthier** — *Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics **2**(1), pp. 15–36 (1993). DOI: [10.1080/10586458.1993.10504266](https://doi.org/10.1080/10586458.1993.10504266) | `euclidean_hessian.hpp` — cotangent Laplacian |
|
||||||
| **Bobenko, Springborn** — *Variational Principles for Circle Patterns and Koebe's Theorem*, Transactions AMS (2004) | Variational angle-sum framework underlying all three functionals |
|
| **Bobenko, Springborn** — *Variational Principles for Circle Patterns and Koebe's Theorem*, Trans. Amer. Math. Soc. **356**(2), pp. 659–689 (2004). arXiv: [math/0203250](https://arxiv.org/abs/math/0203250) | Variational angle-sum framework underlying all three functionals |
|
||||||
| **Luo** — *Combinatorial Yamabe Flow on Surfaces*, Communications in Contemporary Mathematics (2004) | Inversive-distance functional — **new research** in Phase 9a.2 (no Java original; implemented from this paper + Glickenstein 2011 + Bowers-Stephenson 2004) |
|
| **Luo** — *Combinatorial Yamabe Flow on Surfaces*, Commun. Contemp. Math. **6**(5), pp. 765–780 (2004). DOI: [10.1142/S0219199704001501](https://doi.org/10.1142/S0219199704001501). arXiv: [math/0306167](https://arxiv.org/abs/math/0306167) | Inversive-distance functional — **new research** in Phase 9a.2 (no Java original; implemented from this paper + Glickenstein 2011 + Bowers-Stephenson 2004) |
|
||||||
| **Bowers, Stephenson** — *Uniformizing dessins and Belyĭ maps via circle packing*, Memoirs of the AMS 170(805) (2004) | Introduces **inversive-distance circle packings** (used in Phase 9a.2). *Hinweis:* die zur Initialisierung benutzte Formel I_ij = (ℓ²−r_i²−r_j²)/(2 r_i r_j) ist die **klassische** inversive Distanz (vgl. Glickenstein §5.2: ℓ²=r_i²+r_j²+2r_ir_jη), nicht eine eigene „Bowers-Stephenson-Identität" — B–S liefern die Packungstheorie, nicht diese Formel. |
|
| **Bowers, Stephenson** — *Uniformizing dessins and Belyĭ maps via circle packing*, Memoirs of the AMS 170(805) (2004) | Introduces **inversive-distance circle packings** (used in Phase 9a.2). *Hinweis:* die zur Initialisierung benutzte Formel I_ij = (ℓ²−r_i²−r_j²)/(2 r_i r_j) ist die **klassische** inversive Distanz (vgl. Glickenstein §5.2: ℓ²=r_i²+r_j²+2r_ir_jη), nicht eine eigene „Bowers-Stephenson-Identität" — B–S liefern die Packungstheorie, nicht diese Formel. |
|
||||||
| **Glickenstein** — *Discrete conformal variations and scalar curvature on piecewise flat two- and three-dimensional manifolds*, J. Differential Geometry **87**(2) (2011), pp. 201–238 | Analytic Hessian of the inversive-distance functional. ⚠️ *Korrektur:* die Arbeit nummeriert Gleichungen **nicht** im Format „(4.6)" — der Verweis ist durch die **§5.2**-Parametrisierung ℓ²_ij = r²_i + r²_j + 2 r_i r_j η_ij zu ersetzen. Cross-correspondence: η_ij ist die inversive Distanz und entspricht dem Kosinus des **Supplements** des Schnittwinkels (Schnitt bei arccos(−η_ij)) — also I_ij = cos θ_e **nur bis aufs Vorzeichen/Supplement**, nicht wörtlich. |
|
| **Glickenstein** — *Discrete conformal variations and scalar curvature on piecewise flat two- and three-dimensional manifolds*, J. Differential Geometry **87**(2) (2011), pp. 201–238 | Analytic Hessian of the inversive-distance functional. ⚠️ *Korrektur:* die Arbeit nummeriert Gleichungen **nicht** im Format „(4.6)" — der Verweis ist durch die **§5.2**-Parametrisierung ℓ²_ij = r²_i + r²_j + 2 r_i r_j η_ij zu ersetzen. Cross-correspondence: η_ij ist die inversive Distanz und entspricht dem Kosinus des **Supplements** des Schnittwinkels (Schnitt bei arccos(−η_ij)) — also I_ij = cos θ_e **nur bis aufs Vorzeichen/Supplement**, nicht wörtlich. |
|
||||||
| ✅ **Bobenko, Pinkall, Springborn** — *Discrete conformal maps and ideal hyperbolic polyhedra*, Geometry & Topology **19**(4) (2015), pp. 2155–2215. arXiv: [1005.2698](https://arxiv.org/abs/1005.2698) (first posted 2010) | Face-based circle-packing functional (`CPEuclideanFunctional.java` → `cp_euclidean_functional.hpp`, Phase 9a.1) |
|
| ✅ **Bobenko, Pinkall, Springborn** — *Discrete conformal maps and ideal hyperbolic polyhedra*, Geometry & Topology **19**(4) (2015), pp. 2155–2215. arXiv: [1005.2698](https://arxiv.org/abs/1005.2698) (first posted 2010) | Face-based circle-packing functional (`CPEuclideanFunctional.java` → `cp_euclidean_functional.hpp`, Phase 9a.1) |
|
||||||
@@ -79,10 +79,10 @@ builds on this paper and augments it with Ptolemaic flips.
|
|||||||
|---|---|
|
|---|---|
|
||||||
| **Farkas, Kra** — *Riemann Surfaces*, Springer GTM 71 | Siegel period matrix, Teichmüller theory |
|
| **Farkas, Kra** — *Riemann Surfaces*, Springer GTM 71 | Siegel period matrix, Teichmüller theory |
|
||||||
| **Siegel** — *Topics in Complex Function Theory, Vol. 2*, Wiley | Siegel upper half-space H_g, Sp(2g,ℤ) reduction |
|
| **Siegel** — *Topics in Complex Function Theory, Vol. 2*, Wiley | Siegel upper half-space H_g, Sp(2g,ℤ) reduction |
|
||||||
| **Bobenko, Mercat, Schmies** — *Period Matrices of Polyhedral Surfaces*, in: Computational Approach to Riemann Surfaces (2011) | Discrete period matrices on polyhedral surfaces |
|
| **Bobenko, Mercat, Schmies** — *Conformal Structures and Period Matrices of Polyhedral Surfaces*, in: Bobenko, Klein (eds.) *Computational Approach to Riemann Surfaces*, Lecture Notes in Mathematics vol. 2013, Springer 2011, pp. 213–226. DOI: [10.1007/978-3-642-17413-1_7](https://doi.org/10.1007/978-3-642-17413-1_7) | Discrete period matrices on polyhedral surfaces |
|
||||||
| **Bobenko, Bücking** — *Convergence of discrete period matrices and discrete holomorphic integrals for ramified coverings of the Riemann sphere*, Math. Phys. Anal. Geom. **24**, Art. 23 (2021). DOI: [10.1007/s11040-021-09394-2](https://doi.org/10.1007/s11040-021-09394-2) | Phase 10b: discrete Siegel period matrix Ωᵢⱼ from cotangent-weighted integration **plus** the convergence result Ω_discrete → Ω_smooth under refinement (für ramified coverings) — belegt die Diskret-zu-glatt-Aussage in `novelty-statement.md §3.3. |
|
| **Bobenko, Bücking** — *Convergence of discrete period matrices and discrete holomorphic integrals for ramified coverings of the Riemann sphere*, Math. Phys. Anal. Geom. **24**, Art. 23 (2021). DOI: [10.1007/s11040-021-09394-2](https://doi.org/10.1007/s11040-021-09394-2) | Phase 10b: discrete Siegel period matrix Ωᵢⱼ from cotangent-weighted integration **plus** the convergence result Ω_discrete → Ω_smooth under refinement (für ramified coverings) — belegt die Diskret-zu-glatt-Aussage in `novelty-statement.md §3.3. |
|
||||||
| **Rivin, Schlenker** — *The Schläfli formula in Einstein manifolds with boundary*, Electron. Res. Announc. AMS **5** (1999), pp. 18–23 | Phase 9b-analytic: modern form of the Schläfli identity `2 dV = Σ aₑ dαₑ` for manifolds with boundary — the bilinear form used to derive the analytic HyperIdeal Hessian. |
|
| **Rivin, Schlenker** — *The Schläfli formula in Einstein manifolds with boundary*, Electron. Res. Announc. AMS **5** (1999), pp. 18–23 | Phase 9b-analytic: modern form of the Schläfli identity `2 dV = Σ aₑ dαₑ` for manifolds with boundary — the bilinear form used to derive the analytic HyperIdeal Hessian. |
|
||||||
| **Pinkall, Springborn** — *A discrete version of Liouville's theorem on conformal maps*, Geometriae Dedicata **214** (2021), pp. 389–398. arXiv: [1911.00966](https://arxiv.org/abs/1911.00966) | Phase 10b uniqueness: proves that the discrete conformal structure (and hence Ω) is a conformal invariant — the discrete Liouville theorem. Justifies that conformallab++ outputs a canonical representative. |
|
| **Pinkall, Springborn** — *A discrete version of Liouville's theorem on conformal maps*, Geometriae Dedicata **214** (2021), pp. 389–398. arXiv: [1911.00966](https://arxiv.org/abs/1911.00966) | Phase 10b uniqueness: proves that the discrete conformal structure (and hence Ω) is a conformal invariant — the discrete Liouville theorem. Justifies that conformallab++ outputs a canonical representative. |
|
||||||
| **Born, Bücking, Springborn** — *Quasiconformal distortion of projective transformations and discrete conformal maps*, arXiv: [1505.01341](https://arxiv.org/abs/1505.01341) (2015) | Phase 10c error analysis: quantifies how well the discrete H²/Γ embedding approximates the smooth hyperbolic metric; error bounds for the Fuchsian group representation. |
|
| **Born, Bücking, Springborn** — *Quasiconformal distortion of projective transformations and discrete conformal maps*, Discrete & Computational Geometry **57**(2), pp. 305–317 (2017). DOI: [10.1007/s00454-016-9854-7](https://doi.org/10.1007/s00454-016-9854-7). arXiv: [1505.01341](https://arxiv.org/abs/1505.01341) (preprint 2015) | Phase 10c error analysis: quantifies how well the discrete H²/Γ embedding approximates the smooth hyperbolic metric; error bounds for the Fuchsian group representation. |
|
||||||
| **Knöppel, Crane, Pinkall, Schröder** — *Stripe Patterns on Surfaces*, ACM SIGGRAPH (2015). DOI: [10.1145/2766890](https://doi.org/10.1145/2766890) | Phase 10a cross-validation: applies discrete holomorphic 1-forms to direction field design; geometry-central provides an independent C++ implementation to cross-check the Phase 10a `DiscreteHolomorphicFormUtility` port. |
|
| **Knöppel, Crane, Pinkall, Schröder** — *Stripe Patterns on Surfaces*, ACM Transactions on Graphics **34**(4), Article 39 (SIGGRAPH 2015). DOI: [10.1145/2767000](https://doi.org/10.1145/2767000). ⚠️ *Kein arXiv-Preprint* (arXiv:1502.06686 ist ein anderes Paper — Data-Driven Shape Analysis — und wurde aus dem papers/-Ordner entfernt). | Phase 10a cross-validation: applies discrete holomorphic 1-forms to direction field design; geometry-central provides an independent C++ implementation to cross-check the Phase 10a `DiscreteHolomorphicFormUtility` port. |
|
||||||
| **Sawhney, Crane** — *Boundary First Flattening*, ACM TOG **37**(1), Article 5 (2017). DOI: [10.1145/3132705](https://doi.org/10.1145/3132705) | Complementary method to Phase 9d: boundary-prescribed conformal flattening — user specifies boundary shape, interior conforms freely. Contrast: conformallab++ prescribes cone angles in the interior; BFF prescribes the boundary. Alternative approach for applications needing controlled boundary. |
|
| **Sawhney, Crane** — *Boundary First Flattening*, ACM TOG **37**(1), Article 5 (2017). DOI: [10.1145/3132705](https://doi.org/10.1145/3132705) | Complementary method to Phase 9d: boundary-prescribed conformal flattening — user specifies boundary shape, interior conforms freely. Contrast: conformallab++ prescribes cone angles in the interior; BFF prescribes the boundary. Alternative approach for applications needing controlled boundary. |
|
||||||
|
|||||||
@@ -59,7 +59,7 @@ Status: ✅ done · ⬜ open (actionable) · ⏸ deferred (intentional) · ⛔ b
|
|||||||
| V3 | input-val | 🟡 | ✅ | Sonnet | S1 |
|
| V3 | input-val | 🟡 | ✅ | Sonnet | S1 |
|
||||||
| C1 | test-cov | 🔴 | ✅ | Sonnet | S1 |
|
| C1 | test-cov | 🔴 | ✅ | Sonnet | S1 |
|
||||||
| N4, N6 | numerics | 🟡/🔵 | ✅ | Haiku | S1 |
|
| N4, N6 | numerics | 🟡/🔵 | ✅ | Haiku | S1 |
|
||||||
| M1, M2, M4 | math-cite | 🟡/🔵 | ✅ | Haiku | S1 |
|
| M1, M2, M4 | math-cite | 🟡/🔵 | ✅⚠️ | Haiku → re-fix 2026-06-04 | S1 + nachkorrigiert |
|
||||||
| C2, C3 | test-cov | 🔴 | ✅ | Sonnet | S1 |
|
| C2, C3 | test-cov | 🔴 | ✅ | Sonnet | S1 |
|
||||||
| V1, V2, V4 | input-val | 🟡 | ✅ | Sonnet | S1 |
|
| V1, V2, V4 | input-val | 🟡 | ✅ | Sonnet | S1 |
|
||||||
| I2, I3, I4 | test-cov | 🟡 | ✅ | Sonnet | S1 |
|
| I2, I3, I4 | test-cov | 🟡 | ✅ | Sonnet | S1 |
|
||||||
@@ -166,6 +166,42 @@ Gated by the author's reply on porting/relicensing rights.
|
|||||||
### 👤 Out of model scope
|
### 👤 Out of model scope
|
||||||
- **M5** — the large hand-derivations need a domain-expert prose review
|
- **M5** — the large hand-derivations need a domain-expert prose review
|
||||||
(the numerical results are already validated; the prose is not).
|
(the numerical results are already validated; the prose is not).
|
||||||
|
- **Alle Zitationen** — alle `references.md`-Einträge müssen von einem
|
||||||
|
Fachexperten manuell verifiziert werden (siehe Lektion unten).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## ⚠️ Lektion: KI-gestützte Citation-Audits können Fehler einführen
|
||||||
|
|
||||||
|
**Datum:** 2026-06-04
|
||||||
|
**Befund:** Die M1-Auflösung in S1 (Haiku, 2026-05-31) war selbst fehlerhaft:
|
||||||
|
|
||||||
|
- Der Haiku-Audit erkannte korrekt, dass `Kolpakov–Mednykh` in `references.md` fehlt
|
||||||
|
- Als „Fix" wurde die Zeile mit arXiv:math/0603097 ergänzt — aber **math/0603097 ist Springborn 2008**, nicht Kolpakov–Mednykh
|
||||||
|
- Das Autorenpaar „Kolpakov & Mednykh" hat **2006 kein gemeinsames Paper veröffentlicht** (früheste Zusammenarbeit: 2010, über Torusknoten, nicht Tetraedervolumen)
|
||||||
|
- Der falsche Autorenname entstand bereits beim Java→C++-Port; der Audit hat ihn zementiert statt korrigiert
|
||||||
|
|
||||||
|
**Nachkorrektur:** 2026-06-04, 7 Dateien korrigiert (Code-Kommentare, references.md, roadmap, architecture-doc, tests-doc, audit-doc).
|
||||||
|
|
||||||
|
**Konsequenz für das Projekt:**
|
||||||
|
|
||||||
|
> KI-Modelle können bei Citation-Audits plausibel klingende aber falsche
|
||||||
|
> Autoren/Jahres-Zuordnungen produzieren — besonders wenn die Primärquelle
|
||||||
|
> (Java-Code) nur einen Link ohne Autorennamen enthält.
|
||||||
|
|
||||||
|
**Empfehlung:**
|
||||||
|
|
||||||
|
Vor jeder öffentlichen Veröffentlichung / CGAL-Submission müssen **alle** Einträge
|
||||||
|
in `references.md` von einem **Fachexperten (Mensch)** gegen die tatsächlichen
|
||||||
|
Papiere verifiziert werden:
|
||||||
|
|
||||||
|
| Priorität | Was prüfen |
|
||||||
|
|---|---|
|
||||||
|
| 🔴 Hoch | Formeln in Code-Kommentaren (`hyper_ideal_utility.hpp`, `hyper_ideal_functional.hpp`) gegen die zitierten Paper |
|
||||||
|
| 🔴 Hoch | Ushijima 2006 (DOI 10.1007/0-387-29555-0_13) — arXiv math/0309216 — korrigiert: kein Meyerhoff, anderer Titel, anderes Buch |
|
||||||
|
| 🟡 Mittel | Ob Springborn 2008 (math/0603097) die 12-Term-Lobachevsky-Formel tatsächlich enthält |
|
||||||
|
| 🟡 Mittel | M3: post-2023 / arXiv-only Zitationen (Bowers-Bowers-Lutz 2026 etc.) |
|
||||||
|
| 🔵 Niedrig | Alle weiteren `references.md`-Einträge auf Titel/Jahr/DOI-Konsistenz |
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
|||||||
@@ -16,6 +16,16 @@ Status legend: 🔴 Critical · 🟡 Important · 🔵 Polish
|
|||||||
> future-dated/arXiv citations) **open** → S4; **M5** (prose derivation review)
|
> future-dated/arXiv citations) **open** → S4; **M5** (prose derivation review)
|
||||||
> needs a **domain expert** (out of model scope). See
|
> needs a **domain expert** (out of model scope). See
|
||||||
> [`finding-orchestration.md`](finding-orchestration.md).
|
> [`finding-orchestration.md`](finding-orchestration.md).
|
||||||
|
>
|
||||||
|
> **⚠️ M1 Nachkorrektur (2026-06-04):** Die ursprüngliche M1-Auflösung war selbst
|
||||||
|
> fehlerhaft — arXiv:math/0603097 ist **Springborn 2008** (*A variational principle
|
||||||
|
> for weighted Delaunay triangulations and hyperideal polyhedra*), nicht
|
||||||
|
> Kolpakov–Mednykh. Kolpakov und Mednykh haben 2006 kein gemeinsames Paper
|
||||||
|
> veröffentlicht (früheste Zusammenarbeit: 2010). Der falsche Autorenname wurde beim
|
||||||
|
> Java→C++-Port erfunden; die Java-Quelle verlinkt korrekt auf math/0603097 ohne
|
||||||
|
> Autorennamen. Korrekturen angewendet in: `hyper_ideal_utility.hpp`,
|
||||||
|
> `hyper_ideal_functional.hpp`, `test_hyper_ideal_functional.cpp`,
|
||||||
|
> `doc/math/references.md`.
|
||||||
|
|
||||||
> **Good news up front:** `doc/math/references.md` is unusually scholarly and already
|
> **Good news up front:** `doc/math/references.md` is unusually scholarly and already
|
||||||
> contains several *self-corrections* (the Glickenstein "eq. (4.6)" numbering fix →
|
> contains several *self-corrections* (the Glickenstein "eq. (4.6)" numbering fix →
|
||||||
@@ -58,8 +68,8 @@ load-bearing formula with no entry.
|
|||||||
|
|
||||||
### Fix
|
### Fix
|
||||||
Add a `references.md` row: Kolpakov, Mednykh — *(full title)*, arXiv `math/0603097`,
|
Add a `references.md` row: Kolpakov, Mednykh — *(full title)*, arXiv `math/0603097`,
|
||||||
mapped to `hyper_ideal_utility.hpp`. Likewise confirm the Meyerhoff / Ushijima 2006
|
mapped to `hyper_ideal_utility.hpp`. Ushijima 2006 (DOI 10.1007/0-387-29555-0_13, arXiv math/0309216) has a row —
|
||||||
volume reference (cited in code) has a row.
|
sole author is Ushijima; "Meyerhoff" is not a co-author (corrected 2026-06-04).
|
||||||
|
|
||||||
### Acceptance criteria
|
### Acceptance criteria
|
||||||
- Every formula cited inline in `code/include/` has a matching `references.md` entry.
|
- Every formula cited inline in `code/include/` has a matching `references.md` entry.
|
||||||
|
|||||||
@@ -145,10 +145,10 @@ The phase numbers match `doc/roadmap/phases.md`.
|
|||||||
### Hyper-ideal volume formulas for 2- and 3-ideal-vertex faces (Phase 9b+, 🔲 planned)
|
### Hyper-ideal volume formulas for 2- and 3-ideal-vertex faces (Phase 9b+, 🔲 planned)
|
||||||
|
|
||||||
* **Mathematical sources:**
|
* **Mathematical sources:**
|
||||||
- **Kolpakov, A. & Mednykh, A.** (2012). *Spherical structures on torus
|
- **Springborn, B.** (2008). *A variational principle for weighted Delaunay
|
||||||
knots and links.* Sibirsk. Mat. Zh. 53(3), 535–541 — see the earlier
|
triangulations and hyperideal polyhedra.* J. Differential Geometry **78**(2),
|
||||||
arXiv:math/0603097 for the one-ideal-vertex formula already implemented
|
333–367. arXiv:math/0603097 — the source of the one-ideal-vertex formula
|
||||||
as `calculateTetrahedronVolumeWithIdealVertexAtGamma`.
|
already implemented as `calculateTetrahedronVolumeWithIdealVertexAtGamma`.
|
||||||
- **Milnor, J.** (1982). *Hyperbolic geometry: The first 150 years.*
|
- **Milnor, J.** (1982). *Hyperbolic geometry: The first 150 years.*
|
||||||
Bull. Amer. Math. Soc. 6(1), 9–24. → Volume of an ideal tetrahedron
|
Bull. Amer. Math. Soc. 6(1), 9–24. → Volume of an ideal tetrahedron
|
||||||
via Clausen function; this is the all-ideal case with 4 ideal vertices.
|
via Clausen function; this is the all-ideal case with 4 ideal vertices.
|
||||||
@@ -175,10 +175,10 @@ The phase numbers match `doc/roadmap/phases.md`.
|
|||||||
|
|
||||||
* **Acceptance criteria:**
|
* **Acceptance criteria:**
|
||||||
- Identify the correct formula for a hyper-ideal tetrahedron with exactly
|
- Identify the correct formula for a hyper-ideal tetrahedron with exactly
|
||||||
2 ideal vertices from the literature (check Kolpakov-Mednykh generalisations
|
2 ideal vertices from the literature (check Springborn 2008 §3–4 generalisations
|
||||||
and Vinberg orthoscheme decomposition).
|
and Vinberg orthoscheme decomposition).
|
||||||
- Implement `calculateTetrahedronVolumeWithTwoIdealVertices(…)` analogous
|
- Implement `calculateTetrahedronVolumeWithTwoIdealVertices(…)` analogous
|
||||||
to the existing Kolpakov-Mednykh function.
|
to the existing Springborn 2008 one-ideal-vertex function.
|
||||||
- Implement `calculateTetrahedronVolumeWithThreeIdealVertices(…)` (one
|
- Implement `calculateTetrahedronVolumeWithThreeIdealVertices(…)` (one
|
||||||
hyper-ideal + three ideal = fully cusp-like case).
|
hyper-ideal + three ideal = fully cusp-like case).
|
||||||
- Replace the `throw std::logic_error` in `face_energy()` with the correct
|
- Replace the `throw std::logic_error` in `face_energy()` with the correct
|
||||||
|
|||||||
59
papers/MANUAL-DOWNLOAD.md
Normal file
59
papers/MANUAL-DOWNLOAD.md
Normal file
@@ -0,0 +1,59 @@
|
|||||||
|
# Manuell herunterzuladende Paper & Dissertationen
|
||||||
|
|
||||||
|
Diese Paper konnten nicht automatisch geladen werden (kein freies arXiv-Preprint,
|
||||||
|
hinter Verlag-Paywall, oder Buchkapitel).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Dissertationen (Open Access — TU Berlin Depositonce)
|
||||||
|
|
||||||
|
| Autor | Titel | Link |
|
||||||
|
|---|---|---|
|
||||||
|
| **Sechelmann 2016** | *Variational Methods for Discrete Surface Parameterization: Applications and Implementation* | [depositonce.tu-berlin.de/items/8e2988b2-d991-45b5-aad5-9fb7988f3b2f](https://depositonce.tu-berlin.de/items/8e2988b2-d991-45b5-aad5-9fb7988f3b2f) — CC BY-SA 4.0 |
|
||||||
|
| **Lutz 2024** | *Decorated Discrete Conformal Equivalence, Canonical Tessellations, and Polyhedral Realization* | [doi.org/10.14279/depositonce-20357](https://doi.org/10.14279/depositonce-20357) — Open Access |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Paper hinter Verlag-Paywall (ggf. über Institutional Access / Google Scholar)
|
||||||
|
|
||||||
|
| Autor(en) | Titel | Venue | DOI / Link |
|
||||||
|
|---|---|---|---|
|
||||||
|
| **Ushijima** ⚠️ (Einzelautor — kein Meyerhoff!) | *A Volume Formula for Generalised Hyperbolic Tetrahedra* | Prékopa, Molnár (eds.) *Non-Euclidean Geometries*, Springer 2006 | [doi.org/10.1007/0-387-29555-0_13](https://doi.org/10.1007/0-387-29555-0_13) · arXiv [math/0309216](https://arxiv.org/abs/math/0309216) (arXiv gibt 500 für alte math/-Preprints — manuell laden) |
|
||||||
|
| **Pinkall, Polthier** | *Computing Discrete Minimal Surfaces and Their Conjugates* | Experimental Mathematics **2**(1), 1993 | [projecteuclid.org/euclid.em/1062620735](https://projecteuclid.org/euclid.em/1062620735) |
|
||||||
|
| **Bowers, Stephenson** | *Uniformizing dessins and Belyĭ maps via circle packing* | Memoirs AMS **170**(805), 2004 | [ams.org/books/memo/0805](https://bookstore.ams.org/memo-170-805) |
|
||||||
|
| **Erickson, Whittlesey** | *Greedy Optimal Homotopy and Homology Generators* | SODA 2005 | [dl.acm.org/doi/10.5555/1070432.1070581](https://dl.acm.org/doi/10.5555/1070432.1070581) |
|
||||||
|
| **Desbrun, Kanso, Tong** | *Discrete Differential Forms for Computational Modeling* | SIGGRAPH Course Notes 2006 | [dl.acm.org/doi/10.1145/1185657.1185665](https://dl.acm.org/doi/10.1145/1185657.1185665) |
|
||||||
|
| **Soliman, Slepčev, Crane** | *Optimal Cone Singularities for Conformal Flattening* | ACM TOG **37**(4), 2018 | [doi.org/10.1145/3197517.3201367](https://doi.org/10.1145/3197517.3201367) — Autorenseite: [cs.cmu.edu/~kmcrane](https://www.cs.cmu.edu/~kmcrane/Projects/OptimalCones/index.html) |
|
||||||
|
| **Gillespie, Springborn, Crane** | *Discrete Conformal Equivalence of Polyhedral Surfaces* | ACM TOG / SIGGRAPH 2021 | [doi.org/10.1145/3450626.3459763](https://doi.org/10.1145/3450626.3459763) — Autorenseite: [markjgillespie.com/Research/CEPS](https://markjgillespie.com/Research/CEPS/index.html) |
|
||||||
|
| **Sharp, Soliman, Crane** | *Navigating Intrinsic Triangulations* | ACM TOG / SIGGRAPH 2019 | [doi.org/10.1145/3306346.3323042](https://doi.org/10.1145/3306346.3323042) — Autorenseite: [cs.cmu.edu/~kmcrane](https://www.cs.cmu.edu/~kmcrane/Projects/NavigatingIntrinsicTriangulations/index.html) |
|
||||||
|
| **Alexa, Wardetzky** | *Discrete Laplacians on General Polygonal Meshes* | ACM SIGGRAPH 2011 | [doi.org/10.1145/1964921.1964997](https://doi.org/10.1145/1964921.1964997) |
|
||||||
|
| **Bunge, Herholz, Kazhdan, Botsch** | *Polygon Laplacian Made Simple* | CGF **39**(2), 2020 | [doi.org/10.1111/cgf.13931](https://doi.org/10.1111/cgf.13931) |
|
||||||
|
| **Rivin, Schlenker** | *The Schläfli formula in Einstein manifolds with boundary* | Electron. Res. Announc. AMS **5**, 1999 | [ams.org/era/1999-05-03](https://www.ams.org/era/1999-05-03) — wahrscheinlich frei |
|
||||||
|
| **Bobenko, Mercat, Schmies** | *Period Matrices of Polyhedral Surfaces* | Computational Approach to Riemann Surfaces, Springer 2011 | [doi.org/10.1007/978-3-642-17413-1](https://doi.org/10.1007/978-3-642-17413-1) — Buchkapitel |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Bücher (Bibliothek / Kauf)
|
||||||
|
|
||||||
|
| Autor(en) | Titel | Verlag |
|
||||||
|
|---|---|---|
|
||||||
|
| **Farkas, Kra** | *Riemann Surfaces* (2. Aufl.) | Springer GTM 71 |
|
||||||
|
| **Siegel** | *Topics in Complex Function Theory, Vol. 2* | Wiley |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Hinweis: Autorenseiten oft freier als DOI
|
||||||
|
|
||||||
|
Für die SIGGRAPH-Paper (Gillespie 2021, Sharp 2019, Soliman 2018) gibt es auf den
|
||||||
|
CMU/Autorenseiten oft direkte PDF-Downloads ohne Paywall.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Fehler in references.md (zu korrigieren)
|
||||||
|
|
||||||
|
> **arXiv:math/0603097** ist in `references.md` fälschlicherweise **Kolpakov–Mednykh**
|
||||||
|
> zugewiesen. Tatsächlich ist das der **Springborn 2008** Artikel
|
||||||
|
> (*A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*).
|
||||||
|
> Das korrekte Kolpakov–Mednykh Paper hat vermutlich kein öffentliches arXiv-Preprint.
|
||||||
|
> → Springborn 2008 wurde korrekt als `springborn-2008-weighted-delaunay-hyperideal.pdf`
|
||||||
|
> gespeichert; references.md muss angepasst werden.
|
||||||
Reference in New Issue
Block a user