conformallab/ConformalLabpp
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

refactor(api): consistent naming for spherical + hyper-ideal helpers (A1–A3) #36

Merged
user2595 merged 1 commits from refactor/api-naming-a1-a3 into main 2026-05-31 17:43:43 +00:00
Conversation 0 Commits 1 Files Changed 16 +127 -90
user2595 commented 2026-05-31 08:37:31 +00:00
Owner
Copy Link

Standardizes the low-level free-function API on <verb>_<geom>_<rest>, matching the already-consistent setup_<geom>_maps. Implements findings A1–A3 from doc/reviewer/api-performance-audit-2026-05-31.md.

Renames (old names kept as [[deprecated]] inline aliases for one release; all internal call sites migrated):

Old New
assign_vertex_dof_indices (spherical, 2 overloads) assign_spherical_vertex_dof_indices
assign_all_spherical_dof_indices assign_spherical_all_dof_indices
assign_all_dof_indices (hyper-ideal) assign_hyper_ideal_all_dof_indices
compute_lambda0_from_mesh (spherical) compute_spherical_lambda0_from_mesh
gradient_check (hyper-ideal) gradient_check_hyper_ideal

Deferred: A4/A5 touch the public CGAL API and wait on the license/provenance decision (CGAL audit G0/G1).

Verified: 277/277 CGAL tests pass, no deprecation warnings (all call sites migrated).

Standardizes the low-level free-function API on `<verb>_<geom>_<rest>`, matching the already-consistent `setup_<geom>_maps`. Implements findings **A1–A3** from `doc/reviewer/api-performance-audit-2026-05-31.md`. **Renames** (old names kept as `[[deprecated]]` inline aliases for one release; all internal call sites migrated): | Old | New | |---|---| | `assign_vertex_dof_indices` (spherical, 2 overloads) | `assign_spherical_vertex_dof_indices` | | `assign_all_spherical_dof_indices` | `assign_spherical_all_dof_indices` | | `assign_all_dof_indices` (hyper-ideal) | `assign_hyper_ideal_all_dof_indices` | | `compute_lambda0_from_mesh` (spherical) | `compute_spherical_lambda0_from_mesh` | | `gradient_check` (hyper-ideal) | `gradient_check_hyper_ideal` | **Deferred:** A4/A5 touch the public CGAL API and wait on the license/provenance decision (CGAL audit G0/G1). **Verified:** 277/277 CGAL tests pass, no deprecation warnings (all call sites migrated).
user2595 added 1 commit 2026-05-31 08:37:32 +00:00
refactor(api): consistent naming for spherical + hyper-ideal helpers (A1–A3)
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 2m20s
Details
C++ Tests / quality-gates (pull_request) Has been skipped
Details
C++ Tests / test-cgal (pull_request) Has been skipped
Details
65fc8ac816 
Standardize the low-level free-function API on <verb>_<geom>_<rest>,
matching the already-consistent setup_<geom>_maps. Old names kept as
[[deprecated]] inline aliases for one release; all internal call sites
migrated.

Renames:
  assign_vertex_dof_indices      -> assign_spherical_vertex_dof_indices
  assign_all_spherical_dof_indices -> assign_spherical_all_dof_indices
  assign_all_dof_indices         -> assign_hyper_ideal_all_dof_indices
  compute_lambda0_from_mesh      -> compute_spherical_lambda0_from_mesh
  gradient_check                 -> gradient_check_hyper_ideal

A4/A5 (public CGAL API) intentionally deferred pending the license/
provenance decision (see CGAL submission audit G0/G1).

Verified: 277/277 CGAL tests pass, no deprecation warnings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
user2595 merged commit 505dd4b0a5 into main 2026-05-31 17:43:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
carl.lutz user2595
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: conformallab/ConformalLabpp#36
No description provided.
Delete Branch "refactor/api-naming-a1-a3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?