conformallab/ConformalLabpp
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(citations): correct Kolpakov-Mednykh misattribution → Springborn 2008 #48

Closed
user2595 wants to merge 6 commits from fix/citation-springborn-2008-attribution into main
pull from: fix/citation-springborn-2008-attribution
merge into: conformallab:main
Conversation 1 Commits 6 Files Changed 17 +414 -37
user2595 commented 2026-06-04 20:08:23 +00:00
Owner
Copy Link

Springborn 2008 (math/0603097) war falsch als Kolpakov-Mednykh 2006 zitiert. 7 Dateien korrigiert + lesson-learned doc. Siehe Commit-Message für Details.

Springborn 2008 (math/0603097) war falsch als Kolpakov-Mednykh 2006 zitiert. 7 Dateien korrigiert + lesson-learned doc. Siehe Commit-Message für Details.
user2595 added 3 commits 2026-06-04 20:08:24 +00:00
ci: add Codeberg CI (Woodpecker + Forgejo) and document CI/CD topology
All checks were successful
C++ Tests / test-fast (push) Successful in 3m8s
Details
C++ Tests / quality-gates (push) Has been skipped
Details
API Docs / doc-build (push) Has been skipped
Details
Markdown link check / check (push) Has been skipped
Details
C++ Tests / test-cgal (push) Has been skipped
Details
a3a7c2228f 
Add a lightweight test-fast pipeline for the public Codeberg mirror so it
shows a build status, defined for both CI systems Codeberg offers:
- .woodpecker.yml            (Woodpecker, debian:bookworm)
- .forgejo/workflows/        (Forgejo Actions, node:20-bookworm, runner label docker)

Both run the pure-math suite only (Eigen vendored, GTest via FetchContent;
no CGAL/Boost), using public images and the docker runner label since the
private eulernest ci-cpp image and Pi runner are unreachable from Codeberg.

Docs:
- new doc/architecture/ci-cd.md: two-forge topology, runners, trigger
  keywords, mirror mechanism.
- fix stale "codeberg/main ... no CI" claim in contributing.md and bring
  the CI table up to date.
- link the new doc from the README doc index.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
chore: expand and clean up .claude/settings.json
All checks were successful
C++ Tests / test-fast (push) Successful in 2m10s
Details
C++ Tests / quality-gates (push) Has been skipped
Details
API Docs / doc-build (push) Has been skipped
Details
Markdown link check / check (push) Has been skipped
Details
C++ Tests / test-cgal (push) Has been skipped
Details
51cbfdfd54 
- broaden the permission allowlist (git porcelain, file utils, curl)
- "preferences" key (tmux split panes, markdown responses)
- tighten the deny list (force-push, git clean, destructive rm)
- keep only permissions relevant to this repo (generic `bash scripts/*`
  covers its own scripts; no jetson/agent-swarm template entries)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fix(citations): correct Kolpakov-Mednykh misattribution → Springborn 2008
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 2m13s
Details
C++ Tests / quality-gates (pull_request) Has been skipped
Details
C++ Tests / test-cgal (pull_request) Has been skipped
Details
ef3c448f4d 
arXiv:math/0603097 is Springborn 2008 ("A variational principle for weighted
Delaunay triangulations and hyperideal polyhedra"), not a Kolpakov-Mednykh paper.
The author pair Kolpakov & Mednykh has no joint publication from 2006; their
earliest collaboration is arXiv:1008.0312 (2010, on torus knots, unrelated).

The wrong author name was introduced during the Java→C++ port — the Java source
correctly links to math/0603097 without naming the authors; whoever ported it
invented "Kolpakov-Mednykh". The S1 citation audit (2026-05-31) then cemented
the error by adding the incorrect row to references.md.

Files corrected (7):
- code/include/hyper_ideal_utility.hpp
- code/include/hyper_ideal_functional.hpp
- code/tests/cgal/test_hyper_ideal_functional.cpp
- doc/math/references.md
- doc/roadmap/research-track.md
- doc/architecture/project-structure.md
- doc/api/tests.md

Also:
- doc/reviewer/math-derivation-citation-audit-2026-05-31.md: M1 post-correction noted
- doc/reviewer/finding-orchestration.md: lesson-learned section added (AI citation
  audits can introduce plausible-but-wrong attributions; human expert review required
  before CGAL submission)
- papers/MANUAL-DOWNLOAD.md: overview of papers requiring manual download (paywalled
  journals, TU Berlin theses, books)
- .gitignore: papers/*.pdf excluded (downloaded arXiv PDFs, not tracked)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
user2595 added 2 commits 2026-06-07 09:45:29 +00:00
fix(citations): correct Meyerhoff/Ushijima misattribution 70b94b9ead 
DOI 10.1007/0-387-29555-0_13 is Ushijima (sole author) —
"A Volume Formula for Generalised Hyperbolic Tetrahedra",
in: Prékopa & Molnár (eds.), Non-Euclidean Geometries,
Springer 2006. arXiv: math/0309216.

The references.md entry was wrong on all three counts:
  - Author:  "Meyerhoff, Ushijima" → Ushijima only
  - Title:   "A Note on the Dirichlet Domain" → entirely different title
  - Book:    "The Epstein Birthday Schrift" → Non-Euclidean Geometries

Same error pattern as the Kolpakov-Mednykh fix: the Java source
links only to a DOI without naming authors; a wrong name was
invented during the C++ port.

Files corrected: hyper_ideal_utility.hpp, hyper_ideal_functional.hpp,
references.md, tests.md, project-structure.md, finding-orchestration.md,
math-derivation-citation-audit.md, MANUAL-DOWNLOAD.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix(citations): systematic audit — 6 corrections in references.md
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 3m44s
Details
C++ Tests / quality-gates (pull_request) Has been skipped
Details
C++ Tests / test-cgal (pull_request) Has been skipped
Details
b37a7b12a7 
Findings from full citation audit of all 34 references.md entries:

CRITICAL:
- Knöppel et al. 2015 "Stripe Patterns": arXiv 1502.06686 was a completely
  different paper (Data-Driven Shape Analysis by Xu et al.) — removed from
  papers/. Correct DOI is 10.1145/2767000, not 10.1145/2766890. No arXiv
  preprint exists for this paper.

ERRORS:
- Born, Bücking, Springborn: published 2017 in DCG 57(2) pp. 305–317
  (DOI 10.1007/s00454-016-9854-7); arXiv 2015 was preprint only
- Bobenko, Mercat, Schmies: short title; full title is
  "Conformal Structures and Period Matrices of Polyhedral Surfaces";
  editors Bobenko & Klein (not generic "Computational Approach" book ref);
  pp. 213–226, DOI 10.1007/978-3-642-17413-1_7

COMPLETIONS (missing vol/pages added):
- Pinkall, Polthier 1993: vol. 2(1), pp. 15–36, DOI added
- Bobenko, Springborn 2004: Trans. AMS 356(2), pp. 659–689, arXiv added
- Luo 2004: Commun. Contemp. Math. 6(5), pp. 765–780, DOI + arXiv added

Verified ✅ (no changes needed, 28/34 entries):
Sechelmann 2016, Springborn 2020/2008, Ushijima 2006, Bowers-Stephenson 2004,
Glickenstein 2011, BPS 2015, Schläfli 1858, Erickson-Whittlesey 2005,
Bobenko-Springborn 2007, Desbrun-Kanso-Tong 2006, Soliman et al. 2018,
all Bobenko-Lutz papers, Lutz 2023/2024, Bowers-Bowers-Lutz 2026,
Alexa-Wardetzky 2011, Bunge et al. 2020, de Goes et al. 2020,
Gillespie-Springborn-Crane 2021, Sharp-Soliman-Crane 2019, Farkas-Kra,
Siegel, Bobenko-Bücking 2021, Rivin-Schlenker 1999, Pinkall-Springborn 2021,
Sawhney-Crane 2017

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
user2595 added 1 commit 2026-06-07 09:46:12 +00:00
chore(gitignore): exclude derived paper artifacts (txt/mmd/figures)
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 2m46s
Details
C++ Tests / quality-gates (pull_request) Has been skipped
Details
C++ Tests / test-cgal (pull_request) Has been skipped
Details
3df6e7a576 
Extracted text (pdftext), nougat mmd output and figure dumps are
regenerable from the source PDFs — keep them out of the repo like the
PDFs themselves. Also excludes the accidental facebook/ nougat model
cache (958 MB).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
user2595 closed this pull request 2026-06-07 10:03:40 +00:00
user2595 commented 2026-06-07 10:03:58 +00:00
Author
Owner
Copy Link

Geschlossen zugunsten von #49. Review-Gate (Opus, kalt) ergab CHANGES-REQUESTED: dieser Branch war von feature/codeberg-ci abgezweigt und schleppte CI-Commits mit. #49 enthaelt dieselben Citation-Fixes sauber auf main rebased (cherry-pick), plus NIT-1-Fix in MANUAL-DOWNLOAD.md.

Geschlossen zugunsten von #49. Review-Gate (Opus, kalt) ergab CHANGES-REQUESTED: dieser Branch war von feature/codeberg-ci abgezweigt und schleppte CI-Commits mit. #49 enthaelt dieselben Citation-Fixes sauber auf main rebased (cherry-pick), plus NIT-1-Fix in MANUAL-DOWNLOAD.md.
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 2m46s
Details
C++ Tests / quality-gates (pull_request) Has been skipped
Details
C++ Tests / test-cgal (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
carl.lutz user2595
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: conformallab/ConformalLabpp#48
No description provided.
Delete Branch "fix/citation-springborn-2008-attribution"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?