Completes the work begun in the previous commit on this branch. Every
public symbol under code/include/ now carries a brief Doxygen comment
(0 undocumented per scripts/doxygen-coverage.sh, with the `detail::`
implementation namespaces excluded as before).
Trajectory on this branch:
start (after Doxyfile fix): 24.0 % (165 / 437 in the no-detail set
was 105 / 437 when detail counted)
after PR #17 base commit : 42.4 % (165 / 396)
this commit : 100.0 % (396 / 396)
Files touched (all .hpp / .h headers under code/include/):
* cgal/Conformal_map_traits.h
* clausen.hpp, conformal_mesh.hpp, constants.hpp (already docd)
* cp_euclidean_functional.hpp, cut_graph.hpp, discrete_elliptic_utility.hpp
* euclidean_functional.hpp, euclidean_geometry.hpp, euclidean_hessian.hpp
* fundamental_domain.hpp, gauss_bonnet.hpp
* hyper_ideal_{functional,geometry,hessian,utility,visualization_utility}.hpp
* inversive_distance_functional.hpp, layout.hpp
* matrix_utility.hpp, mesh_builder.hpp, mesh_io.hpp
* newton_solver.hpp, p2_utility.hpp, period_matrix.hpp, projective_math.hpp
* serialization.hpp, spherical_functional.hpp, spherical_geometry.hpp
* spherical_hessian.hpp, viewer_utils.h
CI:
.gitea/workflows/doxygen-pages.yml now enforces
`scripts/doxygen-coverage.sh --threshold 100`, so any future regression
(a new public function landed without a `///` brief) fails the build
before the Doxygen HTML is published to Codeberg Pages.
Doxygen warnings remain at 0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
85 lines
3.2 KiB
C++
85 lines
3.2 KiB
C++
#pragma once
|
||
// euclidean_geometry.hpp
|
||
//
|
||
// Corner-angle formula for Euclidean triangles in the discrete conformal
|
||
// (log-length) parametrisation.
|
||
//
|
||
// Ported from de.varylab.discreteconformal.functional.EuclideanCyclicFunctional.
|
||
//
|
||
// In the discrete conformal parametrisation a Euclidean triangle is described by
|
||
// its three effective log-lengths Λ̃_ij = λ°_ij + u_i + u_j (+ edge DOF).
|
||
// The corresponding side lengths are l_ij = exp(Λ̃_ij / 2).
|
||
//
|
||
// Vertex ordering convention (matches EuclideanCyclicFunctional.java):
|
||
// v1 is opposite edge l23, v2 is opposite l31, v3 is opposite l12.
|
||
//
|
||
// t-value trick (Springborn 2008 §3):
|
||
// t12 = −l12 + l23 + l31 = 2(s − l12)
|
||
// t23 = +l12 − l23 + l31 = 2(s − l23)
|
||
// t31 = +l12 + l23 − l31 = 2(s − l31)
|
||
// denom = sqrt(t12 · t23 · t31 · l123) = 4 · Area
|
||
//
|
||
// α_v = 2 · atan2( product of t-values adjacent to v, denom )
|
||
//
|
||
// The centering trick (l_ij ← exp((Λ̃_ij − 2·μ)/2), μ = (Λ̃12+Λ̃23+Λ̃31)/6)
|
||
// rescales all three sides by the same factor, leaving angles unchanged but
|
||
// keeping the arguments of exp in a safe numerical range.
|
||
|
||
#include <cmath>
|
||
|
||
namespace conformallab {
|
||
|
||
/// Interior corner angles of a Euclidean triangle.
|
||
struct EuclideanFaceAngles {
|
||
double alpha1; ///< Corner angle at v₁ (opposite l₂₃).
|
||
double alpha2; ///< Corner angle at v₂ (opposite l₃₁).
|
||
double alpha3; ///< Corner angle at v₃ (opposite l₁₂).
|
||
bool valid; ///< `false` when the triangle is degenerate.
|
||
};
|
||
|
||
/// Compute the corner angles of a Euclidean triangle from its three
|
||
/// side lengths. Returns `valid = false` when the triangle inequality
|
||
/// is violated.
|
||
inline EuclideanFaceAngles euclidean_angles_from_lengths(
|
||
double l12, double l23, double l31)
|
||
{
|
||
const double t12 = -l12 + l23 + l31; // 2*(s − l12)
|
||
const double t23 = +l12 - l23 + l31; // 2*(s − l23)
|
||
const double t31 = +l12 + l23 - l31; // 2*(s − l31)
|
||
|
||
if (t12 <= 0.0 || t23 <= 0.0 || t31 <= 0.0)
|
||
return {0.0, 0.0, 0.0, false};
|
||
|
||
const double l123 = l12 + l23 + l31;
|
||
const double denom2 = t12 * t23 * t31 * l123; // = (4·Area)²
|
||
if (denom2 <= 0.0)
|
||
return {0.0, 0.0, 0.0, false};
|
||
|
||
const double denom = std::sqrt(denom2);
|
||
|
||
// α at v1 (opposite l23): adjacent t-values are t12 and t31
|
||
// α at v2 (opposite l31): adjacent t-values are t12 and t23
|
||
// α at v3 (opposite l12): adjacent t-values are t23 and t31
|
||
return {
|
||
2.0 * std::atan2(t12 * t31, denom),
|
||
2.0 * std::atan2(t12 * t23, denom),
|
||
2.0 * std::atan2(t23 * t31, denom),
|
||
true
|
||
};
|
||
}
|
||
|
||
/// Compute the corner angles of a Euclidean triangle from its three
|
||
/// effective log-lengths `Λ̃ᵢⱼ`. Internally centres lengths so that
|
||
/// `l₁₂·l₂₃·l₃₁ = 1` to avoid float overflow for large `|Λ̃|`.
|
||
inline EuclideanFaceAngles euclidean_angles(
|
||
double lam12, double lam23, double lam31)
|
||
{
|
||
const double mu = (lam12 + lam23 + lam31) / 6.0;
|
||
const double l12 = std::exp((lam12 - 2.0 * mu) * 0.5);
|
||
const double l23 = std::exp((lam23 - 2.0 * mu) * 0.5);
|
||
const double l31 = std::exp((lam31 - 2.0 * mu) * 0.5);
|
||
return euclidean_angles_from_lengths(l12, l23, l31);
|
||
}
|
||
|
||
} // namespace conformallab
|