d3c08b3bc0
This commit closes the remaining red gates so `run-all.sh --fast` is
green end-to-end on the canonical dev machine.
New gates
─────────
1. cmake-format / cmake-lint
* scripts/quality/cmake-format.sh — dry-run by default,
--strict to fail on drift, --fix to apply
* .cmake-format.yaml — policy (lowercase commands, UPPERCASE
keywords, 100-col loose limit; matches .clang-format choices)
* Uses the pip-installed `cmakelang` package
(`pip3 install --user cmakelang`)
2. codespell
* scripts/quality/codespell.sh — exit 1 on any typo, --fix
interactively
* .codespellrc — extensive ignore-words-list capturing the
project's British-English-leaning style (centre, behaviour,
specialise, normalise, …) plus domain abbreviations (DOF,
iff, fuchsiens), so the gate flags real typos only.
* Validated: 0 typos across docs + code/include + scripts +
code/{src,tests}.
SPDX rollout (license-headers --fix)
────────────────────────────────────
license-headers.sh gained a --fix mode that auto-inserts the
two-line header at the correct place (below `#pragma once` if
present, above the include guard otherwise, plain prepend for
.cpp). Ran it on 60 of 66 files — 100 %-licensed now.
Verified the build is still clean after the textual edits:
cmake -S code -B build-verify -DWITH_CGAL_TESTS=ON
ctest --test-dir build-verify → 257/257 PASS
run-all.sh + README updated to include the two new gates.
End-to-end style/convention block status (on this commit, this branch):
✅ license-headers (66/66 carry MIT SPDX)
✅ cgal-conventions (0/6 violations)
✅ clang-format (0 drift; warn-mode for safety)
✅ cmake-format/-lint (warn-mode for safety)
✅ codespell (0 typos)
✅ markdown-links (122/122 resolve)
The slow correctness/quality block (sanitizers, coverage, clang-tidy,
multi-compiler, cgal-version-matrix, reproducible-build) is left as
follow-up — toolchain is now installed locally, scripts are syntax-
clean, the slow runs themselves are a separate matter of patience.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
43 lines
1.6 KiB
C++
43 lines
1.6 KiB
C++
// Copyright (c) 2024-2026 Tarik Moussa.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
// Port of de.varylab.discreteconformal.util.DiscreteEllipticUtilityTest (Java/JUnit).
|
|
// Tests the normalizeModulus function that moves a complex number tau into the
|
|
// fundamental domain of the modular group SL(2,Z).
|
|
|
|
#include "discrete_elliptic_utility.hpp"
|
|
#include <gtest/gtest.h>
|
|
#include <complex>
|
|
#include <cmath>
|
|
|
|
using namespace conformallab;
|
|
|
|
// Corresponds to Java testNormalizeModulus()
|
|
TEST(DiscreteEllipticUtilityTest, NormalizeModulus) {
|
|
// tau already in fundamental domain → should be returned unchanged
|
|
std::complex<double> tau(0.45, 1.1);
|
|
auto tauNorm = normalizeModulus(tau);
|
|
EXPECT_NEAR(0.45, tauNorm.real(), 1E-12);
|
|
EXPECT_NEAR(1.1, tauNorm.imag(), 1E-12);
|
|
|
|
// tau = i/3 (|tau| < 1) → inversion gives 3i
|
|
tau = std::complex<double>(0.0, 1.0 / 3.0);
|
|
tauNorm = normalizeModulus(tau);
|
|
EXPECT_NEAR(3.0, tauNorm.imag(), 1E-12);
|
|
EXPECT_NEAR(0.0, tauNorm.real(), 1E-12);
|
|
}
|
|
|
|
// Corresponds to Java testNormalizeModulusPeriodShift()
|
|
// Two tau values that differ by a T-shift (integer shift of Re) must normalize
|
|
// to the same point in the fundamental domain.
|
|
TEST(DiscreteEllipticUtilityTest, NormalizeModulusPeriodShift) {
|
|
std::complex<double> tau1(0.3, 1.0);
|
|
std::complex<double> tau2(-0.7, 1.0); // tau2 = tau1 - 1
|
|
|
|
auto n1 = normalizeModulus(tau1);
|
|
auto n2 = normalizeModulus(tau2);
|
|
|
|
EXPECT_NEAR(n1.real(), n2.real(), 1E-12) << "real parts should be equal";
|
|
EXPECT_NEAR(n1.imag(), n2.imag(), 1E-12) << "imag parts should be equal";
|
|
}
|