d3c08b3bc0
This commit closes the remaining red gates so `run-all.sh --fast` is
green end-to-end on the canonical dev machine.
New gates
─────────
1. cmake-format / cmake-lint
* scripts/quality/cmake-format.sh — dry-run by default,
--strict to fail on drift, --fix to apply
* .cmake-format.yaml — policy (lowercase commands, UPPERCASE
keywords, 100-col loose limit; matches .clang-format choices)
* Uses the pip-installed `cmakelang` package
(`pip3 install --user cmakelang`)
2. codespell
* scripts/quality/codespell.sh — exit 1 on any typo, --fix
interactively
* .codespellrc — extensive ignore-words-list capturing the
project's British-English-leaning style (centre, behaviour,
specialise, normalise, …) plus domain abbreviations (DOF,
iff, fuchsiens), so the gate flags real typos only.
* Validated: 0 typos across docs + code/include + scripts +
code/{src,tests}.
SPDX rollout (license-headers --fix)
────────────────────────────────────
license-headers.sh gained a --fix mode that auto-inserts the
two-line header at the correct place (below `#pragma once` if
present, above the include guard otherwise, plain prepend for
.cpp). Ran it on 60 of 66 files — 100 %-licensed now.
Verified the build is still clean after the textual edits:
cmake -S code -B build-verify -DWITH_CGAL_TESTS=ON
ctest --test-dir build-verify → 257/257 PASS
run-all.sh + README updated to include the two new gates.
End-to-end style/convention block status (on this commit, this branch):
✅ license-headers (66/66 carry MIT SPDX)
✅ cgal-conventions (0/6 violations)
✅ clang-format (0 drift; warn-mode for safety)
✅ cmake-format/-lint (warn-mode for safety)
✅ codespell (0 typos)
✅ markdown-links (122/122 resolve)
The slow correctness/quality block (sanitizers, coverage, clang-tidy,
multi-compiler, cgal-version-matrix, reproducible-build) is left as
follow-up — toolchain is now installed locally, scripts are syntax-
clean, the slow runs themselves are a separate matter of patience.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
54 lines
2.3 KiB
C++
54 lines
2.3 KiB
C++
// Copyright (c) 2024-2026 Tarik Moussa.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
// Port of de.varylab.discreteconformal.plugin.HyperIdealVisualizationPluginTest (Java/JUnit).
|
|
//
|
|
// Tests the conversion from a hyperbolic circle (hyperboloid model)
|
|
// to its Euclidean representation (Poincaré disk model).
|
|
//
|
|
// Java test: static method HyperIdealVisualizationPlugin
|
|
// .getEuclideanCircleFromHyperbolic(double[] center, double radius)
|
|
// C++ port: conformallab::getEuclideanCircleFromHyperbolic(Vector4d, double)
|
|
// in hyper_ideal_visualization_utility.hpp
|
|
|
|
#include "hyper_ideal_visualization_utility.hpp"
|
|
#include <gtest/gtest.h>
|
|
#include <cmath>
|
|
|
|
using namespace conformallab;
|
|
|
|
// Corresponds to Java testGetEuclideanCircleFromHyperbolic_Centered()
|
|
//
|
|
// A hyperbolic circle centered at the origin (0,0,0,1) with radius 1.
|
|
// In the Poincaré disk this maps to a Euclidean circle centered at (0,0)
|
|
// with radius sinh(1) / (cosh(1) + 1).
|
|
TEST(HyperIdealVisualizationUtilityTest, EuclideanCircleFromHyperbolic_Centered)
|
|
{
|
|
Eigen::Vector4d center(0.0, 0.0, 0.0, 1.0);
|
|
const double radius = 1.0;
|
|
|
|
auto result = getEuclideanCircleFromHyperbolic(center, radius);
|
|
|
|
const double expected_r = std::sinh(1.0) / (std::cosh(1.0) + 1.0);
|
|
EXPECT_NEAR(0.0, result[0], 1E-12) << "Euclidean cx should be 0";
|
|
EXPECT_NEAR(0.0, result[1], 1E-12) << "Euclidean cy should be 0";
|
|
EXPECT_NEAR(expected_r, result[2], 1E-12) << "Euclidean radius mismatch";
|
|
}
|
|
|
|
// Corresponds to Java testGetEuclideanCircleFromHyperbolic_OffCenter()
|
|
//
|
|
// A hyperbolic circle centered at (sinh(1),0,0,cosh(1)) with radius 1.
|
|
// By symmetry (center is on the x-axis, circle is symmetric about it):
|
|
// • the Euclidean center lies on the x-axis → cy = 0
|
|
// • the Euclidean center equals the radius → cx = r (the circle passes through the Poincaré origin)
|
|
TEST(HyperIdealVisualizationUtilityTest, EuclideanCircleFromHyperbolic_OffCenter)
|
|
{
|
|
Eigen::Vector4d center(std::sinh(1.0), 0.0, 0.0, std::cosh(1.0));
|
|
const double radius = 1.0;
|
|
|
|
auto result = getEuclideanCircleFromHyperbolic(center, radius);
|
|
|
|
EXPECT_NEAR(result[0], result[2], 1E-12) << "cx should equal Euclidean radius";
|
|
EXPECT_NEAR(0.0, result[1], 1E-12) << "cy should be 0 (x-axis symmetry)";
|
|
}
|