Some checks failed
C++ Tests / test-fast (pull_request) Successful in 2m2s
API Docs / doc-build (pull_request) Successful in 46s
Markdown link check / check (pull_request) Successful in 47s
C++ Tests / test-cgal (pull_request) Failing after 10m51s
C++ Tests / quality-gates (pull_request) Successful in 2m21s
Two reviewer-facing additions:
1. New `quality-gates` job in .gitea/workflows/cpp-tests.yml
──────────────────────────────────────────────────────────
Runs in parallel with test-cgal after test-fast. Installs
`codespell` + `shellcheck` (apt) into the existing ci-cpp container,
then executes four scripts strictly (exit 1 on any finding):
* license-headers.sh — 66/66 files carry SPDX MIT
* cgal-conventions.py — 0 violations across 6 CGAL public headers
* codespell.sh — 0 typos across docs + source + scripts
* shellcheck.sh — 0 findings across 16 shell scripts
Each ran at 0 findings locally for weeks before promotion. The
gates are now contractual: a regression fails the PR. Total
wall-time on the eulernest runner: ~30 s.
2. New code/deps/THIRD-PARTY-LICENSES.md
──────────────────────────────────────
Enumerates every vendored dependency under code/deps/, plus the
auto-fetched GoogleTest, plus the system-required Boost, with:
* upstream project + version + SPDX identifier
* compatibility note for MIT distribution
* a downstream-packager license matrix (header-only consumer
vs CLI binary) clarifying the LGPL §3 vs §4 distinction
relevant to CGAL's header-only consumption
Required for any future Linux-distribution packaging and for the
CGAL submission's compliance check. Cross-referenced from
doc/architecture/dependencies.md.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
163 lines
7.3 KiB
YAML
163 lines
7.3 KiB
YAML
name: C++ Tests
|
||
|
||
on:
|
||
push:
|
||
branches:
|
||
- main
|
||
- dev
|
||
- "claude/**"
|
||
- "feature/**"
|
||
pull_request:
|
||
|
||
# ─────────────────────────────────────────────────────────────────────────────
|
||
# Job 1 — test-fast
|
||
# Pure-math tests (Clausen, ImLi₂, Hyper-ideal geometry).
|
||
# No CGAL, no Boost. Eigen + GTest only. Runs on ALL branches.
|
||
# ─────────────────────────────────────────────────────────────────────────────
|
||
jobs:
|
||
test-fast:
|
||
runs-on: eulernest
|
||
container:
|
||
image: git.eulernest.eu/conformallab/ci-cpp:latest
|
||
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
|
||
- name: Configure (tests-only)
|
||
run: cmake -S code -B build -DCMAKE_BUILD_TYPE=Release
|
||
|
||
- name: Build
|
||
run: nice -n 19 cmake --build build --target conformallab_tests -j$(nproc)
|
||
|
||
- name: Run tests
|
||
run: >
|
||
ctest --test-dir build
|
||
--output-on-failure
|
||
--output-junit test-results.xml
|
||
|
||
- name: Summary
|
||
if: always()
|
||
run: |
|
||
if [ -f test-results.xml ]; then
|
||
total=$(grep -o 'tests="[0-9]*"' test-results.xml | grep -o '[0-9]*' | head -1)
|
||
failed=$(grep -o 'failures="[0-9]*"' test-results.xml | grep -o '[0-9]*' | head -1)
|
||
skipped=$(grep -o 'skipped="[0-9]*"' test-results.xml | grep -o '[0-9]*' | head -1)
|
||
passed=$(( ${total:-0} - ${failed:-0} - ${skipped:-0} ))
|
||
echo "FAST ▸ TOTAL ${total:-0} | PASSED $passed | FAILED ${failed:-0} | SKIPPED ${skipped:-0}"
|
||
fi
|
||
|
||
# ─────────────────────────────────────────────────────────────────────────────
|
||
# Job 2 — test-cgal
|
||
# Full CGAL test suite (Phase 3–7, 158 tests).
|
||
# Runs ONLY on pull requests (not on direct pushes to dev/main).
|
||
# Starts only after test-fast succeeds.
|
||
#
|
||
# Uses -DWITH_CGAL_TESTS=ON (not -DWITH_CGAL=ON) to avoid building
|
||
# Viewer/GLFW — the CI container has no wayland-scanner.
|
||
#
|
||
# Boost (libboost-dev) is already present in the container since the image rebuild.
|
||
# ─────────────────────────────────────────────────────────────────────────────
|
||
test-cgal:
|
||
needs: test-fast
|
||
if: github.event_name == 'pull_request'
|
||
runs-on: eulernest
|
||
container:
|
||
image: git.eulernest.eu/conformallab/ci-cpp:latest
|
||
# Memory bumped from 1400m → 1600m to avoid OOM during CGAL header
|
||
# compilation on ARM64 (CGAL + Eigen templates allocate ~700 MB per
|
||
# cc1plus instance; -j1 leaves a small margin).
|
||
# memory-swap == memory disables swap entirely so OOM fails fast
|
||
# rather than thrashing on the SD card.
|
||
options: "--memory=1600m --memory-swap=1600m"
|
||
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
|
||
- name: Configure (WITH_CGAL_TESTS — no viewer, no wayland-scanner)
|
||
run: cmake -S code -B build -DWITH_CGAL_TESTS=ON -DCMAKE_BUILD_TYPE=Release
|
||
|
||
- name: Build CGAL-Tests
|
||
run: nice -n 19 cmake --build build --target conformallab_cgal_tests -j1
|
||
|
||
- name: Run CGAL-Tests
|
||
run: >
|
||
ctest --test-dir build
|
||
-R "^cgal\."
|
||
--output-on-failure
|
||
--output-junit cgal-results.xml
|
||
|
||
- name: Summary
|
||
if: always()
|
||
run: |
|
||
if [ -f cgal-results.xml ]; then
|
||
total=$(grep -o 'tests="[0-9]*"' cgal-results.xml | grep -o '[0-9]*' | head -1)
|
||
failed=$(grep -o 'failures="[0-9]*"' cgal-results.xml | grep -o '[0-9]*' | head -1)
|
||
skipped=$(grep -o 'skipped="[0-9]*"' cgal-results.xml | grep -o '[0-9]*' | head -1)
|
||
passed=$(( ${total:-0} - ${failed:-0} - ${skipped:-0} ))
|
||
echo "CGAL ▸ TOTAL ${total:-0} | PASSED $passed | FAILED ${failed:-0} | SKIPPED ${skipped:-0}"
|
||
fi
|
||
|
||
# ── Structural gate: doc/api/tests.md totals match ctest reality ───
|
||
# Single source of truth for test counts (see doc/release-policy.md).
|
||
# Reuses the already-built ./build dir via BUILD_DIR env var, so this
|
||
# adds ~5 s on top of the existing CGAL job.
|
||
- name: Verify test-count consistency (doc/api/tests.md)
|
||
run: BUILD_DIR=build bash scripts/check-test-counts.sh
|
||
|
||
# ── Structural gate: end-to-end smoke (try_it.sh) ──────────────────
|
||
# The user-facing quick-start script: configure + build + run the
|
||
# full ctest + run the Euclidean example on a bundled mesh. If
|
||
# this regresses, README quick-start instructions are broken.
|
||
# try_it.sh creates its own build-try/ — accept the ~3 min cost as
|
||
# the price of guaranteeing the documented workflow stays working.
|
||
- name: End-to-end smoke test (scripts/try_it.sh)
|
||
run: bash scripts/try_it.sh
|
||
|
||
# ─────────────────────────────────────────────────────────────────────────────
|
||
# Job 3 — quality-gates (style + convention block)
|
||
#
|
||
# Cheap, deterministic checks that should never break unless a contributor
|
||
# introduces a regression. Each gate is a script under scripts/quality/
|
||
# and exits 0 only when its tree is clean. These ran for weeks locally
|
||
# at zero findings before being promoted here.
|
||
#
|
||
# Tools installed at job-start (the ci-cpp image already has python3 +
|
||
# bash; we add codespell + shellcheck on top). Total wall-time: ~30 s
|
||
# on the eulernest runner.
|
||
#
|
||
# Strictly required for merges into main/dev — a regression fails the PR.
|
||
# ─────────────────────────────────────────────────────────────────────────────
|
||
quality-gates:
|
||
needs: test-fast
|
||
runs-on: eulernest
|
||
container:
|
||
image: git.eulernest.eu/conformallab/ci-cpp:latest
|
||
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
|
||
- name: Install codespell + shellcheck (job-local)
|
||
run: |
|
||
apt-get update -qq
|
||
apt-get install -y --no-install-recommends \
|
||
codespell shellcheck
|
||
|
||
- name: License headers (every C++ source carries MIT SPDX)
|
||
run: bash scripts/quality/license-headers.sh
|
||
|
||
- name: CGAL conventions (6 rules over CGAL public headers)
|
||
run: python3 scripts/quality/cgal-conventions.py
|
||
|
||
- name: codespell (docs + source comments + script messages)
|
||
run: bash scripts/quality/codespell.sh
|
||
|
||
- name: shellcheck (scripts/**/*.sh, severity=warning, strict)
|
||
run: bash scripts/quality/shellcheck.sh --strict
|
||
|
||
- name: Summary
|
||
if: always()
|
||
run: |
|
||
echo "QUALITY ▸ all four gates passed."
|
||
echo " see scripts/quality/README.md for the full catalogue"
|
||
echo " (sanitizers, clang-tidy, coverage, etc. are local-only)"
|