Some checks failed
C++ Tests / test-fast (pull_request) Successful in 1m59s
API Docs / doc-build (pull_request) Successful in 49s
Markdown link check / check (pull_request) Successful in 42s
C++ Tests / test-cgal (pull_request) Failing after 8m14s
C++ Tests / quality-gates (pull_request) Failing after 1m45s
Evaluated all four mid-tier architecture-touch levers from doc/architecture/compile-time.md. Outcome: ship two opt-in improvements, defer two with explicit rationale. #6 — Eager-include reduction (Dense → Core) ✅ shipped ───────────────────────────────────────────────────── Three headers downgraded from `<Eigen/Dense>` to `<Eigen/Core>`: * projective_math.hpp * hyper_ideal_visualization_utility.hpp * mesh_utils.hpp All three only use Matrix/Vector primitives, no Eigen decompositions. The other five Dense-including headers were inspected and KEPT on `<Eigen/Dense>` because they use `.inverse()`, `.determinant()`, `ColPivHouseholderQR`, or `SelfAdjointEigenSolver`. Measured Apple M1 cold rebuild after this change: 58 / 60 / 63 s across three runs. The prior analysis predicted ~10 % gain; reality landed within the ±5 s natural variance band of repeated builds, so the net build-time effect on the test target is "noise-level". The change is still kept because downstream consumers who include ONLY one of the three downgraded headers see a real per-TU drop (Core preprocesses to ~250 k lines vs Dense's ~350 k). #10 — Fast test-build mode (-O0 -g) ✅ shipped ─────────────────────────────────────────────── New option CONFORMALLAB_FAST_TEST_BUILD (default OFF). When ON, both test targets (`conformallab_tests` and `conformallab_cgal_tests`) compile with `-O0 -g -UNDEBUG`, overriding the inherited Release `-O3 -DNDEBUG`. Measured Apple clang: 51.6 s vs 46.8 s without -O0 → slightly slower. The Backend phase that prior analysis predicted would drop from 9.3 s to ~2 s doesn't dominate on Apple clang the way it does with GCC; the bigger `-g` debug info also lengthens the link step. Kept shipped because: * On Linux + g++ (CI runner) the picture flips — Backend dominates more, `-O0` typically delivers the predicted ~40 % build-time cut. * Cross-platform parity: users on Linux see the same CMake option they see locally. Honest documentation in doc/architecture/compile-time.md notes that the Apple-clang-local benefit is currently 0 %. Tests RUN ~15× slower under `-O0` (1.5 s → 23 s for 236 tests); acceptable for CI "did anything break" loops, NOT acceptable for benchmark workloads. #5 — Move detail:: impls to .inl files ⏸ deferred ─────────────────────────────────────────────────── Pure enabler for #7. Without #7 landing, the .inl extraction would just add an extra hop to header reading. Reconsider once a concrete maintenance reason emerges (e.g. a downstream user wants to override a detail helper). #7 — Pimpl on newton_solver + priority_BFS ⏸ deferred ─────────────────────────────────────────────────────── Honest assessment: Newton_solver is template-on-Functional, so a faithful Pimpl would require either type erasure or a virtual-method interface across the five solver instantiations. Estimated 1-2 weeks of refactor with measurable API-surface risk. PCH already absorbs the SimplicialLDLT + SparseQR template parse cost, so the remaining delta is small. Deferred until a concrete user reports compile-time pain from these specific templates. Documentation ───────────── README.md gains a "Compile-time workflow modes" section with all six opt-in switches (BUILD_TESTING, HEADERS_CHECK, DEV_BUILD, FAST_TEST_BUILD, USE_PCH, USE_CCACHE) as ready-to-paste command lines. doc/architecture/compile-time.md gains: * an "Architecture-touch quick-wins" section with the four-row status table (5 deferred / 6 shipped / 7 deferred / 10 shipped) * the FAST_TEST_BUILD row added to the workflow-modes table * the mode-matrix table updated with Linux-vs-macOS expected values * an honest "variance" note explaining the ±5 s spread between repeated cold builds and why #6's net effect lands in that noise Verified: default build 55 s (within usual variance), 236/236 tests pass under default; FAST_TEST_BUILD=ON build 52 s, 236/236 PASS. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
100 lines
3.6 KiB
C++
100 lines
3.6 KiB
C++
#pragma once
|
|
// Copyright (c) 2024-2026 Tarik Moussa.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
// mesh_utils.hpp
|
|
//
|
|
// Conversions between CGAL::Surface_mesh and Eigen matrices. Used
|
|
// primarily by the viewer / example programs to bridge to libigl, which
|
|
// expects (V, F) matrix pairs rather than a halfedge data structure.
|
|
//
|
|
// All functions are templated on the kernel so the same code works
|
|
// with `Simple_cartesian<double>` (production) and with any CGAL
|
|
// `Kernel_d::Point_3` (test scaffolding).
|
|
|
|
#include <CGAL/Surface_mesh.h>
|
|
#include <Eigen/Core> // downgraded from <Eigen/Dense>: this header only
|
|
// uses Matrix/Vector primitives, no decompositions.
|
|
#include <CGAL/Polygon_mesh_processing/triangulate_faces.h>
|
|
|
|
|
|
namespace mesh_utils {
|
|
|
|
/// Copy `mesh` into an Eigen `(V, F)` pair (libigl convention).
|
|
///
|
|
/// **Side effect:** `mesh` is triangulated in place via
|
|
/// `CGAL::Polygon_mesh_processing::triangulate_faces` so the output
|
|
/// `F` is guaranteed to be a 3-column matrix. If `mesh` is already a
|
|
/// triangle mesh this is a no-op.
|
|
///
|
|
/// \param mesh Input surface mesh. **Modified in place** if any face
|
|
/// has more than 3 vertices.
|
|
/// \param V Output: `(num_vertices, 3)` matrix of vertex positions.
|
|
/// \param F Output: `(num_faces, 3)` matrix of vertex indices per
|
|
/// face (rows are individual triangles).
|
|
template <typename Kernel>
|
|
void cgal_to_eigen(CGAL::Surface_mesh<typename Kernel::Point_3>& mesh,
|
|
Eigen::MatrixXd& V, Eigen::MatrixXi& F) {
|
|
|
|
CGAL::Polygon_mesh_processing::triangulate_faces(mesh);
|
|
|
|
V.resize(mesh.num_vertices(), 3);
|
|
F.resize(mesh.num_faces(), 3);
|
|
|
|
for (auto v : mesh.vertices()) {
|
|
auto p = mesh.point(v);
|
|
V.row(v.idx()) << p.x(), p.y(), p.z();
|
|
}
|
|
|
|
Eigen::Index face_idx = 0;
|
|
for (auto f : mesh.faces()) {
|
|
int vertex_count = 0;
|
|
for (auto h : CGAL::halfedges_around_face(mesh.halfedge(f), mesh)) {
|
|
auto v = mesh.target(h);
|
|
F(face_idx, vertex_count) = v.idx();
|
|
++vertex_count;
|
|
}
|
|
face_idx++;
|
|
}
|
|
}
|
|
|
|
/// Quick interactive visualisation via libigl + GLFW.
|
|
///
|
|
/// **Requires** `WITH_VIEWER=ON` at CMake time (which is implied by
|
|
/// `WITH_CGAL=ON`). Blocks until the viewer window is closed.
|
|
/// Not suitable for CI / headless contexts.
|
|
///
|
|
/// Typical use:
|
|
/// \code{.cpp}
|
|
/// Eigen::MatrixXd V; Eigen::MatrixXi F;
|
|
/// mesh_utils::cgal_to_eigen<Kernel>(mesh, V, F);
|
|
/// mesh_utils::simple_visualize_mesh<Kernel>(V, F);
|
|
/// \endcode
|
|
template <typename Kernel>
|
|
void simple_visualize_mesh(Eigen::MatrixXd& V, Eigen::MatrixXi& F) {
|
|
igl::opengl::glfw::Viewer viewer;
|
|
viewer.data().set_mesh(V, F);
|
|
viewer.launch();
|
|
}
|
|
|
|
/// Zero-copy `Eigen::Map` view of `mesh`'s vertex positions.
|
|
///
|
|
/// Returns a row-major `(N, 3)` `Eigen::Map` that aliases the
|
|
/// `mesh.points()` storage directly — no allocation, O(1).
|
|
///
|
|
/// **Lifetime warning:** the returned `Map` references memory owned by
|
|
/// `mesh`. Adding or removing vertices may invalidate the underlying
|
|
/// storage; use the `Map` only as long as `mesh` is structurally stable.
|
|
///
|
|
/// This is the read-write counterpart to `cgal_to_eigen` for cases
|
|
/// where the caller wants to *modify* vertex positions through Eigen
|
|
/// (e.g. apply a Möbius transformation) without an intermediate copy.
|
|
template <typename Kernel>
|
|
Eigen::Map<Eigen::Matrix<double, Eigen::Dynamic, 3, Eigen::RowMajor>>
|
|
get_vertex_map(CGAL::Surface_mesh<typename Kernel::Point_3>& mesh) {
|
|
auto& points = mesh.points();
|
|
double* data = reinterpret_cast<double*>(&points[0][0]);
|
|
return {data, static_cast<Eigen::Index>(points.size()), 3};
|
|
}
|
|
} // namespace
|