user2595/codex-py
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(search): cast query embedding to ::vector in search paper (DQ-4)

Browse Source 
`codex search paper` crashed on the live DB with "operator does not exist:
vector <-> double precision[]". The pgvector `<->` operator needs its RHS
typed as vector; peer call sites (mcp_server.py, wiki.py) cast but the CLI
did not. Mocked unit tests never exercise real pgvector, so it went unseen.

Add the cast to both `<->` occurrences and a regression guard asserting the
SQL contains `::vector`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tarik Moussa
2026-06-16 23:51:38 +02:00
parent 64e3ee188c
commit 553ae3995d
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
codex/cli.py
View File

@@ -84,10 +84,10 @@ def search_paper(
rows = conn.execute( rows = conn.execute(
""" """
SELECT id, title, year, SELECT id, title, year,
abstract_emb <-> %(emb)s AS distance abstract_emb <-> %(emb)s::vector AS distance
FROM papers FROM papers
WHERE abstract_emb IS NOT NULL WHERE abstract_emb IS NOT NULL
ORDER BY abstract_emb <-> %(emb)s ORDER BY abstract_emb <-> %(emb)s::vector
LIMIT %(limit)s LIMIT %(limit)s
""", """,
{"emb": emb, "limit": limit}, {"emb": emb, "limit": limit},

7
tests/cli/test_cli.py
View File

@@ -106,6 +106,13 @@ class TestSearch:
assert "Test Paper" in result.stdout assert "Test Paper" in result.stdout
assert "0.123" in result.stdout assert "0.123" in result.stdout
# Regression guard (DQ-4): the pgvector `<->` operator requires the
# query embedding cast to ::vector. Without it, real Postgres raises
# "operator does not exist: vector <-> double precision[]". Mocked DBs
# don't catch the type error, so assert the cast is in the SQL.
executed_sql = mock_conn.execute.call_args_list[0][0][0]
assert "<->" in executed_sql and "::vector" in executed_sql
def test_search_formula_command(self) -> None: def test_search_formula_command(self) -> None:
"""Test `search formula` command with mocked DB.""" """Test `search formula` command with mocked DB."""
with patch("codex.db.get_conn") as mock_get_conn: with patch("codex.db.get_conn") as mock_get_conn: