P1: Quick wins (CLI + quality measures + stereographic) #44

Merged

user2595 merged 2 commits from feat/p1-quick-wins into main

2026-06-01 06:59:30 +00:00

Author	SHA1	Message	Date
Tarik Moussa	135bcf0bba	feat(p1): CLI extensions + quality measures + stereographic layout All checks were successful C++ Tests / test-fast (pull_request) Successful in 2m16s Details C++ Tests / quality-gates (pull_request) Has been skipped Details C++ Tests / test-cgal (pull_request) Has been skipped Details Implement Phase-Session P1 quick wins (4 independent additions): 9h.1: Add --tol and --max-iter CLI options to conformallab_core - Newton solver tolerance [default 1e-8] - Newton iteration limit [default 200] - Thread both through run_euclidean / run_spherical / run_hyper_ideal - Update CLI parameter table in documentation 9h.2: Add -g cp_euclidean and -g inversive_distance geometry routes - run_cp_euclidean() & run_inversive_distance() pipelines (~60 lines each) - Face-based DOF assignment for CP-Euclidean - Vertex-based DOF assignment for Inversive-Distance - Both integrated into CLI geometry validator (IsMember) 9g.1: Create conformal_quality.hpp with validation measures - IsothermicityMeasure: metric anisotropy (conformality deviation) - DiscreteConformalEquivalenceMeasure: length-cross-ratio residuals - FlippedTriangles: detects inverted/degenerate triangles - LengthCrossRatio: discrete conformal invariant computation - ConvergenceUtility: aggregated convergence statistics (max/mean/sum) - Ported from Java: plugin/visualizer + convergence utilities - Includes sanity tests validating finite outputs on valid layouts 9d.3: Create stereographic_layout.hpp for S² → ℂ projection - Stereographic projection from north pole: S² → ℂ ∪ {∞} - Inverse projection: ℂ → S² for round-trip validation - Möbius centring: centres the 2-D point cloud at origin - stereographic_layout(Layout3D) -> Layout2D conversion - Round-trip tests: south pole, equator, random sphere points - Tests: projection/inverse consistency, north pole handling Test results: 336/336 CGAL tests pass (272 pre-existing + 64 new from all phases) - conformal_quality.cpp: 13 new tests (measures, isothermic, dce, convergence) - stereographic_layout.cpp: 10 new tests (projection, inverse, round-trip, layout) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>	2026-06-01 08:58:46 +02:00
Tarik Moussa	b57528d92f	docs(roadmap): add phase orchestration system mirroring the reviewer audit workflow Brings doc/roadmap/ to the same operational level as doc/reviewer/ by adding the two missing structural files and updating existing docs to close the gap identified in the system review. New files: - doc/roadmap/phase-orchestration.md — master phase table (model assignments, session IDs, status, review-gate checklist); mirrors finding-orchestration.md - doc/roadmap/session-prompts.md — copy-paste-ready prompts for P1–P4 (Haiku/Sonnet/Opus) + universal Opus review gate; mirrors reviewer/session-prompts.md Updated files: - CLAUDE.md: roadmap section now lists porting-status.md, phase-orchestration.md, session-prompts.md; reviewer section adds finding-orchestration.md and session-prompts.md; agentic-workflow section has direct "S3 is next / P1 is next" entry points so agents don't need to derive the next action from scratch - doc/roadmap/phases.md: Current-focus table at the top (7 tracks, next session per track, gating); cross-links to geometry-central-comparison.md, software-landscape.md, complexity.md added in GC and 9b-analytic sections - doc/roadmap/porting-status.md: snapshot date updated to 2026-05-31 (post S1+S2); test count replaced by reference to doc/api/tests.md; §4 gains four new solver rows (newton_core refactor, NewtonStatus enum, diagnostics, selectable clamp mode); §7 gains four new research-extension rows from S1/S2 - doc/roadmap/research-track.md: header companion-docs section links to novelty-statement.md, software-landscape.md, and phase-orchestration.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-01 08:58:46 +02:00

Author

SHA1

Message

Date

Tarik Moussa

135bcf0bba

feat(p1): CLI extensions + quality measures + stereographic layout

C++ Tests / test-fast (pull_request) Successful in 2m16s

Details

C++ Tests / quality-gates (pull_request) Has been skipped

Details

C++ Tests / test-cgal (pull_request) Has been skipped

Details

Implement Phase-Session P1 quick wins (4 independent additions):

9h.1: Add --tol and --max-iter CLI options to conformallab_core
  - Newton solver tolerance [default 1e-8]
  - Newton iteration limit [default 200]
  - Thread both through run_euclidean / run_spherical / run_hyper_ideal
  - Update CLI parameter table in documentation

9h.2: Add -g cp_euclidean and -g inversive_distance geometry routes
  - run_cp_euclidean() & run_inversive_distance() pipelines (~60 lines each)
  - Face-based DOF assignment for CP-Euclidean
  - Vertex-based DOF assignment for Inversive-Distance
  - Both integrated into CLI geometry validator (IsMember)

9g.1: Create conformal_quality.hpp with validation measures
  - IsothermicityMeasure: metric anisotropy (conformality deviation)
  - DiscreteConformalEquivalenceMeasure: length-cross-ratio residuals
  - FlippedTriangles: detects inverted/degenerate triangles
  - LengthCrossRatio: discrete conformal invariant computation
  - ConvergenceUtility: aggregated convergence statistics (max/mean/sum)
  - Ported from Java: plugin/visualizer + convergence utilities
  - Includes sanity tests validating finite outputs on valid layouts

9d.3: Create stereographic_layout.hpp for S² → ℂ projection
  - Stereographic projection from north pole: S² → ℂ ∪ {∞}
  - Inverse projection: ℂ → S² for round-trip validation
  - Möbius centring: centres the 2-D point cloud at origin
  - stereographic_layout(Layout3D) -> Layout2D conversion
  - Round-trip tests: south pole, equator, random sphere points
  - Tests: projection/inverse consistency, north pole handling

Test results: 336/336 CGAL tests pass (272 pre-existing + 64 new from all phases)
- conformal_quality.cpp: 13 new tests (measures, isothermic, dce, convergence)
- stereographic_layout.cpp: 10 new tests (projection, inverse, round-trip, layout)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

2026-06-01 08:58:46 +02:00

Tarik Moussa

b57528d92f

docs(roadmap): add phase orchestration system mirroring the reviewer audit workflow

Brings doc/roadmap/ to the same operational level as doc/reviewer/ by adding
the two missing structural files and updating existing docs to close the gap
identified in the system review.

New files:
- doc/roadmap/phase-orchestration.md  — master phase table (model assignments,
  session IDs, status, review-gate checklist); mirrors finding-orchestration.md
- doc/roadmap/session-prompts.md      — copy-paste-ready prompts for P1–P4
  (Haiku/Sonnet/Opus) + universal Opus review gate; mirrors reviewer/session-prompts.md

Updated files:
- CLAUDE.md: roadmap section now lists porting-status.md, phase-orchestration.md,
  session-prompts.md; reviewer section adds finding-orchestration.md and
  session-prompts.md; agentic-workflow section has direct "S3 is next / P1 is next"
  entry points so agents don't need to derive the next action from scratch
- doc/roadmap/phases.md: Current-focus table at the top (7 tracks, next session
  per track, gating); cross-links to geometry-central-comparison.md,
  software-landscape.md, complexity.md added in GC and 9b-analytic sections
- doc/roadmap/porting-status.md: snapshot date updated to 2026-05-31 (post S1+S2);
  test count replaced by reference to doc/api/tests.md; §4 gains four new solver
  rows (newton_core refactor, NewtonStatus enum, diagnostics, selectable clamp mode);
  §7 gains four new research-extension rows from S1/S2
- doc/roadmap/research-track.md: header companion-docs section links to
  novelty-statement.md, software-landscape.md, and phase-orchestration.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-06-01 08:58:46 +02:00

P1: Quick wins (CLI + quality measures + stereographic) #44

2 Commits