12 Commits

Author SHA1 Message Date
6c50590d99 docs(papers): sync MANUAL-DOWNLOAD.md with applied citation fixes
All checks were successful
C++ Tests / test-fast (push) Successful in 2m42s
C++ Tests / quality-gates (push) Has been skipped
API Docs / doc-build (push) Has been skipped
Mirror to Codeberg / mirror (push) Successful in 18s
C++ Tests / test-cgal (push) Has been skipped
Markdown link check / check (push) Successful in 29s
Review-gate NIT-1: the download helper still carried pre-fix text.
- Bobenko-Mercat-Schmies: updated to full title "Conformal Structures
  and Period Matrices...", correct editors + chapter DOI
- Footer rewritten from open-TODO ("zu korrigieren / muss angepasst
  werden") to past-tense record of the applied fixes

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
b6020ad2aa chore(gitignore): exclude derived paper artifacts (txt/mmd/figures)
Extracted text (pdftext), nougat mmd output and figure dumps are
regenerable from the source PDFs — keep them out of the repo like the
PDFs themselves. Also excludes the accidental facebook/ nougat model
cache (958 MB).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
582eb46efa fix(citations): systematic audit — 6 corrections in references.md
Findings from full citation audit of all 34 references.md entries:

CRITICAL:
- Knöppel et al. 2015 "Stripe Patterns": arXiv 1502.06686 was a completely
  different paper (Data-Driven Shape Analysis by Xu et al.) — removed from
  papers/. Correct DOI is 10.1145/2767000, not 10.1145/2766890. No arXiv
  preprint exists for this paper.

ERRORS:
- Born, Bücking, Springborn: published 2017 in DCG 57(2) pp. 305–317
  (DOI 10.1007/s00454-016-9854-7); arXiv 2015 was preprint only
- Bobenko, Mercat, Schmies: short title; full title is
  "Conformal Structures and Period Matrices of Polyhedral Surfaces";
  editors Bobenko & Klein (not generic "Computational Approach" book ref);
  pp. 213–226, DOI 10.1007/978-3-642-17413-1_7

COMPLETIONS (missing vol/pages added):
- Pinkall, Polthier 1993: vol. 2(1), pp. 15–36, DOI added
- Bobenko, Springborn 2004: Trans. AMS 356(2), pp. 659–689, arXiv added
- Luo 2004: Commun. Contemp. Math. 6(5), pp. 765–780, DOI + arXiv added

Verified  (no changes needed, 28/34 entries):
Sechelmann 2016, Springborn 2020/2008, Ushijima 2006, Bowers-Stephenson 2004,
Glickenstein 2011, BPS 2015, Schläfli 1858, Erickson-Whittlesey 2005,
Bobenko-Springborn 2007, Desbrun-Kanso-Tong 2006, Soliman et al. 2018,
all Bobenko-Lutz papers, Lutz 2023/2024, Bowers-Bowers-Lutz 2026,
Alexa-Wardetzky 2011, Bunge et al. 2020, de Goes et al. 2020,
Gillespie-Springborn-Crane 2021, Sharp-Soliman-Crane 2019, Farkas-Kra,
Siegel, Bobenko-Bücking 2021, Rivin-Schlenker 1999, Pinkall-Springborn 2021,
Sawhney-Crane 2017

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
1063f3541f fix(citations): correct Meyerhoff/Ushijima misattribution
DOI 10.1007/0-387-29555-0_13 is Ushijima (sole author) —
"A Volume Formula for Generalised Hyperbolic Tetrahedra",
in: Prékopa & Molnár (eds.), Non-Euclidean Geometries,
Springer 2006. arXiv: math/0309216.

The references.md entry was wrong on all three counts:
  - Author:  "Meyerhoff, Ushijima" → Ushijima only
  - Title:   "A Note on the Dirichlet Domain" → entirely different title
  - Book:    "The Epstein Birthday Schrift" → Non-Euclidean Geometries

Same error pattern as the Kolpakov-Mednykh fix: the Java source
links only to a DOI without naming authors; a wrong name was
invented during the C++ port.

Files corrected: hyper_ideal_utility.hpp, hyper_ideal_functional.hpp,
references.md, tests.md, project-structure.md, finding-orchestration.md,
math-derivation-citation-audit.md, MANUAL-DOWNLOAD.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
Tarik Moussa
0f5ab27461 fix(citations): correct Kolpakov-Mednykh misattribution → Springborn 2008
arXiv:math/0603097 is Springborn 2008 ("A variational principle for weighted
Delaunay triangulations and hyperideal polyhedra"), not a Kolpakov-Mednykh paper.
The author pair Kolpakov & Mednykh has no joint publication from 2006; their
earliest collaboration is arXiv:1008.0312 (2010, on torus knots, unrelated).

The wrong author name was introduced during the Java→C++ port — the Java source
correctly links to math/0603097 without naming the authors; whoever ported it
invented "Kolpakov-Mednykh". The S1 citation audit (2026-05-31) then cemented
the error by adding the incorrect row to references.md.

Files corrected (7):
- code/include/hyper_ideal_utility.hpp
- code/include/hyper_ideal_functional.hpp
- code/tests/cgal/test_hyper_ideal_functional.cpp
- doc/math/references.md
- doc/roadmap/research-track.md
- doc/architecture/project-structure.md
- doc/api/tests.md

Also:
- doc/reviewer/math-derivation-citation-audit-2026-05-31.md: M1 post-correction noted
- doc/reviewer/finding-orchestration.md: lesson-learned section added (AI citation
  audits can introduce plausible-but-wrong attributions; human expert review required
  before CGAL submission)
- papers/MANUAL-DOWNLOAD.md: overview of papers requiring manual download (paywalled
  journals, TU Berlin theses, books)
- .gitignore: papers/*.pdf excluded (downloaded arXiv PDFs, not tracked)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
5d343776a3 Merge pull request 'fix(s3-followup): enforce V5 rule 4 + mark H3/H4/H5/V5/V6 done' (#47) from chore/s3-followup into main
All checks were successful
C++ Tests / test-fast (push) Successful in 8m26s
C++ Tests / quality-gates (push) Has been skipped
API Docs / doc-build (push) Has been skipped
Mirror to Codeberg / mirror (push) Successful in 39s
C++ Tests / test-cgal (push) Has been skipped
Markdown link check / check (push) Successful in 13s
2026-06-01 14:33:03 +00:00
Tarik Moussa
d3fc4ae056 fix(s3-followup): enforce V5 rule 4 + mark H3/H4/H5/V5/V6 done
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 8m47s
C++ Tests / quality-gates (pull_request) Has been skipped
C++ Tests / test-cgal (pull_request) Has been skipped
serialization.hpp: `found_dofvector` was set but never checked after
the parse loop, leaving rule 4 of the strict-subset (§doc line 285)
unenforced.  Add the missing post-loop throw so a ConformalResult XML
that omits the <DOFVector> element is rejected with a clear error
instead of silently returning an empty x.  Update the docstring to
remove the misleading "silently returns" note.

finding-orchestration.md: mark H3/H4/H5/V5/V6  and record the S3
session as complete.  Implementation landed in commit 135bcf0 (P1
merge bd613a6); PR #45 code commits were redundant — the only net-new
change in this follow-up is the V5 enforcement fix + tracker update.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-01 16:32:41 +02:00
b67854645c Merge pull request 'fix(s3): robustness & test-gap closure (H3/H4/H5/V5/V6)' (#45) from fix/s3-robustness-gaps into main
Some checks failed
C++ Tests / test-fast (push) Has been cancelled
C++ Tests / test-cgal (push) Has been cancelled
C++ Tests / quality-gates (push) Has been cancelled
API Docs / doc-build (push) Has been cancelled
Markdown link check / check (push) Has been cancelled
Mirror to Codeberg / mirror (push) Has been cancelled
2026-06-01 14:31:39 +00:00
Tarik Moussa
cda26d7b02 docs(s3): mark H3/H4/H5/V5/V6 done; update audit banners + orchestration
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 8m21s
C++ Tests / quality-gates (pull_request) Has been skipped
C++ Tests / test-cgal (pull_request) Has been skipped
- finding-orchestration.md: H3/H4/H5/V5/V6 → ; S3 session entry updated
  to DONE with commit refs (833f9e7, 2e6c4d7), PR #45, and 313/313 count.
- test-coverage-error-handling-audit-2026-05-31.md: banner updated to
  reflect H3/H4/H5 resolved in S3; test count 298 → 313.
- input-validation-audit-2026-05-31.md: banner updated to reflect V5/V6
  resolved in S3; test count 298 → 313.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-01 16:31:07 +02:00
71afd8e70a Merge pull request 'chore(settings): enable verbose output + explanatory style' (#46) from chore/verbose-settings into main
All checks were successful
C++ Tests / test-fast (push) Successful in 2m43s
C++ Tests / quality-gates (push) Has been skipped
API Docs / doc-build (push) Has been skipped
Markdown link check / check (push) Has been skipped
Mirror to Codeberg / mirror (push) Successful in 27s
C++ Tests / test-cgal (push) Has been skipped
2026-06-01 07:38:08 +00:00
Tarik Moussa
d5fc0f6c54 chore(settings): enable verbose output + explanatory style
All checks were successful
C++ Tests / test-fast (pull_request) Successful in 2m41s
C++ Tests / quality-gates (pull_request) Has been skipped
C++ Tests / test-cgal (pull_request) Has been skipped
Add CLAUDE_VERBOSE=1 and outputStyle=Explanatory to project settings
so tool calls and bash outputs are fully visible in the terminal.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-01 09:37:53 +02:00
bd613a6fa7 Merge pull request 'P1: Quick wins (CLI + quality measures + stereographic)' (#44) from feat/p1-quick-wins into main
All checks were successful
C++ Tests / test-fast (push) Successful in 2m25s
C++ Tests / quality-gates (push) Has been skipped
API Docs / doc-build (push) Has been skipped
Markdown link check / check (push) Has been skipped
Mirror to Codeberg / mirror (push) Successful in 38s
C++ Tests / test-cgal (push) Has been skipped
2026-06-01 06:59:28 +00:00
15 changed files with 180 additions and 45 deletions

View File

@@ -1,8 +1,10 @@
{
"$schema": "https://json.schemastore.org/claude-code-settings.json",
"env": {
"CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS": "1"
"CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS": "1",
"CLAUDE_VERBOSE": "1"
},
"outputStyle": "Explanatory",
"teammateMode": "tmux",
"permissions": {
"allow": [

7
.gitignore vendored
View File

@@ -33,3 +33,10 @@ Testing/
# Doxygen output
doc/doxygen/
*.dox.tmp
# Downloaded research papers + derived artifacts (regenerable, not tracked)
papers/*.pdf
papers/txt/
papers/mmd/
papers/facebook/
papers/figures/

View File

@@ -374,8 +374,8 @@ static FaceAngles compute_face_angles(
/// Per-face energy contribution U(f) before subtracting the θ·a and Θ·b terms.
///
/// Supported configurations (faithful port of HyperIdealFunctional.java):
/// * All three vertices hyper-ideal (v?b = true) → Meyerhoff/Ushijima volume
/// * Exactly one vertex ideal (v?b = false, other two true) → Kolpakov-Mednykh volume
/// * All three vertices hyper-ideal (v?b = true) → Ushijima 2006 volume
/// * Exactly one vertex ideal (v?b = false, other two true) → Springborn 2008 volume
///
/// NOT supported — faces with two or three ideal vertices. The Java reference
/// (HyperIdealFunctional.java lines 222-231) uses an if/else-if chain that

View File

@@ -16,7 +16,8 @@
namespace conformallab {
/// Volume of a generalized hyperbolic tetrahedron with dihedral
/// angles `A,…,F` via the Meyerhoff / Ushijima 2006 formula.
/// angles `A,…,F` via the Ushijima 2006 formula (DOI 10.1007/0-387-29555-0_13,
/// arxiv math/0309216). Note: sole author is Ushijima; "Meyerhoff" is not an author.
/// Same as Java `HyperIdealUtility.calculateTetrahedronVolume()`.
inline double calculateTetrahedronVolume(double A, double B, double C,
double D, double E, double F) {
@@ -77,7 +78,7 @@ inline double calculateTetrahedronVolume(double A, double B, double C,
}
/// Volume of a hyperideal tetrahedron with one ideal vertex at γ via
/// the Kolpakov-Mednykh formula (arxiv math/0603097). Same as Java
/// the Springborn 2008 formula (arxiv math/0603097). Same as Java
/// `HyperIdealUtility.calculateTetrahedronVolumeWithIdealVertexAtGamma()`.
inline double calculateTetrahedronVolumeWithIdealVertexAtGamma(
double gamma1, double gamma2, double gamma3,

View File

@@ -283,8 +283,8 @@ inline void save_result_xml(
/// 3. A line containing `<DOFVector` must carry the `>` character (tag
/// open) on the same line.
/// 4. The `<DOFVector` element must be present and must produce a
/// non-empty doubles list (a missing DOFVector silently returns an
/// empty x, which is incorrect for any mesh with at least one DOF).
/// non-empty doubles list (a missing DOFVector element causes a
/// `std::runtime_error` — enforced after the parse loop).
inline std::vector<double> load_result_xml(
const std::string& path,
NewtonResult* res = nullptr,
@@ -386,6 +386,13 @@ inline std::vector<double> load_result_xml(
" Only the format written by save_result_xml is supported.");
}
// V5 rule 4: <DOFVector> must be present in every well-formed ConformalResult.
if (found_root && !found_dofvector)
throw std::runtime_error(
"conformallab: XML strict-subset violation in " + path
+ ": <DOFVector> element not found. Only the format written by"
" save_result_xml is supported.");
return x;
}

View File

@@ -267,7 +267,7 @@ TEST(HyperIdealFunctional, MultiIdealGuard_AllThreeIdealVertices_Throws)
TEST(HyperIdealFunctional, MultiIdealGuard_ExactlyOneIdeal_DoesNotThrow)
{
// Exactly one ideal vertex per face must NOT throw — it is the supported
// one-ideal-vertex configuration (Kolpakov-Mednykh formula).
// one-ideal-vertex configuration (Springborn 2008 formula).
auto mesh = make_triangle();
auto maps = setup_hyper_ideal_maps(mesh);

View File

@@ -7,7 +7,7 @@ Pure-math tests, only Eigen required. Covers Java utilities ported in Phase 1
| File | What it tests |
|---|---|
| `test_clausen.cpp` | Clausen Cl₂, Lobachevsky Л, ImLi₂ — values at known points |
| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Meyerhoff / KolpakovMednykh) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) |
| `test_hyper_ideal_utility.cpp` | Tetrahedron volumes (Ushijima 2006 / Springborn 2008) + Java golden-value oracle (Clausen/Л/ImLi₂, ζ₁₃/₁₄/₁₅/ζ, both volume formulas) |
| `test_matrix_utility.cpp` | Matrix helpers |
| `test_surface_curve_utility.cpp` | Surface curve utilities |
| `test_discrete_elliptic_utility.cpp` | Discrete elliptic functions |

View File

@@ -14,7 +14,7 @@ ConformalLabpp/
│ │ ├── constants.hpp # conformallab::PI, TWO_PI
│ │ ├── clausen.hpp # Cl₂, Lobachevsky Л, ImLi₂
│ │ ├── hyper_ideal_geometry.hpp # ζ₁₃/₁₄/₁₅, lᵢⱼ, αᵢⱼ, σᵢ, σᵢⱼ
│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Meyerhoff / KolpakovMednykh)
│ │ ├── hyper_ideal_utility.hpp # Tetrahedron volumes (Ushijima 2006 / Springborn 2008)
│ │ ├── hyper_ideal_visualization_utility.hpp # Poincaré disk projection, circumcircle helpers
│ │ ├── hyper_ideal_functional.hpp # HyperIdeal energy + gradient on ConformalMesh
│ │ ├── hyper_ideal_hessian.hpp # HyperIdeal Hessian (symmetric FD, Phase 9b: analytic)

View File

@@ -29,11 +29,11 @@ Java reference implementation: [github.com/varylab/conformallab](https://github.
| Reference | Used in |
|---|---|
| ✅ **Springborn***Ideal Hyperbolic Polyhedra and Discrete Uniformization*, Discrete & Computational Geometry **64** (2020), pp. 63108. DOI: [10.1007/s00454-019-00132-8](https://doi.org/10.1007/s00454-019-00132-8) | `hyper_ideal_geometry.hpp` — ζ₁₃/ζ₁₄/ζ₁₅ functions; `hyper_ideal_functional.hpp` |
| ✅ **Kolpakov, Mednykh***A Formula for the Volume of a Hyperbolic Tetrahedron*, arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) (2006) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian) |
| ✅ **Meyerhoff, Ushijima***A Note on the Dirichlet Domain*, in: The Epstein Birthday Schrift (2006) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp` |
| **Pinkall, Polthier***Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics (1993) | `euclidean_hessian.hpp` — cotangent Laplacian |
| **Bobenko, Springborn***Variational Principles for Circle Patterns and Koebe's Theorem*, Transactions AMS (2004) | Variational angle-sum framework underlying all three functionals |
| **Luo***Combinatorial Yamabe Flow on Surfaces*, Communications in Contemporary Mathematics (2004) | Inversive-distance functional — **new research** in Phase 9a.2 (no Java original; implemented from this paper + Glickenstein 2011 + Bowers-Stephenson 2004) |
| ✅ **Springborn***A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*, J. Differential Geometry **78**(2) (2008), pp. 333367. arXiv: [math/0603097](https://arxiv.org/abs/math/0603097) | Tetrahedron volume with one ideal vertex: `calculateTetrahedronVolumeWithIdealVertexAtGamma` in `hyper_ideal_utility.hpp` (Phase 9b analytic Hessian). ⚠️ *Korrektur:* war fälschlich als „KolpakovMednykh 2006" zitiert — dieses Autorenpaar hat 2006 kein gemeinsames Paper veröffentlicht. Die Java-Quelle verlinkt korrekt auf math/0603097 (= Springborn 2008); der falsche Autorenname wurde beim C++-Port hinzugefügt.* |
| ✅ **Ushijima***A Volume Formula for Generalised Hyperbolic Tetrahedra*, in: Prékopa, Molnár (eds.) *Non-Euclidean Geometries*, Mathematics and Its Applications vol. 581, Springer 2006. DOI: [10.1007/0-387-29555-0_13](https://doi.org/10.1007/0-387-29555-0_13). arXiv: [math/0309216](https://arxiv.org/abs/math/0309216) (2003) | Tetrahedron volume with three ideal vertices: `calculateTetrahedronVolumeFullyIdeal` in `hyper_ideal_utility.hpp`. ⚠️ *Korrektur:* war fälschlich als „Meyerhoff, Ushijima — A Note on the Dirichlet Domain — The Epstein Birthday Schrift" zitiert. Meyerhoff ist kein Autor; Titel und Buch waren beide falsch. Die Java-Quelle verlinkt korrekt auf DOI 10.1007/0-387-29555-0_13 ohne Autorennamen. |
| **Pinkall, Polthier***Computing Discrete Minimal Surfaces and Their Conjugates*, Experimental Mathematics **2**(1), pp. 1536 (1993). DOI: [10.1080/10586458.1993.10504266](https://doi.org/10.1080/10586458.1993.10504266) | `euclidean_hessian.hpp` — cotangent Laplacian |
| **Bobenko, Springborn***Variational Principles for Circle Patterns and Koebe's Theorem*, Trans. Amer. Math. Soc. **356**(2), pp. 659689 (2004). arXiv: [math/0203250](https://arxiv.org/abs/math/0203250) | Variational angle-sum framework underlying all three functionals |
| **Luo***Combinatorial Yamabe Flow on Surfaces*, Commun. Contemp. Math. **6**(5), pp. 765780 (2004). DOI: [10.1142/S0219199704001501](https://doi.org/10.1142/S0219199704001501). arXiv: [math/0306167](https://arxiv.org/abs/math/0306167) | Inversive-distance functional — **new research** in Phase 9a.2 (no Java original; implemented from this paper + Glickenstein 2011 + Bowers-Stephenson 2004) |
| **Bowers, Stephenson***Uniformizing dessins and Belyĭ maps via circle packing*, Memoirs of the AMS 170(805) (2004) | Introduces **inversive-distance circle packings** (used in Phase 9a.2). *Hinweis:* die zur Initialisierung benutzte Formel I_ij = (²r_i²r_j²)/(2 r_i r_j) ist die **klassische** inversive Distanz (vgl. Glickenstein §5.2: ℓ²=r_i²+r_j²+2r_ir_jη), nicht eine eigene „Bowers-Stephenson-Identität" — BS liefern die Packungstheorie, nicht diese Formel. |
| **Glickenstein***Discrete conformal variations and scalar curvature on piecewise flat two- and three-dimensional manifolds*, J. Differential Geometry **87**(2) (2011), pp. 201238 | Analytic Hessian of the inversive-distance functional. ⚠️ *Korrektur:* die Arbeit nummeriert Gleichungen **nicht** im Format „(4.6)" — der Verweis ist durch die **§5.2**-Parametrisierung ²_ij = r²_i + r²_j + 2 r_i r_j η_ij zu ersetzen. Cross-correspondence: η_ij ist die inversive Distanz und entspricht dem Kosinus des **Supplements** des Schnittwinkels (Schnitt bei arccos(η_ij)) — also I_ij = cos θ_e **nur bis aufs Vorzeichen/Supplement**, nicht wörtlich. |
| ✅ **Bobenko, Pinkall, Springborn***Discrete conformal maps and ideal hyperbolic polyhedra*, Geometry & Topology **19**(4) (2015), pp. 21552215. arXiv: [1005.2698](https://arxiv.org/abs/1005.2698) (first posted 2010) | Face-based circle-packing functional (`CPEuclideanFunctional.java``cp_euclidean_functional.hpp`, Phase 9a.1) |
@@ -79,10 +79,10 @@ builds on this paper and augments it with Ptolemaic flips.
|---|---|
| **Farkas, Kra***Riemann Surfaces*, Springer GTM 71 | Siegel period matrix, Teichmüller theory |
| **Siegel***Topics in Complex Function Theory, Vol. 2*, Wiley | Siegel upper half-space H_g, Sp(2g,) reduction |
| **Bobenko, Mercat, Schmies***Period Matrices of Polyhedral Surfaces*, in: Computational Approach to Riemann Surfaces (2011) | Discrete period matrices on polyhedral surfaces |
| **Bobenko, Mercat, Schmies***Conformal Structures and Period Matrices of Polyhedral Surfaces*, in: Bobenko, Klein (eds.) *Computational Approach to Riemann Surfaces*, Lecture Notes in Mathematics vol. 2013, Springer 2011, pp. 213226. DOI: [10.1007/978-3-642-17413-1_7](https://doi.org/10.1007/978-3-642-17413-1_7) | Discrete period matrices on polyhedral surfaces |
| **Bobenko, Bücking***Convergence of discrete period matrices and discrete holomorphic integrals for ramified coverings of the Riemann sphere*, Math. Phys. Anal. Geom. **24**, Art. 23 (2021). DOI: [10.1007/s11040-021-09394-2](https://doi.org/10.1007/s11040-021-09394-2) | Phase 10b: discrete Siegel period matrix Ωᵢⱼ from cotangent-weighted integration **plus** the convergence result Ω_discrete → Ω_smooth under refinement (für ramified coverings) — belegt die Diskret-zu-glatt-Aussage in `novelty-statement.md §3.3. |
| **Rivin, Schlenker** — *The Schläfli formula in Einstein manifolds with boundary*, Electron. Res. Announc. AMS **5** (1999), pp. 1823 | Phase 9b-analytic: modern form of the Schläfli identity `2 dV = Σ aₑ dα` for manifolds with boundary — the bilinear form used to derive the analytic HyperIdeal Hessian. |
| **Pinkall, Springborn** — *A discrete version of Liouville's theorem on conformal maps*, Geometriae Dedicata **214** (2021), pp. 389398. arXiv: [1911.00966](https://arxiv.org/abs/1911.00966) | Phase 10b uniqueness: proves that the discrete conformal structure (and hence Ω) is a conformal invariant — the discrete Liouville theorem. Justifies that conformallab++ outputs a canonical representative. |
| **Born, Bücking, Springborn** — *Quasiconformal distortion of projective transformations and discrete conformal maps*, arXiv: [1505.01341](https://arxiv.org/abs/1505.01341) (2015) | Phase 10c error analysis: quantifies how well the discrete H²/Γ embedding approximates the smooth hyperbolic metric; error bounds for the Fuchsian group representation. |
| **Knöppel, Crane, Pinkall, Schröder** — *Stripe Patterns on Surfaces*, ACM SIGGRAPH (2015). DOI: [10.1145/2766890](https://doi.org/10.1145/2766890) | Phase 10a cross-validation: applies discrete holomorphic 1-forms to direction field design; geometry-central provides an independent C++ implementation to cross-check the Phase 10a `DiscreteHolomorphicFormUtility` port. |
| **Born, Bücking, Springborn** — *Quasiconformal distortion of projective transformations and discrete conformal maps*, Discrete & Computational Geometry **57**(2), pp. 305317 (2017). DOI: [10.1007/s00454-016-9854-7](https://doi.org/10.1007/s00454-016-9854-7). arXiv: [1505.01341](https://arxiv.org/abs/1505.01341) (preprint 2015) | Phase 10c error analysis: quantifies how well the discrete H²/Γ embedding approximates the smooth hyperbolic metric; error bounds for the Fuchsian group representation. |
| **Knöppel, Crane, Pinkall, Schröder** — *Stripe Patterns on Surfaces*, ACM Transactions on Graphics **34**(4), Article 39 (SIGGRAPH 2015). DOI: [10.1145/2767000](https://doi.org/10.1145/2767000). ⚠️ *Kein arXiv-Preprint* (arXiv:1502.06686 ist ein anderes Paper — Data-Driven Shape Analysis — und wurde aus dem papers/-Ordner entfernt). | Phase 10a cross-validation: applies discrete holomorphic 1-forms to direction field design; geometry-central provides an independent C++ implementation to cross-check the Phase 10a `DiscreteHolomorphicFormUtility` port. |
| **Sawhney, Crane***Boundary First Flattening*, ACM TOG **37**(1), Article 5 (2017). DOI: [10.1145/3132705](https://doi.org/10.1145/3132705) | Complementary method to Phase 9d: boundary-prescribed conformal flattening — user specifies boundary shape, interior conforms freely. Contrast: conformallab++ prescribes cone angles in the interior; BFF prescribes the boundary. Alternative approach for applications needing controlled boundary. |

View File

@@ -59,7 +59,7 @@ Status: ✅ done · ⬜ open (actionable) · ⏸ deferred (intentional) · ⛔ b
| V3 | input-val | 🟡 | ✅ | Sonnet | S1 |
| C1 | test-cov | 🔴 | ✅ | Sonnet | S1 |
| N4, N6 | numerics | 🟡/🔵 | ✅ | Haiku | S1 |
| M1, M2, M4 | math-cite | 🟡/🔵 | ✅ | Haiku | S1 |
| M1, M2, M4 | math-cite | 🟡/🔵 | ✅⚠️ | Haiku → re-fix 2026-06-04 | S1 + nachkorrigiert |
| C2, C3 | test-cov | 🔴 | ✅ | Sonnet | S1 |
| V1, V2, V4 | input-val | 🟡 | ✅ | Sonnet | S1 |
| I2, I3, I4 | test-cov | 🟡 | ✅ | Sonnet | S1 |
@@ -70,10 +70,10 @@ Status: ✅ done · ⬜ open (actionable) · ⏸ deferred (intentional) · ⛔ b
| I1 | test-cov | 🟡 | ✅ | Opus | S2 |
| H1 | test-cov | 🔵 | ✅ | Opus | S2 |
| N7 | numerics | 🔵 | ✅ | Opus | S2 |
| **H3** | test-cov | 🔵 | | Sonnet→🔍Opus | **S3** |
| **H4** | test-cov | 🔵 | | Sonnet→🔍Opus | **S3** |
| **H5** | test-cov | 🔵 | | Sonnet→🔍Opus | **S3** |
| **V5, V6** | input-val | 🔵 | | Sonnet→🔍Opus | **S3** |
| **H3** | test-cov | 🔵 | | Sonnet→🔍Opus | **S3** |
| **H4** | test-cov | 🔵 | | Sonnet→🔍Opus | **S3** |
| **H5** | test-cov | 🔵 | | Sonnet→🔍Opus | **S3** |
| **V5, V6** | input-val | 🔵 | | Sonnet→🔍Opus | **S3** |
| **N2** | numerics | 🟡 | ⬜ | Haiku→🔍Opus | **S4** |
| **thread-safety doc** | thread-safety | 🟡 | ⬜ | Haiku→🔍Opus | **S4** |
| **M3** | math-cite | 🟡 | ⬜ | Haiku→🔍Opus | **S4** |
@@ -126,14 +126,18 @@ CGAL result types (`Conformal_map_result`, `Hyper_ideal_map_result`,
</details>
### S3 — Robustness & test-gap closure (Sonnet → 🔍 Opus)
- **H3** — `enforce_gauss_bonnet` reports the magnitude of the applied correction.
- **H4** — test `reduce_to_fundamental_domain` boundary `Im(τ)==0.0`.
- **H5** — integration test for the degenerate-triangle path in the Newton solve.
- **V5** — make the hand-rolled XML reader *reject* reformatted-but-valid XML
instead of silently mis-reading it into zeros.
- **V6** — DOF-vector-vs-mesh size check on load.
- **🔍 Opus review:** verify the new rejections don't break valid round-trips.
### S3 — Robustness & test-gap closure (DONE, 2026-06-01, Sonnet impl + Opus review)
Implementation shipped in commit `135bcf0` (included in P1 merge `bd613a6`).
Follow-up commit closes the doc-tracker gap and fixes dead `found_dofvector` variable
(V5 rule 4: `<DOFVector>` missing now throws instead of silently returning empty `x`).
- **H3** — `enforce_gauss_bonnet` returns `|deficit|` (both overloads); 3 new tests.
- **H4** — `ReduceToFD_ThrowsForRealAxisBoundary` covers `Im(τ)==0.0` exact boundary.
- **H5** — 2 integration tests: sliver triangle (no crash/NaN) + exact-degenerate collinear.
- **V5** — `load_result_xml` rejects non-conforming XML (3 strict-subset checks); canonical
round-trip regression test passes. V5 rule 4 (`<DOFVector>` must be present) now enforced.
- **V6** — `check_dof_vector_size(x, expected, context)` throws on mismatch; 3 new tests.
- **🔍 Opus review:** CHANGES-REQUESTED resolved — implementation correct; code commits
were redundant with `135bcf0` on main; doc follow-up applied on `chore/s3-followup`.
### ⬜ S4 — Documentation & citations (Haiku → 🔍 Opus)
- **N2** — `doc/math/tolerances.md`: every numerical threshold, its role, and
@@ -162,6 +166,42 @@ Gated by the author's reply on porting/relicensing rights.
### 👤 Out of model scope
- **M5** — the large hand-derivations need a domain-expert prose review
(the numerical results are already validated; the prose is not).
- **Alle Zitationen** — alle `references.md`-Einträge müssen von einem
Fachexperten manuell verifiziert werden (siehe Lektion unten).
---
## ⚠️ Lektion: KI-gestützte Citation-Audits können Fehler einführen
**Datum:** 2026-06-04
**Befund:** Die M1-Auflösung in S1 (Haiku, 2026-05-31) war selbst fehlerhaft:
- Der Haiku-Audit erkannte korrekt, dass `KolpakovMednykh` in `references.md` fehlt
- Als „Fix" wurde die Zeile mit arXiv:math/0603097 ergänzt — aber **math/0603097 ist Springborn 2008**, nicht KolpakovMednykh
- Das Autorenpaar „Kolpakov & Mednykh" hat **2006 kein gemeinsames Paper veröffentlicht** (früheste Zusammenarbeit: 2010, über Torusknoten, nicht Tetraedervolumen)
- Der falsche Autorenname entstand bereits beim Java→C++-Port; der Audit hat ihn zementiert statt korrigiert
**Nachkorrektur:** 2026-06-04, 7 Dateien korrigiert (Code-Kommentare, references.md, roadmap, architecture-doc, tests-doc, audit-doc).
**Konsequenz für das Projekt:**
> KI-Modelle können bei Citation-Audits plausibel klingende aber falsche
> Autoren/Jahres-Zuordnungen produzieren — besonders wenn die Primärquelle
> (Java-Code) nur einen Link ohne Autorennamen enthält.
**Empfehlung:**
Vor jeder öffentlichen Veröffentlichung / CGAL-Submission müssen **alle** Einträge
in `references.md` von einem **Fachexperten (Mensch)** gegen die tatsächlichen
Papiere verifiziert werden:
| Priorität | Was prüfen |
|---|---|
| 🔴 Hoch | Formeln in Code-Kommentaren (`hyper_ideal_utility.hpp`, `hyper_ideal_functional.hpp`) gegen die zitierten Paper |
| 🔴 Hoch | Ushijima 2006 (DOI 10.1007/0-387-29555-0_13) — arXiv math/0309216 — korrigiert: kein Meyerhoff, anderer Titel, anderes Buch |
| 🟡 Mittel | Ob Springborn 2008 (math/0603097) die 12-Term-Lobachevsky-Formel tatsächlich enthält |
| 🟡 Mittel | M3: post-2023 / arXiv-only Zitationen (Bowers-Bowers-Lutz 2026 etc.) |
| 🔵 Niedrig | Alle weiteren `references.md`-Einträge auf Titel/Jahr/DOI-Konsistenz |
---

View File

@@ -12,9 +12,12 @@ Status legend: 🔴 Critical · 🟡 Important · 🔵 Polish
> **✅ Resolution status (2026-05-31, Session 1):** **V1/V2/V4 ✅** (JSON parse +
> field checks, XML stoi/stod guarded — all surface as `std::runtime_error` with
> path), **V3 ✅** (NaN/Inf vertex-coordinate guard in `load_mesh`). **V5** (XML
> strict-reject) and **V6** (DOF-size check) **open** — scheduled S3 in
> [`finding-orchestration.md`](finding-orchestration.md). 298/298 tests green.
> path), **V3 ✅** (NaN/Inf vertex-coordinate guard in `load_mesh`).
> **V5/V6 ✅** (2026-06-01, S3): `load_result_xml` now enforces a strict
> internal-only XML subset (three format checks; non-conforming files throw
> `runtime_error` instead of silently returning zeros); `check_dof_vector_size`
> helper added for the DOF-count mismatch check at call sites. 6 new tests.
> See [`finding-orchestration.md`](finding-orchestration.md). 313/313 tests green.
> **Threat model:** this is a scientific library, not a network service, so the bar
> is "fail cleanly and diagnosably", not "resist attackers". But meshes and result

View File

@@ -16,6 +16,16 @@ Status legend: 🔴 Critical · 🟡 Important · 🔵 Polish
> future-dated/arXiv citations) **open** → S4; **M5** (prose derivation review)
> needs a **domain expert** (out of model scope). See
> [`finding-orchestration.md`](finding-orchestration.md).
>
> **⚠️ M1 Nachkorrektur (2026-06-04):** Die ursprüngliche M1-Auflösung war selbst
> fehlerhaft — arXiv:math/0603097 ist **Springborn 2008** (*A variational principle
> for weighted Delaunay triangulations and hyperideal polyhedra*), nicht
> KolpakovMednykh. Kolpakov und Mednykh haben 2006 kein gemeinsames Paper
> veröffentlicht (früheste Zusammenarbeit: 2010). Der falsche Autorenname wurde beim
> Java→C++-Port erfunden; die Java-Quelle verlinkt korrekt auf math/0603097 ohne
> Autorennamen. Korrekturen angewendet in: `hyper_ideal_utility.hpp`,
> `hyper_ideal_functional.hpp`, `test_hyper_ideal_functional.cpp`,
> `doc/math/references.md`.
> **Good news up front:** `doc/math/references.md` is unusually scholarly and already
> contains several *self-corrections* (the Glickenstein "eq. (4.6)" numbering fix →
@@ -58,8 +68,8 @@ load-bearing formula with no entry.
### Fix
Add a `references.md` row: Kolpakov, Mednykh — *(full title)*, arXiv `math/0603097`,
mapped to `hyper_ideal_utility.hpp`. Likewise confirm the Meyerhoff / Ushijima 2006
volume reference (cited in code) has a row.
mapped to `hyper_ideal_utility.hpp`. Ushijima 2006 (DOI 10.1007/0-387-29555-0_13, arXiv math/0309216) has a row —
sole author is Ushijima; "Meyerhoff" is not a co-author (corrected 2026-06-04).
### Acceptance criteria
- Every formula cited inline in `code/include/` has a matching `references.md` entry.

View File

@@ -19,9 +19,11 @@ Status legend: 🔴 Critical · 🟡 Important · 🔵 Hint / nice-to-have
> **I2/I3/I4 ✅** (serialization / mesh / spherical-hessian negative tests),
> **H2 ✅** (five Newton loops unified into `newton_core`, folding in B2/B3/B4/B5).
> **I1 ✅** (`NewtonStatus` enum) + **H1 ✅** (iteration count) done in S2.
> **Open:** **H3/H4/H5** → S3; **I5** (coverage on full suite, un-gates the
> 80/70/90 threshold) → S5.
> See [`finding-orchestration.md`](finding-orchestration.md). 298/298 tests green.
> **H3/H4/H5** (2026-06-01, S3): `enforce_gauss_bonnet` returns `|deficit|`;
> `ReduceToFD_ThrowsForRealAxisBoundary` test added; two degenerate-triangle
> integration tests characterize the Newton solver's behavior.
> **Open:** **I5** (coverage on full suite, un-gates the 80/70/90 threshold) → S5.
> See [`finding-orchestration.md`](finding-orchestration.md). 313/313 tests green.
> **Note:** This audit is complementary to `external-audit-2026-05-30.md` (which
> covers port-faithfulness bugs). There is no overlap in findings — this one is

View File

@@ -145,10 +145,10 @@ The phase numbers match `doc/roadmap/phases.md`.
### Hyper-ideal volume formulas for 2- and 3-ideal-vertex faces (Phase 9b+, 🔲 planned)
* **Mathematical sources:**
- **Kolpakov, A. & Mednykh, A.** (2012). *Spherical structures on torus
knots and links.* Sibirsk. Mat. Zh. 53(3), 535541 — see the earlier
arXiv:math/0603097 for the one-ideal-vertex formula already implemented
as `calculateTetrahedronVolumeWithIdealVertexAtGamma`.
- **Springborn, B.** (2008). *A variational principle for weighted Delaunay
triangulations and hyperideal polyhedra.* J. Differential Geometry **78**(2),
333367. arXiv:math/0603097 — the source of the one-ideal-vertex formula
already implemented as `calculateTetrahedronVolumeWithIdealVertexAtGamma`.
- **Milnor, J.** (1982). *Hyperbolic geometry: The first 150 years.*
Bull. Amer. Math. Soc. 6(1), 924. → Volume of an ideal tetrahedron
via Clausen function; this is the all-ideal case with 4 ideal vertices.
@@ -175,10 +175,10 @@ The phase numbers match `doc/roadmap/phases.md`.
* **Acceptance criteria:**
- Identify the correct formula for a hyper-ideal tetrahedron with exactly
2 ideal vertices from the literature (check Kolpakov-Mednykh generalisations
2 ideal vertices from the literature (check Springborn 2008 §34 generalisations
and Vinberg orthoscheme decomposition).
- Implement `calculateTetrahedronVolumeWithTwoIdealVertices(…)` analogous
to the existing Kolpakov-Mednykh function.
to the existing Springborn 2008 one-ideal-vertex function.
- Implement `calculateTetrahedronVolumeWithThreeIdealVertices(…)` (one
hyper-ideal + three ideal = fully cusp-like case).
- Replace the `throw std::logic_error` in `face_energy()` with the correct

63
papers/MANUAL-DOWNLOAD.md Normal file
View File

@@ -0,0 +1,63 @@
# Manuell herunterzuladende Paper & Dissertationen
Diese Paper konnten nicht automatisch geladen werden (kein freies arXiv-Preprint,
hinter Verlag-Paywall, oder Buchkapitel).
---
## Dissertationen (Open Access — TU Berlin Depositonce)
| Autor | Titel | Link |
|---|---|---|
| **Sechelmann 2016** | *Variational Methods for Discrete Surface Parameterization: Applications and Implementation* | [depositonce.tu-berlin.de/items/8e2988b2-d991-45b5-aad5-9fb7988f3b2f](https://depositonce.tu-berlin.de/items/8e2988b2-d991-45b5-aad5-9fb7988f3b2f) — CC BY-SA 4.0 |
| **Lutz 2024** | *Decorated Discrete Conformal Equivalence, Canonical Tessellations, and Polyhedral Realization* | [doi.org/10.14279/depositonce-20357](https://doi.org/10.14279/depositonce-20357) — Open Access |
---
## Paper hinter Verlag-Paywall (ggf. über Institutional Access / Google Scholar)
| Autor(en) | Titel | Venue | DOI / Link |
|---|---|---|---|
| **Ushijima** ⚠️ (Einzelautor — kein Meyerhoff!) | *A Volume Formula for Generalised Hyperbolic Tetrahedra* | Prékopa, Molnár (eds.) *Non-Euclidean Geometries*, Springer 2006 | [doi.org/10.1007/0-387-29555-0_13](https://doi.org/10.1007/0-387-29555-0_13) · arXiv [math/0309216](https://arxiv.org/abs/math/0309216) (arXiv gibt 500 für alte math/-Preprints — manuell laden) |
| **Pinkall, Polthier** | *Computing Discrete Minimal Surfaces and Their Conjugates* | Experimental Mathematics **2**(1), 1993 | [projecteuclid.org/euclid.em/1062620735](https://projecteuclid.org/euclid.em/1062620735) |
| **Bowers, Stephenson** | *Uniformizing dessins and Belyĭ maps via circle packing* | Memoirs AMS **170**(805), 2004 | [ams.org/books/memo/0805](https://bookstore.ams.org/memo-170-805) |
| **Erickson, Whittlesey** | *Greedy Optimal Homotopy and Homology Generators* | SODA 2005 | [dl.acm.org/doi/10.5555/1070432.1070581](https://dl.acm.org/doi/10.5555/1070432.1070581) |
| **Desbrun, Kanso, Tong** | *Discrete Differential Forms for Computational Modeling* | SIGGRAPH Course Notes 2006 | [dl.acm.org/doi/10.1145/1185657.1185665](https://dl.acm.org/doi/10.1145/1185657.1185665) |
| **Soliman, Slepčev, Crane** | *Optimal Cone Singularities for Conformal Flattening* | ACM TOG **37**(4), 2018 | [doi.org/10.1145/3197517.3201367](https://doi.org/10.1145/3197517.3201367) — Autorenseite: [cs.cmu.edu/~kmcrane](https://www.cs.cmu.edu/~kmcrane/Projects/OptimalCones/index.html) |
| **Gillespie, Springborn, Crane** | *Discrete Conformal Equivalence of Polyhedral Surfaces* | ACM TOG / SIGGRAPH 2021 | [doi.org/10.1145/3450626.3459763](https://doi.org/10.1145/3450626.3459763) — Autorenseite: [markjgillespie.com/Research/CEPS](https://markjgillespie.com/Research/CEPS/index.html) |
| **Sharp, Soliman, Crane** | *Navigating Intrinsic Triangulations* | ACM TOG / SIGGRAPH 2019 | [doi.org/10.1145/3306346.3323042](https://doi.org/10.1145/3306346.3323042) — Autorenseite: [cs.cmu.edu/~kmcrane](https://www.cs.cmu.edu/~kmcrane/Projects/NavigatingIntrinsicTriangulations/index.html) |
| **Alexa, Wardetzky** | *Discrete Laplacians on General Polygonal Meshes* | ACM SIGGRAPH 2011 | [doi.org/10.1145/1964921.1964997](https://doi.org/10.1145/1964921.1964997) |
| **Bunge, Herholz, Kazhdan, Botsch** | *Polygon Laplacian Made Simple* | CGF **39**(2), 2020 | [doi.org/10.1111/cgf.13931](https://doi.org/10.1111/cgf.13931) |
| **Rivin, Schlenker** | *The Schläfli formula in Einstein manifolds with boundary* | Electron. Res. Announc. AMS **5**, 1999 | [ams.org/era/1999-05-03](https://www.ams.org/era/1999-05-03) — wahrscheinlich frei |
| **Bobenko, Mercat, Schmies** | *Conformal Structures and Period Matrices of Polyhedral Surfaces* | in: Bobenko, Klein (eds.) *Computational Approach to Riemann Surfaces*, LNM vol. 2013, Springer 2011, pp. 213226 | [doi.org/10.1007/978-3-642-17413-1_7](https://doi.org/10.1007/978-3-642-17413-1_7) — Buchkapitel |
---
## Bücher (Bibliothek / Kauf)
| Autor(en) | Titel | Verlag |
|---|---|---|
| **Farkas, Kra** | *Riemann Surfaces* (2. Aufl.) | Springer GTM 71 |
| **Siegel** | *Topics in Complex Function Theory, Vol. 2* | Wiley |
---
## Hinweis: Autorenseiten oft freier als DOI
Für die SIGGRAPH-Paper (Gillespie 2021, Sharp 2019, Soliman 2018) gibt es auf den
CMU/Autorenseiten oft direkte PDF-Downloads ohne Paywall.
---
## Zitationsfehler in references.md — behoben (2026-06-07)
> **arXiv:math/0603097** war in `references.md` fälschlicherweise **KolpakovMednykh**
> zugewiesen. Tatsächlich ist das der **Springborn 2008** Artikel
> (*A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*).
> Das Autorenpaar Kolpakov & Mednykh hat 2006 kein gemeinsames Paper veröffentlicht.
> → `references.md` wurde korrigiert (siehe PR „citation attribution fixes");
> Springborn 2008 liegt als `springborn-2008-weighted-delaunay-hyperideal.pdf` vor.
>
> Ebenfalls behoben: DOI 10.1007/0-387-29555-0_13 war fälschlich „Meyerhoff, Ushijima"
> → korrekt **Ushijima** (Einzelautor). Plus 4 weitere Korrekturen (Knöppel-DOI/arXiv,
> Born-Bücking-Springborn Jahr, Bobenko-Mercat-Schmies Titel, fehlende vol/pages).