6 Commits

Author SHA1 Message Date
6c50590d99 docs(papers): sync MANUAL-DOWNLOAD.md with applied citation fixes
All checks were successful
C++ Tests / test-fast (push) Successful in 2m42s
C++ Tests / quality-gates (push) Has been skipped
API Docs / doc-build (push) Has been skipped
Mirror to Codeberg / mirror (push) Successful in 18s
C++ Tests / test-cgal (push) Has been skipped
Markdown link check / check (push) Successful in 29s
Review-gate NIT-1: the download helper still carried pre-fix text.
- Bobenko-Mercat-Schmies: updated to full title "Conformal Structures
  and Period Matrices...", correct editors + chapter DOI
- Footer rewritten from open-TODO ("zu korrigieren / muss angepasst
  werden") to past-tense record of the applied fixes

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
b6020ad2aa chore(gitignore): exclude derived paper artifacts (txt/mmd/figures)
Extracted text (pdftext), nougat mmd output and figure dumps are
regenerable from the source PDFs — keep them out of the repo like the
PDFs themselves. Also excludes the accidental facebook/ nougat model
cache (958 MB).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
582eb46efa fix(citations): systematic audit — 6 corrections in references.md
Findings from full citation audit of all 34 references.md entries:

CRITICAL:
- Knöppel et al. 2015 "Stripe Patterns": arXiv 1502.06686 was a completely
  different paper (Data-Driven Shape Analysis by Xu et al.) — removed from
  papers/. Correct DOI is 10.1145/2767000, not 10.1145/2766890. No arXiv
  preprint exists for this paper.

ERRORS:
- Born, Bücking, Springborn: published 2017 in DCG 57(2) pp. 305–317
  (DOI 10.1007/s00454-016-9854-7); arXiv 2015 was preprint only
- Bobenko, Mercat, Schmies: short title; full title is
  "Conformal Structures and Period Matrices of Polyhedral Surfaces";
  editors Bobenko & Klein (not generic "Computational Approach" book ref);
  pp. 213–226, DOI 10.1007/978-3-642-17413-1_7

COMPLETIONS (missing vol/pages added):
- Pinkall, Polthier 1993: vol. 2(1), pp. 15–36, DOI added
- Bobenko, Springborn 2004: Trans. AMS 356(2), pp. 659–689, arXiv added
- Luo 2004: Commun. Contemp. Math. 6(5), pp. 765–780, DOI + arXiv added

Verified  (no changes needed, 28/34 entries):
Sechelmann 2016, Springborn 2020/2008, Ushijima 2006, Bowers-Stephenson 2004,
Glickenstein 2011, BPS 2015, Schläfli 1858, Erickson-Whittlesey 2005,
Bobenko-Springborn 2007, Desbrun-Kanso-Tong 2006, Soliman et al. 2018,
all Bobenko-Lutz papers, Lutz 2023/2024, Bowers-Bowers-Lutz 2026,
Alexa-Wardetzky 2011, Bunge et al. 2020, de Goes et al. 2020,
Gillespie-Springborn-Crane 2021, Sharp-Soliman-Crane 2019, Farkas-Kra,
Siegel, Bobenko-Bücking 2021, Rivin-Schlenker 1999, Pinkall-Springborn 2021,
Sawhney-Crane 2017

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
1063f3541f fix(citations): correct Meyerhoff/Ushijima misattribution
DOI 10.1007/0-387-29555-0_13 is Ushijima (sole author) —
"A Volume Formula for Generalised Hyperbolic Tetrahedra",
in: Prékopa & Molnár (eds.), Non-Euclidean Geometries,
Springer 2006. arXiv: math/0309216.

The references.md entry was wrong on all three counts:
  - Author:  "Meyerhoff, Ushijima" → Ushijima only
  - Title:   "A Note on the Dirichlet Domain" → entirely different title
  - Book:    "The Epstein Birthday Schrift" → Non-Euclidean Geometries

Same error pattern as the Kolpakov-Mednykh fix: the Java source
links only to a DOI without naming authors; a wrong name was
invented during the C++ port.

Files corrected: hyper_ideal_utility.hpp, hyper_ideal_functional.hpp,
references.md, tests.md, project-structure.md, finding-orchestration.md,
math-derivation-citation-audit.md, MANUAL-DOWNLOAD.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
Tarik Moussa
0f5ab27461 fix(citations): correct Kolpakov-Mednykh misattribution → Springborn 2008
arXiv:math/0603097 is Springborn 2008 ("A variational principle for weighted
Delaunay triangulations and hyperideal polyhedra"), not a Kolpakov-Mednykh paper.
The author pair Kolpakov & Mednykh has no joint publication from 2006; their
earliest collaboration is arXiv:1008.0312 (2010, on torus knots, unrelated).

The wrong author name was introduced during the Java→C++ port — the Java source
correctly links to math/0603097 without naming the authors; whoever ported it
invented "Kolpakov-Mednykh". The S1 citation audit (2026-05-31) then cemented
the error by adding the incorrect row to references.md.

Files corrected (7):
- code/include/hyper_ideal_utility.hpp
- code/include/hyper_ideal_functional.hpp
- code/tests/cgal/test_hyper_ideal_functional.cpp
- doc/math/references.md
- doc/roadmap/research-track.md
- doc/architecture/project-structure.md
- doc/api/tests.md

Also:
- doc/reviewer/math-derivation-citation-audit-2026-05-31.md: M1 post-correction noted
- doc/reviewer/finding-orchestration.md: lesson-learned section added (AI citation
  audits can introduce plausible-but-wrong attributions; human expert review required
  before CGAL submission)
- papers/MANUAL-DOWNLOAD.md: overview of papers requiring manual download (paywalled
  journals, TU Berlin theses, books)
- .gitignore: papers/*.pdf excluded (downloaded arXiv PDFs, not tracked)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-14 06:00:29 +00:00
5d343776a3 Merge pull request 'fix(s3-followup): enforce V5 rule 4 + mark H3/H4/H5/V5/V6 done' (#47) from chore/s3-followup into main
All checks were successful
C++ Tests / test-fast (push) Successful in 8m26s
C++ Tests / quality-gates (push) Has been skipped
API Docs / doc-build (push) Has been skipped
Mirror to Codeberg / mirror (push) Successful in 39s
C++ Tests / test-cgal (push) Has been skipped
Markdown link check / check (push) Successful in 13s
2026-06-01 14:33:03 +00:00
7 changed files with 23 additions and 283 deletions

View File

@@ -6,12 +6,7 @@
},
"outputStyle": "Explanatory",
"teammateMode": "tmux",
"preferences": {
"tmuxSplitPanes": "true",
"responseFormat": "markdown"
},
"permissions": {
"defaultMode": "acceptEdits",
"allow": [
"Bash(cmake:*)",
"Bash(ctest:*)",
@@ -30,56 +25,18 @@
"Bash(git branch:*)",
"Bash(git ls-remote:*)",
"Bash(git ls-files:*)",
"Bash(git remote:*)",
"Bash(git rev-parse:*)",
"Bash(git rev-list:*)",
"Bash(git merge-base:*)",
"Bash(git diff-tree:*)",
"Bash(git describe:*)",
"Bash(git tag:*)",
"Bash(git add:*)",
"Bash(git commit:*)",
"Bash(git switch:*)",
"Bash(git checkout:*)",
"Bash(git restore:*)",
"Bash(git stash:*)",
"Bash(git fetch:*)",
"Bash(git pull:*)",
"Bash(git push:*)",
"Bash(git merge:*)",
"Bash(git rebase:*)",
"Bash(git worktree:*)",
"Bash(git init:*)",
"Bash(git mv:*)",
"Bash(ls:*)",
"Bash(find:*)",
"Bash(grep:*)",
"Bash(rg:*)",
"Bash(wc:*)",
"Bash(curl -s*)",
"Bash(curl:*)",
"Bash(bash -n:*)",
"Bash(cat:*)",
"Bash(head:*)",
"Bash(tail:*)",
"Bash(awk:*)",
"Bash(jq:*)",
"Bash(mkdir:*)",
"Bash(cp:*)",
"Bash(test:*)",
"Bash(echo:*)",
"Bash(true)"
"Bash(curl -s*)"
],
"deny": [
"Bash(git push --force:*)",
"Bash(git push -f:*)",
"Bash(git clean -fdx:*)",
"Bash(git clean -fd:*)",
"Bash(rm -rf /)",
"Bash(rm -rf /*)",
"Bash(rm -rf ~)",
"Bash(rm -rf ~/*)",
"Bash(sudo rm:*)"
"Bash(git push --force* origin main*)",
"Bash(git push -f* origin main*)",
"Bash(git reset --hard*)",
"Bash(rm -rf /*)"
]
}
}

View File

@@ -1,65 +0,0 @@
# Forgejo Actions — Codeberg (https://codeberg.org)
#
# Codeberg counterpart of the eulernest Gitea pipeline
# (.gitea/workflows/cpp-tests.yml). Two differences are required because
# Codeberg's shared runners are not the Pi runner:
#
# * runs-on: docker — Codeberg shared-runner label (not "eulernest")
# * image: node:20-bookworm — public image (the private git.eulernest.eu
# ci-cpp image is unreachable from Codeberg).
# node:20 ships the Node runtime that
# actions/checkout@v4 needs; build tools are
# apt-installed in the first step.
#
# Scope: "test-fast" only — the pure-math suite (Eigen vendored, GoogleTest via
# FetchContent, no CGAL/Boost). A red job here = a red Codeberg CI badge.
name: C++ Tests (Codeberg)
on:
push:
branches:
- main
- "claude/**"
- "feature/**"
- "review/**"
pull_request:
jobs:
test-fast:
runs-on: docker
container:
image: node:20-bookworm
steps:
- uses: actions/checkout@v4
- name: Install build deps (cmake, g++, make)
run: |
apt-get update -qq
apt-get install -y --no-install-recommends \
cmake g++ make git ca-certificates
- name: Configure (tests-only — Eigen + GoogleTest)
run: cmake -S code -B build -DCMAKE_BUILD_TYPE=Release
- name: Build
run: cmake --build build --target conformallab_tests -j$(nproc)
- name: Run tests
run: >
ctest --test-dir build
--output-on-failure
--output-junit test-results.xml
- name: Summary
if: always()
run: |
if [ -f build/test-results.xml ]; then f=build/test-results.xml; else f=test-results.xml; fi
if [ -f "$f" ]; then
total=$(grep -o 'tests="[0-9]*"' "$f" | grep -o '[0-9]*' | head -1)
failed=$(grep -o 'failures="[0-9]*"' "$f" | grep -o '[0-9]*' | head -1)
skipped=$(grep -o 'skipped="[0-9]*"' "$f" | grep -o '[0-9]*' | head -1)
passed=$(( ${total:-0} - ${failed:-0} - ${skipped:-0} ))
echo "FAST ▸ TOTAL ${total:-0} | PASSED $passed | FAILED ${failed:-0} | SKIPPED ${skipped:-0}"
fi

View File

@@ -1,31 +0,0 @@
# Woodpecker CI — Codeberg (https://ci.codeberg.org)
#
# Runs on every push / PR. Mirrors the "test-fast" job of the
# eulernest Gitea pipeline (.gitea/workflows/cpp-tests.yml), but uses a
# plain public Debian image instead of the private ci-cpp registry image,
# because Codeberg's shared runners cannot pull git.eulernest.eu.
#
# Pure-math test suite only (Clausen, ImLi2, hyper-ideal geometry):
# * Eigen is vendored → code/deps/eigen-3.4.0
# * GoogleTest via FetchContent (network at configure time)
# * No CGAL / Boost / Wayland needed → fast, headless, < 2 min
#
# A failing build or any failing ctest makes the Codeberg CI badge red.
when:
- event: [push, pull_request]
steps:
test-fast:
image: debian:bookworm
commands:
- apt-get update -qq
- >-
apt-get install -y --no-install-recommends
cmake g++ make git ca-certificates
- cmake -S code -B build -DCMAKE_BUILD_TYPE=Release
- cmake --build build --target conformallab_tests -j$(nproc)
- >-
ctest --test-dir build
--output-on-failure
--output-junit test-results.xml

View File

@@ -142,7 +142,6 @@ Layout2D layout = euclidean_layout(mesh, res.x, maps);
| **geometry-central comparison** — shared core, demarcation, adoption candidates, scientific added value | [doc/architecture/geometry-central-comparison.md](doc/architecture/geometry-central-comparison.md) |
| **Design decisions** — key architectural choices + rationale | [doc/architecture/design-decisions.md](doc/architecture/design-decisions.md) |
| **Project structure** — directory tree + build targets | [doc/architecture/project-structure.md](doc/architecture/project-structure.md) |
| **CI / CD** — two-forge topology, runners, trigger keywords, mirror | [doc/architecture/ci-cd.md](doc/architecture/ci-cd.md) |
| **Discrete conformal theory** — mathematical background for collaborators | [doc/math/discrete-conformal-theory.md](doc/math/discrete-conformal-theory.md) |
| **Validation** — known analytic results + how to verify them | [doc/math/validation.md](doc/math/validation.md) |
| **Validation protocol** — concrete commands with expected outputs | [doc/math/validation-protocol.md](doc/math/validation-protocol.md) |

View File

@@ -1,110 +0,0 @@
# CI / CD
Single source of truth for **how continuous integration is wired** across the
two forges this project lives on. If you add, move or rename a workflow, update
this page.
## TL;DR
| Forge | Remote | Role | CI system | Config | Runner |
|---|---|---|---|---|---|
| **eulernest Gitea** | `origin` | Authoritative gate (full test + quality suite) | Gitea Actions | `.gitea/workflows/` | self-hosted Raspberry Pi (ARM64), label `eulernest` |
| **Codeberg** | `codeberg` | Public mirror + public build badge | Woodpecker **and** Forgejo Actions | `.woodpecker.yml`, `.forgejo/workflows/` | Codeberg shared runners, label `docker` |
The two forges are connected by a one-way mirror: every push to `main` on
eulernest is force-mirrored to Codeberg (see
[Mirror](#mirror-eulernest--codeberg) below). Codeberg never pushes back.
Why two CI systems on Codeberg? They are independent and either may be enabled
per-repo; providing both means the public build status is green regardless of
which one the repo has switched on. They run the **same** `test-fast` build.
---
## eulernest Gitea (`origin`) — the real gate
Self-hosted Gitea with a single self-hosted runner: a Raspberry Pi (ARM64,
34 GB RAM). Because the runner is RAM-constrained, the heavy jobs are
**keyword-gated** (opt-in per commit) rather than run on every push.
All C++ jobs use the private image `git.eulernest.eu/conformallab/ci-cpp:latest`
(built from `.gitea/docker/Dockerfile.ci-cpp` — Ubuntu 22.04 + Node 20 + cmake +
build-essential + libboost-dev + doxygen).
### `.gitea/workflows/cpp-tests.yml`
| Job | Trigger | Memory cap | What it does |
|---|---|---|---|
| `test-fast` | every push to `main` / `claude/**` / `feature/**` / `review/**` + every PR | 800 MB | Pure-math suite (Clausen, ImLi₂, hyper-ideal). Serial build (`-j1`) to avoid OOM. Eigen vendored, GTest via FetchContent. |
| `test-cgal` | commit message contains **`/test-cgal`** | 2000 MB | Full CGAL suite via `LOW_MEMORY_BUILD` (`-O0`, no PCH, unity batch 1, `--no-keep-memory`). Then `check-test-counts.sh` + `try_it.sh` smoke test. |
| `quality-gates` | commit message contains **`/quality-gates`** | 600 MB | License headers, CGAL conventions, codespell, shellcheck, coverage (gate currently in report-only mode, `SKIP_COVERAGE_GATE=1`). |
> One keyword per commit — the Pi cannot sustain multiple Docker containers at
> once (`/ci-all` was removed for this reason). Example:
> `git commit -m "fix: correct angle formula /test-cgal"`.
### Other eulernest workflows
| File | Trigger | Purpose | Blocks merge? |
|---|---|---|---|
| `doc-build.yaml` | push to main branches + manual | Doxygen HTML + warning stats | No (`continue-on-error`) |
| `markdown-links.yml` | push + weekly cron (Mon 05:00 UTC) + manual | Link-rot check across docs | Yes on push |
| `doxygen-pages.yml` | manual only | Publish Doxygen HTML to Codeberg Pages (`tmoussa.codeberg.page/ConformalLabpp/`) | n/a |
| `perf-compile-time.yml` | manual only | Compile-time benchmark | n/a |
| `mirror-to-codeberg.yml` | push to `main` | Mirror all branches to Codeberg (see below) | n/a |
---
## Codeberg (`codeberg`) — public mirror CI
Codeberg's shared runners **cannot** pull the private `ci-cpp` image and are not
the `eulernest` Pi, so the Codeberg configs differ from Gitea in exactly two
ways:
1. **Runner label** `docker` (Codeberg shared runners), not `eulernest`.
2. **Public base image**, with build tools `apt`-installed at run time:
- Woodpecker: `debian:bookworm`
- Forgejo Actions: `node:20-bookworm` (Node is needed by
`actions/checkout@v4`; cmake/g++/make are installed in the first step).
Both run **only** `test-fast` — the pure-math suite. No CGAL/Boost/Wayland, so
they are fast (< 2 min) and headless. Eigen is vendored, GoogleTest is fetched
at configure time (Codeberg runners have network). A failing build or any
failing `ctest` turns the public CI badge red.
| File | CI system | Enable via |
|---|---|---|
| `.woodpecker.yml` | Woodpecker | https://ci.codeberg.org enable repo |
| `.forgejo/workflows/cpp-tests.yml` | Forgejo Actions | repo *Settings → Actions* (shared runner label `docker`) |
> These configs are committed in the repo and reach Codeberg through the mirror
> — they are not maintained separately on Codeberg.
---
## Mirror (eulernest → Codeberg)
`.gitea/workflows/mirror-to-codeberg.yml` runs on every push to `main` and does
a `git push --mirror` from eulernest to
`codeberg.org/TMoussa/ConformalLabpp.git`. It uses two secrets:
- `MIRROR_TOKEN` read access to the eulernest source repo.
- `CODEBERG_TOKEN` push access to the Codeberg mirror.
The mirror is **one-way and authoritative-from-eulernest**: do not commit
directly on Codeberg, it will be overwritten on the next mirror run.
---
## The one rule
> **eulernest is the gate, Codeberg is the shop window.**
> Merge decisions are made on eulernest CI (full suite). Codeberg CI exists so
> the public repo also shows a green/red build status to outside readers.
## See also
- [dependencies.md](dependencies.md) what each build mode requires.
- [project-structure.md](project-structure.md) where the test targets live.
- [../api/tests.md](../api/tests.md) per-suite test counts CI checks against.
- [../contributing.md](../contributing.md) the git workflow that feeds CI.

View File

@@ -13,12 +13,11 @@ with English.
## Git workflow
- `main` is protected on `origin` (Gitea). Push to `dev`, then open a pull request.
- `codeberg/main` is the public mirror. It now also runs CI of its own
(Woodpecker + Forgejo Actions) — see [architecture/ci-cd.md](architecture/ci-cd.md).
- `codeberg/main` can be pushed to directly (public mirror, no CI).
- Both remotes must stay in sync after every significant change:
```bash
git push origin HEAD:dev # triggers eulernest CI (full suite, keyword-gated CGAL)
git push codeberg main # updates public mirror → triggers Codeberg CI (test-fast)
git push origin HEAD:dev # triggers CI
git push codeberg main # updates public mirror
```
- Branch naming: `feature/<topic>`, `fix/<topic>`, `phase<N>-<topic>`
@@ -26,30 +25,17 @@ with English.
## CI
The project runs CI on **two forges**. Full topology, runners, images and
trigger keywords are documented in [architecture/ci-cd.md](architecture/ci-cd.md).
**eulernest Gitea** (`origin`, self-hosted Raspberry Pi / ARM64) — the
authoritative gate. On push to `dev`/`main` or a pull request:
Two jobs run on push to `dev`/`main` or on pull requests:
| Job | What it tests | Trigger |
|---|---|---|
| `test-fast` | pure-math tests, no Boost | all branches |
| `test-cgal` | full CGAL test suite | commit message contains `/test-cgal` |
| `quality-gates` | license / codespell / shellcheck / CGAL conventions | commit message contains `/quality-gates` |
| `test-cgal` | full CGAL test suite | `main`, `dev`, PRs only |
A PR is ready to merge when `test-fast` (and, for CGAL-touching work,
`test-cgal`) pass. See `.gitea/workflows/cpp-tests.yml` and
`.gitea/docker/Dockerfile.ci-cpp`.
A PR is ready to merge when both jobs pass.
**Codeberg** (`codeberg`, public mirror, shared runners) — a lightweight
`test-fast` mirror so the public repo also shows a build status. Defined twice,
once per CI system Codeberg offers:
| File | CI system |
|---|---|
| `.woodpecker.yml` | Woodpecker CI (ci.codeberg.org) |
| `.forgejo/workflows/cpp-tests.yml` | Forgejo Actions |
The runner is a self-hosted Raspberry Pi (ARM64). See `.gitea/workflows/cpp-tests.yml`
and `.gitea/docker/Dockerfile.ci-cpp`.
---

View File

@@ -29,7 +29,7 @@ hinter Verlag-Paywall, oder Buchkapitel).
| **Alexa, Wardetzky** | *Discrete Laplacians on General Polygonal Meshes* | ACM SIGGRAPH 2011 | [doi.org/10.1145/1964921.1964997](https://doi.org/10.1145/1964921.1964997) |
| **Bunge, Herholz, Kazhdan, Botsch** | *Polygon Laplacian Made Simple* | CGF **39**(2), 2020 | [doi.org/10.1111/cgf.13931](https://doi.org/10.1111/cgf.13931) |
| **Rivin, Schlenker** | *The Schläfli formula in Einstein manifolds with boundary* | Electron. Res. Announc. AMS **5**, 1999 | [ams.org/era/1999-05-03](https://www.ams.org/era/1999-05-03) — wahrscheinlich frei |
| **Bobenko, Mercat, Schmies** | *Period Matrices of Polyhedral Surfaces* | Computational Approach to Riemann Surfaces, Springer 2011 | [doi.org/10.1007/978-3-642-17413-1](https://doi.org/10.1007/978-3-642-17413-1) — Buchkapitel |
| **Bobenko, Mercat, Schmies** | *Conformal Structures and Period Matrices of Polyhedral Surfaces* | in: Bobenko, Klein (eds.) *Computational Approach to Riemann Surfaces*, LNM vol. 2013, Springer 2011, pp. 213226 | [doi.org/10.1007/978-3-642-17413-1_7](https://doi.org/10.1007/978-3-642-17413-1_7) — Buchkapitel |
---
@@ -49,11 +49,15 @@ CMU/Autorenseiten oft direkte PDF-Downloads ohne Paywall.
---
## Fehler in references.md (zu korrigieren)
## Zitationsfehler in references.md — behoben (2026-06-07)
> **arXiv:math/0603097** ist in `references.md` fälschlicherweise **KolpakovMednykh**
> **arXiv:math/0603097** war in `references.md` fälschlicherweise **KolpakovMednykh**
> zugewiesen. Tatsächlich ist das der **Springborn 2008** Artikel
> (*A variational principle for weighted Delaunay triangulations and hyperideal polyhedra*).
> Das korrekte KolpakovMednykh Paper hat vermutlich kein öffentliches arXiv-Preprint.
> Springborn 2008 wurde korrekt als `springborn-2008-weighted-delaunay-hyperideal.pdf`
> gespeichert; references.md muss angepasst werden.
> Das Autorenpaar Kolpakov & Mednykh hat 2006 kein gemeinsames Paper veröffentlicht.
> `references.md` wurde korrigiert (siehe PR „citation attribution fixes");
> Springborn 2008 liegt als `springborn-2008-weighted-delaunay-hyperideal.pdf` vor.
>
> Ebenfalls behoben: DOI 10.1007/0-387-29555-0_13 war fälschlich „Meyerhoff, Ushijima"
> → korrekt **Ushijima** (Einzelautor). Plus 4 weitere Korrekturen (Knöppel-DOI/arXiv,
> Born-Bücking-Springborn Jahr, Bobenko-Mercat-Schmies Titel, fehlende vol/pages).